Commit 6bdfe3b9 authored by Takuto Ikuta's avatar Takuto Ikuta Committed by Commit Bot

Use V8GeneratedCoreBindings only in jumbo build

This is retry of
https://codereview.chromium.org/2318933002/

Current chromium/src can build all with is_official_build=true in windows.
This improves build parallelism on windows.

Bug: 634231
Change-Id: Ie16541b56d90718ab01a992b7f4cbc07caebcd22
Reviewed-on: https://chromium-review.googlesource.com/836627Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarKenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525565}
parent 71133305
...@@ -145,8 +145,7 @@ generate_origin_trial_features("bindings_core_origin_trial_features") { ...@@ -145,8 +145,7 @@ generate_origin_trial_features("bindings_core_origin_trial_features") {
] ]
} }
if (is_win || use_jumbo_build) { if (use_jumbo_build) {
# On Windows Official release builds, we try to preserve symbol space.
bindings_core_generated_interface_files = bindings_core_generated_interface_files =
[ "$bindings_core_v8_output_dir/V8GeneratedCoreBindings.cpp" ] [ "$bindings_core_v8_output_dir/V8GeneratedCoreBindings.cpp" ]
} else { } else {
...@@ -173,7 +172,7 @@ group("bindings_core_v8_generated") { ...@@ -173,7 +172,7 @@ group("bindings_core_v8_generated") {
public_deps = [ public_deps = [
":bindings_core_impl_generated", ":bindings_core_impl_generated",
] ]
if (is_win || use_jumbo_build) { if (use_jumbo_build) {
public_deps += [ ":generate_bindings_core_v8_all_interfaces" ] public_deps += [ ":generate_bindings_core_v8_all_interfaces" ]
} else { } else {
public_deps += [ ":generate_bindings_core_v8_interfaces" ] public_deps += [ ":generate_bindings_core_v8_interfaces" ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment