Commit 6d9fa21a authored by Erik Chen's avatar Erik Chen Committed by Commit Bot

Add comment for browser manager.

This CL has no intended behavior change.

Static Lacros configuration should be performed in Lacros rather than
Ash. This is because configuration can cause Lacros P0 blockers, but we
don't want to delay Ash releases for Lacros P0 blockers. The result is
that Lacros can be DOA or have functionality regressions.

Change-Id: Id3df0b8c49059ac1353e8e57044cbf5538f2b710
Bug: 1145713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518422Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
Reviewed-by: default avatarErik Chen <erikchen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824223}
parent eed88ce8
...@@ -310,6 +310,9 @@ void BrowserManager::StartWithLogFile(base::ScopedFD logfd) { ...@@ -310,6 +310,9 @@ void BrowserManager::StartWithLogFile(base::ScopedFD logfd) {
std::string crash_dir = std::string crash_dir =
browser_util::GetUserDataDir().Append("crash_dumps").AsUTF8Unsafe(); browser_util::GetUserDataDir().Append("crash_dumps").AsUTF8Unsafe();
// Static configuration should be enabled from Lacros rather than Ash. This
// vector should only be used for dynamic configuration.
// TODO(https://crbug.com/1145713): Remove existing static configuration.
std::vector<std::string> argv = {chrome_path, std::vector<std::string> argv = {chrome_path,
"--ozone-platform=wayland", "--ozone-platform=wayland",
"--user-data-dir=" + user_data_dir, "--user-data-dir=" + user_data_dir,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment