Convert c/b/ui/webui/tab_strip/ from base::Bind to Once/Repeating

Bug: 1152282
Change-Id: I136f70d9899f978da94f7793dc060c7f4ffcd468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601337Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839017}

chrome/browser/ui/webui/tab_strip/tab_strip_ui_handler.cc

@@ -169,10 +169,11 @@ TabStripUIHandler::TabStripUIHandler(Browser* browser,
                                      TabStripUIEmbedder* embedder)
     : browser_(browser),
       embedder_(embedder),
-      thumbnail_tracker_(base::Bind(&TabStripUIHandler::HandleThumbnailUpdate,
+      thumbnail_tracker_(
+          base::BindRepeating(&TabStripUIHandler::HandleThumbnailUpdate,
                               base::Unretained(this))),
       tab_before_unload_tracker_(
-          base::Bind(&TabStripUIHandler::OnTabCloseCancelled,
+          base::BindRepeating(&TabStripUIHandler::OnTabCloseCancelled,
                               base::Unretained(this))) {}
 TabStripUIHandler::~TabStripUIHandler() = default;
 
@@ -350,66 +351,70 @@ void TabStripUIHandler::TabBlockedStateChanged(content::WebContents* contents,
 // content::WebUIMessageHandler:
 void TabStripUIHandler::RegisterMessages() {
   web_ui()->RegisterMessageCallback(
-      "createNewTab", base::Bind(&TabStripUIHandler::HandleCreateNewTab,
+      "createNewTab",
+      base::BindRepeating(&TabStripUIHandler::HandleCreateNewTab,
                           base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
-      "getTabs",
-      base::Bind(&TabStripUIHandler::HandleGetTabs, base::Unretained(this)));
+      "getTabs", base::BindRepeating(&TabStripUIHandler::HandleGetTabs,
+                                     base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "getGroupVisualData",
-      base::Bind(&TabStripUIHandler::HandleGetGroupVisualData,
+      base::BindRepeating(&TabStripUIHandler::HandleGetGroupVisualData,
                           base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
-      "getThemeColors", base::Bind(&TabStripUIHandler::HandleGetThemeColors,
+      "getThemeColors",
+      base::BindRepeating(&TabStripUIHandler::HandleGetThemeColors,
                           base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
-      "groupTab",
-      base::Bind(&TabStripUIHandler::HandleGroupTab, base::Unretained(this)));
+      "groupTab", base::BindRepeating(&TabStripUIHandler::HandleGroupTab,
+                                      base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
-      "ungroupTab",
-      base::Bind(&TabStripUIHandler::HandleUngroupTab, base::Unretained(this)));
+      "ungroupTab", base::BindRepeating(&TabStripUIHandler::HandleUngroupTab,
+                                        base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
-      "moveGroup",
-      base::Bind(&TabStripUIHandler::HandleMoveGroup, base::Unretained(this)));
+      "moveGroup", base::BindRepeating(&TabStripUIHandler::HandleMoveGroup,
+                                       base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
-      "moveTab",
-      base::Bind(&TabStripUIHandler::HandleMoveTab, base::Unretained(this)));
+      "moveTab", base::BindRepeating(&TabStripUIHandler::HandleMoveTab,
+                                     base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "setThumbnailTracked",
-      base::Bind(&TabStripUIHandler::HandleSetThumbnailTracked,
+      base::BindRepeating(&TabStripUIHandler::HandleSetThumbnailTracked,
                           base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
-      "closeContainer", base::Bind(&TabStripUIHandler::HandleCloseContainer,
+      "closeContainer",
+      base::BindRepeating(&TabStripUIHandler::HandleCloseContainer,
                           base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
-      "closeTab",
-      base::Bind(&TabStripUIHandler::HandleCloseTab, base::Unretained(this)));
+      "closeTab", base::BindRepeating(&TabStripUIHandler::HandleCloseTab,
+                                      base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "showBackgroundContextMenu",
-      base::Bind(&TabStripUIHandler::HandleShowBackgroundContextMenu,
+      base::BindRepeating(&TabStripUIHandler::HandleShowBackgroundContextMenu,
                           base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "showEditDialogForGroup",
-      base::Bind(&TabStripUIHandler::HandleShowEditDialogForGroup,
+      base::BindRepeating(&TabStripUIHandler::HandleShowEditDialogForGroup,
                           base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "showTabContextMenu",
-      base::Bind(&TabStripUIHandler::HandleShowTabContextMenu,
+      base::BindRepeating(&TabStripUIHandler::HandleShowTabContextMenu,
                           base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
-      "getLayout",
-      base::Bind(&TabStripUIHandler::HandleGetLayout, base::Unretained(this)));
+      "getLayout", base::BindRepeating(&TabStripUIHandler::HandleGetLayout,
+                                       base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "reportTabActivationDuration",
-      base::Bind(&TabStripUIHandler::HandleReportTabActivationDuration,
+      base::BindRepeating(&TabStripUIHandler::HandleReportTabActivationDuration,
                           base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "reportTabDataReceivedDuration",
-      base::Bind(&TabStripUIHandler::HandleReportTabDataReceivedDuration,
+      base::BindRepeating(
+          &TabStripUIHandler::HandleReportTabDataReceivedDuration,
           base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "reportTabCreationDuration",
-      base::Bind(&TabStripUIHandler::HandleReportTabCreationDuration,
+      base::BindRepeating(&TabStripUIHandler::HandleReportTabCreationDuration,
                           base::Unretained(this)));
 }
 

chrome/browser/ui/webui/tab_strip/thumbnail_tracker.cc

@@ -59,7 +59,7 @@ class ThumbnailTracker::ContentsData : public content::WebContentsObserver,
 
 ThumbnailTracker::ThumbnailTracker(ThumbnailUpdatedCallback callback)
     : ThumbnailTracker(std::move(callback),
-                       base::Bind(GetThumbnailFromTabHelper)) {}
+                       base::BindRepeating(GetThumbnailFromTabHelper)) {}
 
 ThumbnailTracker::ThumbnailTracker(ThumbnailUpdatedCallback callback,
                                    GetThumbnailCallback thumbnail_getter)

chrome/browser/ui/webui/tab_strip/thumbnail_tracker_unittest.cc

@@ -44,7 +44,7 @@ class ThumbnailTrackerTest : public ::testing::Test,
   ThumbnailTrackerTest()
       : thumbnail_tracker_(
             thumbnail_updated_callback_.Get(),
-            base::Bind(&ThumbnailTrackerTest::GetTestingThumbnail,
+            base::BindRepeating(&ThumbnailTrackerTest::GetTestingThumbnail,
                                 base::Unretained(this))) {}
 
   static SkBitmap CreateTestingBitmap() {