Commit 713e7735 authored by Adam Langley's avatar Adam Langley Committed by Commit Bot

device/fido: hex-encode virtual authenticator names.

These strings appear in log messages, so nicer to avoid raw binary.

Change-Id: Ide8b6bcbd57b8cec5d123a974243e74b2b40e511
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214461
Commit-Queue: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: default avatarMartin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#771856}
parent 56935ae8
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
#include "base/bind.h" #include "base/bind.h"
#include "base/rand_util.h" #include "base/rand_util.h"
#include "base/strings/string_number_conversions.h"
#include "components/cbor/values.h" #include "components/cbor/values.h"
#include "components/cbor/writer.h" #include "components/cbor/writer.h"
#include "crypto/ec_private_key.h" #include "crypto/ec_private_key.h"
...@@ -562,7 +563,9 @@ FidoTransportProtocol VirtualFidoDevice::DeviceTransport() const { ...@@ -562,7 +563,9 @@ FidoTransportProtocol VirtualFidoDevice::DeviceTransport() const {
// static // static
std::string VirtualFidoDevice::MakeVirtualFidoDeviceId() { std::string VirtualFidoDevice::MakeVirtualFidoDeviceId() {
return "VirtualFidoDevice-" + base::RandBytesAsString(32); uint8_t rand_bytes[32];
base::RandBytes(rand_bytes, sizeof(rand_bytes));
return "VirtualFidoDevice-" + base::HexEncode(rand_bytes);
} }
} // namespace device } // namespace device
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment