Commit 71671602 authored by robertocn's avatar robertocn Committed by Commit bot

Shortening thank you message for a cleaner output.

Also, restoring ttest constants to original values in ttest_test.

BUG=404088

Review URL: https://codereview.chromium.org/616903003

Cr-Commit-Position: refs/heads/master@{#297457}
parent ae092e2a
...@@ -222,8 +222,7 @@ To run locally: ...@@ -222,8 +222,7 @@ To run locally:
REPRO_STEPS_TRYJOB = """ REPRO_STEPS_TRYJOB = """
To reproduce on a performance try bot: To reproduce on a performance try bot:
1. Edit run-perf-test.cfg 1. Edit run-perf-test.cfg
2. Upload your patch with: $ git cl upload --bypass-hooks 2. $ git try -b <bot> --svn_repo='svn://svn.chromium.org/chrome-try/try-perf'
3. Send to the try server: $ git cl try -m tryserver.chromium.perf -b <bot>
Notes: Notes:
a) Follow the in-file instructions in run-perf-test.cfg. a) Follow the in-file instructions in run-perf-test.cfg.
...@@ -247,21 +246,9 @@ https://sites.google.com/a/chromium.org/dev/developers/performance-try-bots ...@@ -247,21 +246,9 @@ https://sites.google.com/a/chromium.org/dev/developers/performance-try-bots
""" """
RESULTS_THANKYOU = """ RESULTS_THANKYOU = """
===== THANK YOU FOR CHOOSING BISECT AIRLINES ===== O O | Visit http://www.chromium.org/developers/core-principles for Chrome's
Visit http://www.chromium.org/developers/core-principles for Chrome's policy X | policy on perf regressions. Contact chrome-perf-dashboard-team with any
on perf regressions. / \ | questions or suggestions about bisecting. THANK YOU."""
Contact chrome-perf-dashboard-team with any questions or suggestions about
bisecting.
. .-----.
. .---. \ \==)
. |PERF\ \ \\
. | ---------'-------'-----------.
. . 0 0 0 0 0 0 0 0 0 0 0 0 0 0 |_`-.
. \_____________.-------._______________)
. / /
. / /
. / /==)
. ._____."""
def _AddAdditionalDepotInfo(depot_info): def _AddAdditionalDepotInfo(depot_info):
......
...@@ -62,7 +62,7 @@ class TTestTest(unittest.TestCase): ...@@ -62,7 +62,7 @@ class TTestTest(unittest.TestCase):
t, _, p = ttest.WelchsTTest( t, _, p = ttest.WelchsTTest(
[100, 101, 100, 101, 100], [1, 2, 1, 2, 1, 2, 1, 2]) [100, 101, 100, 101, 100], [1, 2, 1, 2, 1, 2, 1, 2])
self.assertGreaterEqual(t, 250) self.assertGreaterEqual(t, 250)
self.assertLessEqual(0.01, p) self.assertLessEqual(p, 0.01)
def testTTestVariance(self): def testTTestVariance(self):
"""Verifies that higher variance -> higher p value.""" """Verifies that higher variance -> higher p value."""
...@@ -87,6 +87,8 @@ class LookupTableTest(unittest.TestCase): ...@@ -87,6 +87,8 @@ class LookupTableTest(unittest.TestCase):
"""Tests for functionality related to lookup of p-values in a table.""" """Tests for functionality related to lookup of p-values in a table."""
def setUp(self): def setUp(self):
self.original_TWO_TAIL = ttest.TWO_TAIL
self.original_TABLE = ttest.TABLE
ttest.TWO_TAIL = [1, 0.2, 0.1, 0.05, 0.02, 0.01] ttest.TWO_TAIL = [1, 0.2, 0.1, 0.05, 0.02, 0.01]
ttest.TABLE = { ttest.TABLE = {
1: [0, 6.314, 12.71, 31.82, 63.66, 318.31], 1: [0, 6.314, 12.71, 31.82, 63.66, 318.31],
...@@ -95,6 +97,10 @@ class LookupTableTest(unittest.TestCase): ...@@ -95,6 +97,10 @@ class LookupTableTest(unittest.TestCase):
4: [0, 2.132, 2.776, 3.747, 4.604, 7.173], 4: [0, 2.132, 2.776, 3.747, 4.604, 7.173],
} }
def tearDown(self):
ttest.TWO_TAIL = self.original_TWO_TAIL
ttest.TABLE = self.original_TABLE
def testLookupExactMatch(self): def testLookupExactMatch(self):
"""Tests a lookup when there is an exact match.""" """Tests a lookup when there is an exact match."""
self.assertEqual(0.1, ttest._LookupPValue(3.182, 3)) self.assertEqual(0.1, ttest._LookupPValue(3.182, 3))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment