Disable custom fullscreen transition on 10.13+, fix titlebar appearance during the transition.

Bug: 741478
Change-Id: I7b576273b0e7ec08af24291115db1c8e8f9b3da8
Reviewed-on: https://chromium-review.googlesource.com/581232Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Commit-Queue: Sidney San Martin <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488687}

chrome/browser/ui/cocoa/browser_window_controller_private.mm

@@ -1081,6 +1081,10 @@ willPositionSheet:(NSWindow*)sheet
 }
 
 - (BOOL)shouldUseCustomAppKitFullscreenTransition:(BOOL)enterFullScreen {
+  // Use the native transition on 10.13+: https://crbug.com/741478.
+  if (base::mac::IsAtLeastOS10_13())
+    return NO;
+
   // Disable the custom exit animation in OSX 10.9: http://crbug.com/526327#c3.
   if (base::mac::IsOS10_9() && !enterFullScreen)
     return NO;

chrome/browser/ui/cocoa/framed_browser_window.mm

@@ -198,6 +198,9 @@ const CGFloat kWindowGradientHeight = 24.0;
 }
 
 - (void)adjustTitlebarContainer:(NSView*)titlebarContainer {
+  if ([self styleMask] & NSFullScreenWindowMask)
+    return;
+
   DCHECK(chrome::ShouldUseFullSizeContentView());
   DCHECK([NSStringFromClass([titlebarContainer class])
       isEqual:@"NSTitlebarContainerView"]);