The app-menu button upgrade icon is a circle, while the menu item used a...

The app-menu button upgrade icon is a circle, while the menu item used a rounded rectangle. This ensures the menu image/icon is consistent with the button icon.

BUG=626915

Review-Url: https://codereview.chromium.org/2138103002
Cr-Commit-Position: refs/heads/master@{#405224}

chrome/browser/upgrade_detector.cc

@@ -59,7 +59,7 @@ gfx::Image UpgradeDetector::GetIcon() {
   DCHECK_NE(gfx::kPlaceholderColor, color);
 
   return gfx::Image(
-      gfx::CreateVectorIcon(gfx::VectorIconId::UPGRADE_MENU_ITEM, 16, color));
+      gfx::CreateVectorIcon(gfx::VectorIconId::BROWSER_TOOLS_UPDATE, color));
 }
 
 UpgradeDetector::UpgradeDetector()

ui/gfx/vector_icons/upgrade_menu_item.icon

-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-CANVAS_DIMENSIONS, 32,
-ROUND_RECT, 2, 2, 28, 28, 4,
-MOVE_TO, 12, 24,
-R_H_LINE_TO, 8,
-R_V_LINE_TO, -6,
-R_H_LINE_TO, 4,
-LINE_TO, 16, 8,
-LINE_TO, 8, 18,
-R_H_LINE_TO, 4,
-R_V_LINE_TO, 6,
-CLOSE,
-END

ui/gfx/vector_icons_sources.gypi

@@ -170,7 +170,6 @@
       'vector_icons/tab_usb_connected.icon',
       'vector_icons/tablet.icon',
       'vector_icons/translate.icon',
-      'vector_icons/upgrade_menu_item.icon',
       'vector_icons/videocam.icon',
       'vector_icons/warning.icon',
       'vector_icons/warning_badge.icon',