Add the reengagement notification to chrome://flags.

Make it possible to easily test the reengagement notification.

Bug: 1108002
Change-Id: I1fd85e9338164e55bea18b9e0208806aad47a996
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335637
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794319}

components/feature_engagement/public/feature_constants.cc

@@ -101,11 +101,11 @@ const base::Feature kIPHExploreSitesTileFeature{
     "IPH_ExploreSitesTile", base::FEATURE_DISABLED_BY_DEFAULT};
 const base::Feature kIPHFeedHeaderMenuFeature{
     "IPH_FeedHeaderMenu", base::FEATURE_DISABLED_BY_DEFAULT};
-const base::Feature kIPHChromeReengagementNotification1{
+const base::Feature kIPHChromeReengagementNotification1Feature{
     "IPH_ChromeReengagementNotification1", base::FEATURE_DISABLED_BY_DEFAULT};
-const base::Feature kIPHChromeReengagementNotification2{
+const base::Feature kIPHChromeReengagementNotification2Feature{
     "IPH_ChromeReengagementNotification2", base::FEATURE_DISABLED_BY_DEFAULT};
-const base::Feature kIPHChromeReengagementNotification3{
+const base::Feature kIPHChromeReengagementNotification3Feature{
     "IPH_ChromeReengagementNotification3", base::FEATURE_DISABLED_BY_DEFAULT};
 #endif  // defined(OS_ANDROID)
 

components/feature_engagement/public/feature_constants.h

@@ -69,9 +69,9 @@ extern const base::Feature kIPHTabGroupsDragAndDropFeature;
 extern const base::Feature kIPHTranslateMenuButtonFeature;
 extern const base::Feature kIPHExploreSitesTileFeature;
 extern const base::Feature kIPHFeedHeaderMenuFeature;
-extern const base::Feature kIPHChromeReengagementNotification1;
-extern const base::Feature kIPHChromeReengagementNotification2;
-extern const base::Feature kIPHChromeReengagementNotification3;
+extern const base::Feature kIPHChromeReengagementNotification1Feature;
+extern const base::Feature kIPHChromeReengagementNotification2Feature;
+extern const base::Feature kIPHChromeReengagementNotification3Feature;
 #endif  // defined(OS_ANDROID)
 
 #if defined(OS_IOS)

components/feature_engagement/public/feature_list.cc

@@ -27,6 +27,9 @@ const base::Feature* const kAllFeatures[] = {
     &kIPHChromeDuetTabSwitcherFeature,
     &kIPHChromeHomeExpandFeature,
     &kIPHChromeHomePullToRefreshFeature,
+    &kIPHChromeReengagementNotification1Feature,
+    &kIPHChromeReengagementNotification2Feature,
+    &kIPHChromeReengagementNotification3Feature,
     &kIPHContextualSearchWebSearchFeature,
     &kIPHContextualSearchPromoteTapFeature,
     &kIPHContextualSearchPromotePanelOpenFeature,

components/feature_engagement/public/feature_list.h

@@ -62,6 +62,12 @@ DEFINE_VARIATION_PARAM(kIPHChromeDuetTabSwitcherFeature,
 DEFINE_VARIATION_PARAM(kIPHChromeHomeExpandFeature, "IPH_ChromeHomeExpand");
 DEFINE_VARIATION_PARAM(kIPHChromeHomePullToRefreshFeature,
                        "IPH_ChromeHomePullToRefresh");
+DEFINE_VARIATION_PARAM(kIPHChromeReengagementNotification1Feature,
+                       "IPH_ChromeReengagementNotification1");
+DEFINE_VARIATION_PARAM(kIPHChromeReengagementNotification2Feature,
+                       "IPH_ChromeReengagementNotification2");
+DEFINE_VARIATION_PARAM(kIPHChromeReengagementNotification3Feature,
+                       "IPH_ChromeReengagementNotification3");
 DEFINE_VARIATION_PARAM(kIPHContextualSearchWebSearchFeature,
                        "IPH_ContextualSearchWebSearch");
 DEFINE_VARIATION_PARAM(kIPHContextualSearchPromoteTapFeature,
@@ -146,6 +152,9 @@ constexpr flags_ui::FeatureEntry::FeatureVariation
         VARIATION_ENTRY(kIPHChromeDuetTabSwitcherFeature),
         VARIATION_ENTRY(kIPHChromeHomeExpandFeature),
         VARIATION_ENTRY(kIPHChromeHomePullToRefreshFeature),
+        VARIATION_ENTRY(kIPHChromeReengagementNotification1Feature),
+        VARIATION_ENTRY(kIPHChromeReengagementNotification2Feature),
+        VARIATION_ENTRY(kIPHChromeReengagementNotification3Feature),
         VARIATION_ENTRY(kIPHContextualSearchWebSearchFeature),
         VARIATION_ENTRY(kIPHContextualSearchPromoteTapFeature),
         VARIATION_ENTRY(kIPHContextualSearchPromotePanelOpenFeature),