Commit 724dcab2 authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /third_party/blink/renderer/modules/websockets.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=ricea@chromium.org

Bug: 925652
Change-Id: I59e6a4fdc1295b778c9e33e35d57cf019617695d
Reviewed-on: https://chromium-review.googlesource.com/c/1437831
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: default avatarAdam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626453}
parent 74ca0335
...@@ -959,7 +959,7 @@ TEST_P(DOMWebSocketValidClosingTest, test) { ...@@ -959,7 +959,7 @@ TEST_P(DOMWebSocketValidClosingTest, test) {
EXPECT_EQ(DOMWebSocket::kClosing, websocket_scope.Socket().readyState()); EXPECT_EQ(DOMWebSocket::kClosing, websocket_scope.Socket().readyState());
} }
INSTANTIATE_TEST_CASE_P(DOMWebSocketValidClosing, INSTANTIATE_TEST_SUITE_P(DOMWebSocketValidClosing,
DOMWebSocketValidClosingTest, DOMWebSocketValidClosingTest,
testing::Values(1000, 3000, 3001, 4998, 4999)); testing::Values(1000, 3000, 3001, 4998, 4999));
...@@ -993,7 +993,7 @@ TEST_P(DOMWebSocketInvalidClosingCodeTest, test) { ...@@ -993,7 +993,7 @@ TEST_P(DOMWebSocketInvalidClosingCodeTest, test) {
EXPECT_EQ(DOMWebSocket::kConnecting, websocket_scope.Socket().readyState()); EXPECT_EQ(DOMWebSocket::kConnecting, websocket_scope.Socket().readyState());
} }
INSTANTIATE_TEST_CASE_P( INSTANTIATE_TEST_SUITE_P(
DOMWebSocketInvalidClosingCode, DOMWebSocketInvalidClosingCode,
DOMWebSocketInvalidClosingCodeTest, DOMWebSocketInvalidClosingCodeTest,
testing::Values(0, 1, 998, 999, 1001, 2999, 5000, 9999, 65535)); testing::Values(0, 1, 998, 999, 1001, 2999, 5000, 9999, 65535));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment