Fix GLCopyTextureCHROMIUMTest.InternalFormatNotSupported tests
Problem: There are 2 issues with these tests: 1. When testing glCopySubTextureCHROMIUM() the test does not clear the previous error, so it fails when it calls glGetError(), as the previous call to glTexImage2D also reports an error, GL_INVALID_ENUM for GL_RED and GL_RG. This only occurs with ES2 devices. 2. When testing glCopyTextureCHROMIUM(), the error that will get hit first and then returned depends on whether the test is being run on a device with OpenGL ES2 or ES3+ capabilities. On ES2, the error being returned is "internalformat GL_INVALID_VALUE". Solution: 1. Clear previous error when testing glCopySubTextureCHROMIUM for GL_INVALID_OPERATION so we get the error we are testing for. 2. Check if we get either GL_INVALID_VALUE or GL_INVALID_OPERATION, as either is possible depending on which ES stack (ES2 or ES3) is being executed base on the devices capabilities. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia99ea8a82341bd58fb634ea7144e142268ec6ab7 Reviewed-on: https://chromium-review.googlesource.com/1003075Reviewed-by:Antoine Labour <piman@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#549233}
Showing
Please register or sign in to comment