[chromium] Default to experimental-fully-parallel mode for chromium gpu port

https://bugs.webkit.org/show_bug.cgi?id=66606

Patch by James Robinson <jamesr@chromium.org> on 2011-08-19
Reviewed by Dirk Pranke.

The chromium GPU configuration does not (currently) contain any tests
incompatible with --experimental-fully-parallel, and this flag is a
significan speedup because of the directory canvas/philip/tests which
contains 802 tests in the same directory. Setting this option by
default on this configuration is a 2x speed in release, 44s to 22s,
and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@93463 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent ce461a9f
2011-08-19 James Robinson <jamesr@chromium.org>
[chromium] Default to experimental-fully-parallel mode for chromium gpu port
https://bugs.webkit.org/show_bug.cgi?id=66606
Reviewed by Dirk Pranke.
The chromium GPU configuration does not (currently) contain any tests
incompatible with --experimental-fully-parallel, and this flag is a
significan speedup because of the directory canvas/philip/tests which
contains 802 tests in the same directory. Setting this option by
default on this configuration is a 2x speed in release, 44s to 22s,
and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2011-08-19 Sheriff Bot <webkit.review.bot@gmail.com> 2011-08-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r93426. Unreviewed, rolling out r93426.
...@@ -65,6 +65,8 @@ def _set_gpu_options(port): ...@@ -65,6 +65,8 @@ def _set_gpu_options(port):
port._options.accelerated_compositing = True port._options.accelerated_compositing = True
if port.get_option('accelerated_2d_canvas') is None: if port.get_option('accelerated_2d_canvas') is None:
port._options.accelerated_2d_canvas = True port._options.accelerated_2d_canvas = True
if port.get_option('experimental_fully_parallel') is None:
port._options.experimental_fully_parallel = True
# FIXME: Remove this after http://codereview.chromium.org/5133001/ is enabled # FIXME: Remove this after http://codereview.chromium.org/5133001/ is enabled
# on the bots. # on the bots.
......
...@@ -67,6 +67,7 @@ class ChromiumGpuTest(unittest.TestCase): ...@@ -67,6 +67,7 @@ class ChromiumGpuTest(unittest.TestCase):
port = chromium_gpu.get(port_name=port_name, options=mock_options) port = chromium_gpu.get(port_name=port_name, options=mock_options)
self.assertTrue(port._options.accelerated_compositing) self.assertTrue(port._options.accelerated_compositing)
self.assertTrue(port._options.accelerated_2d_canvas) self.assertTrue(port._options.accelerated_2d_canvas)
self.assertTrue(port._options.experimental_fully_parallel)
self.assertEqual(port._options.builder_name, 'foo - GPU') self.assertEqual(port._options.builder_name, 'foo - GPU')
self.assertTrue(port.name().startswith(port_name)) self.assertTrue(port.name().startswith(port_name))
......
...@@ -377,8 +377,12 @@ def parse_args(args=None): ...@@ -377,8 +377,12 @@ def parse_args(args=None):
default=None, help=("controls worker model. Valid values are " default=None, help=("controls worker model. Valid values are "
"'inline' and 'processes'.")), "'inline' and 'processes'.")),
optparse.make_option("-f", "--experimental-fully-parallel", optparse.make_option("-f", "--experimental-fully-parallel",
action="store_true", default=False, action="store_true",
help="run all tests in parallel"), help="run all tests in parallel"),
optparse.make_option("--no-experimental-fully-parallel",
action="store_false",
dest="experimental_fully_parallel",
help="do not run all tests in parallel"),
optparse.make_option("--exit-after-n-failures", type="int", default=500, optparse.make_option("--exit-after-n-failures", type="int", default=500,
help="Exit after the first N failures instead of running all " help="Exit after the first N failures instead of running all "
"tests"), "tests"),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment