Commit 73ea038c authored by George Burgess IV's avatar George Burgess IV Committed by Commit Bot

fix an instance of bugprone-move-forwarding-reference

Unless it's guaranteed that `std::forward` always turns into an rvalue
ref, using `std::move(x)`, where `x`'s type is a universal reference, is
generally unsafe. `std::forward` is preferred for these cases.

Bug: 1134310
Change-Id: I1a6eeed1710070d1192e33a9a367b7ea55ad8589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443970
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Auto-Submit: George Burgess <gbiv@chromium.org>
Reviewed-by: default avatarOksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813216}
parent 90ce0218
......@@ -74,7 +74,7 @@ class PendingReceiver {
Interface>)(T&&)>>::value>* = nullptr>
PendingReceiver(T&& other)
: PendingReceiver(PendingReceiverConverter<T>::template To<Interface>(
std::move(other))) {}
std::forward<T>(other))) {}
#endif // !defined(OS_NACL)
~PendingReceiver() = default;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment