Commit 74427c0a authored by Pavol Marko's avatar Pavol Marko Committed by Commit Bot

Unconditionally use CertVerifierBuiltin for sign-in/lock profiles

Starting with M-78, use CertVerifierBuiltin for sign-in/lock profiles
unconditionally.
This allows easier reasoning about the state when implementing features
that rely on the CertVerifierBuiltin to be enabled on the sign-in
screen.

Bug: 939344
Test: browser_tests --gtest_filter=*ProfileNetworkContext*
Change-Id: I5d53b1b534370592fbd57d9bbbbc830962f32388
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750004
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: default avatarMatt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686593}
parent 6aa36d4d
...@@ -109,11 +109,7 @@ bool ShouldUseBuiltinCertVerifier(Profile* profile) { ...@@ -109,11 +109,7 @@ bool ShouldUseBuiltinCertVerifier(Profile* profile) {
if (chromeos::ProfileHelper::Get()->IsSigninProfile(profile) || if (chromeos::ProfileHelper::Get()->IsSigninProfile(profile) ||
chromeos::ProfileHelper::Get()->IsLockScreenAppProfile(profile)) { chromeos::ProfileHelper::Get()->IsLockScreenAppProfile(profile)) {
// No need to override the feature-set setting through policy for sign-in return true;
// and lock screen app profiles, as no custom trust anchors can be active
// there.
return base::FeatureList::IsEnabled(
net::features::kCertVerifierBuiltinFeature);
} }
// TODO(https://crbug.com/982936): Instead of evaluating the primary profile // TODO(https://crbug.com/982936): Instead of evaluating the primary profile
......
...@@ -320,25 +320,26 @@ class ProfileNetworkContextServiceCertVerifierBuiltinDisabledBrowsertest ...@@ -320,25 +320,26 @@ class ProfileNetworkContextServiceCertVerifierBuiltinDisabledBrowsertest
ProfileNetworkContextServiceCertVerifierBuiltinDisabledBrowsertest); ProfileNetworkContextServiceCertVerifierBuiltinDisabledBrowsertest);
}; };
// If the built-in cert verifier is disabled, it should be disabled everywhere. // If the built-in cert verifier feature is disabled, it should be disabled in
// user profiles but enabled in the sign-in profile.
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
ProfileNetworkContextServiceCertVerifierBuiltinDisabledBrowsertest, ProfileNetworkContextServiceCertVerifierBuiltinDisabledBrowsertest,
TurnedOffByFeature) { TurnedOffByFeature) {
SkipToLoginScreen(); SkipToLoginScreen();
EXPECT_FALSE(IsSigninProfileUsingBuiltinCertVerifier()); EXPECT_TRUE(IsSigninProfileUsingBuiltinCertVerifier());
LogIn(kAccountId, kAccountPassword, kEmptyServices); LogIn(kAccountId, kAccountPassword, kEmptyServices);
EXPECT_FALSE(IsActiveProfileUsingBuiltinCertVerifier()); EXPECT_FALSE(IsActiveProfileUsingBuiltinCertVerifier());
} }
// If the built-in cert verifier is disabled, but policy force-enables it for a // If the built-in cert verifier feature is disabled, but policy force-enables
// profile, it should be enabled in the profile. // it for a profile, it should be enabled in the profile.
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
ProfileNetworkContextServiceCertVerifierBuiltinDisabledBrowsertest, ProfileNetworkContextServiceCertVerifierBuiltinDisabledBrowsertest,
TurnedOffByFeatureOverrideByPolicy) { TurnedOffByFeatureOverrideByPolicy) {
SkipToLoginScreen(); SkipToLoginScreen();
EXPECT_FALSE(IsSigninProfileUsingBuiltinCertVerifier()); EXPECT_TRUE(IsSigninProfileUsingBuiltinCertVerifier());
SetPolicyValue(policy::key::kBuiltinCertificateVerifierEnabled, SetPolicyValue(policy::key::kBuiltinCertificateVerifierEnabled,
base::Value(true)); base::Value(true));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment