Commit 752239fe authored by Luca Hunkeler's avatar Luca Hunkeler Committed by Commit Bot

[Autofill Assistant] Use string instead of picture for onboarding title

Currently the title of the onboarding screen is a picture. This cl
changes it to a string so that it can be translated.

Bug: b/142367194
Change-Id: Icd501c7c9d19eaf88c4c91706250a62fb46a7dd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020929Reviewed-by: default avatarMathias Carlen <mcarlen@chromium.org>
Commit-Queue: Luca Hunkeler <hluca@google.com>
Cr-Commit-Position: refs/heads/master@{#738927}
parent cd7bc921
<vector xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:width="24dp"
android:height="24dp"
android:viewportWidth="192"
android:viewportHeight="192"
tools:targetApi="21">
<path
android:pathData="M172,60m-12,0a12,12 0,1 1,24 0a12,12 0,1 1,-24 0"
android:fillColor="#34A853"/>
<path
android:pathData="M136,88m-24,0a24,24 0,1 1,48 0a24,24 0,1 1,-48 0"
android:fillColor="#EA4335"/>
<path
android:pathData="M136,148m-28,0a28,28 0,1 1,56 0a28,28 0,1 1,-56 0"
android:fillColor="#FBBC05"/>
<path
android:pathData="M56,64m-48,0a48,48 0,1 1,96 0a48,48 0,1 1,-96 0"
android:fillColor="#4285F4"/>
</vector>
...@@ -5,27 +5,50 @@ ...@@ -5,27 +5,50 @@
<ScrollView <ScrollView
xmlns:android="http://schemas.android.com/apk/res/android" xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content"> android:layout_height="wrap_content">
<LinearLayout <LinearLayout
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingTop="12dp" android:paddingTop="18dp"
android:paddingBottom="14dp" android:paddingBottom="14dp"
android:paddingStart="24dp" android:paddingStart="24dp"
android:paddingEnd="24dp" android:paddingEnd="24dp"
android:gravity="center_horizontal" android:gravity="center_horizontal"
android:orientation="vertical"> android:orientation="vertical">
<!-- "Try Google Assistant in Chrome" --> <!-- "Try Google Assistant in Chrome" -->
<LinearLayout
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:orientation="horizontal"
android:gravity="center_horizontal"
android:layout_marginTop="24dp">
<ImageView <ImageView
android:id="@+id/onboarding_try_assistant" android:id="@+id/onboarding_title_poodle"
tools:ignore="contentDescription" tools:ignore="contentDescription"
android:layout_width="185dp" android:layout_width="24dp"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginTop="16dp" android:layout_gravity="center_vertical"
android:src="@drawable/autofill_assistant_onboarding_try" /> app:srcCompat="@drawable/ic_logo_assistant_24dp" />
<TextView
android:id="@+id/onboarding_try_assistant"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:textAppearance="@style/TextAppearance.Headline.Primary"
android:gravity="center"
android:text="@string/autofill_assistant_init_title" />
<!-- This balances the picture on the other side to make the text centered-->
<Space
android:layout_width="24dp"
android:layout_height="1dp"/>
</LinearLayout>
<!-- Subtitle (e.g., 'Google Assistant saves you time...')--> <!-- Subtitle (e.g., 'Google Assistant saves you time...')-->
<LinearLayout <LinearLayout
......
...@@ -169,6 +169,9 @@ ...@@ -169,6 +169,9 @@
<message name="IDS_INIT_OK" desc="Init screen confirmation text."> <message name="IDS_INIT_OK" desc="Init screen confirmation text.">
I agree I agree
</message> </message>
<message name="IDS_AUTOFILL_ASSISTANT_INIT_TITLE" desc="The title of the onboarding screen.">
Try \n Google Assistant \n in Chrome
</message>
<message name="IDS_AUTOFILL_ASSISTANT_INIT_MESSAGE" desc="Onboarding message describing autofill assistant's capability."> <message name="IDS_AUTOFILL_ASSISTANT_INIT_MESSAGE" desc="Onboarding message describing autofill assistant's capability.">
Google Assistant saves you time by helping you complete actions on the web, like search and checkout. Google Assistant saves you time by helping you complete actions on the web, like search and checkout.
</message> </message>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment