Commit 75c08c5f authored by Chris Dalton's avatar Chris Dalton Committed by Commit Bot

Stub out no-op Skia bindings for program binaries

The Skia interface validator requires these bindings to be present.

Bug: skia:8159
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib79d16ac063bdd5ddace9fbf6bba063e190186d3
Reviewed-on: https://chromium-review.googlesource.com/1147878Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Commit-Queue: Chris Dalton <csmartdalton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577775}
parent 142492e4
......@@ -417,6 +417,19 @@ sk_sp<GrGLInterface> CreateGLES2InterfaceBindings(
&GLES2Interface::CoverageModulationCHROMIUM, impl, context_support);
functions->fWindowRectangles =
gles_bind(&GLES2Interface::WindowRectanglesEXT, impl, context_support);
// Skia should not use program binaries over the command buffer. Allowing
// clients to submit them would be unsafe, and we already cache program
// binaries internally anyway.
functions->fGetProgramBinary = [](GLuint, GLsizei, GLsizei*, GLenum*, void*) {
LOG(FATAL) << "Skia shouldn't use program binaries over the command buffer";
};
functions->fProgramBinary = [](GLuint, GLenum, const void*, GLsizei) {
LOG(FATAL) << "Skia shouldn't use program binaries over the command buffer";
};
functions->fProgramParameteri = [](GLuint, GLenum pname, GLint) {
// This method is only used for GL_PROGRAM_BINARY_RETRIEVABLE_HINT in ES3.
LOG(FATAL) << "Skia shouldn't use program binaries over the command buffer";
};
return interface;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment