Commit 75e35dde authored by thakis@chromium.org's avatar thakis@chromium.org

2011-04-05 Nico Weber <thakis@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Don't have 'using namespace' declarations in header files
        https://bugs.webkit.org/show_bug.cgi?id=57882

        * src/EventListenerWrapper.cpp:
        * src/EventListenerWrapper.h:
        * src/VideoFrameChromiumImpl.h:
        * src/WebDOMEventListener.cpp:
        * src/WebDOMEventListenerPrivate.cpp:
        * src/WebDOMEventListenerPrivate.h:
        (WebKit::WebDOMEventListenerPrivate::ListenerInfo::ListenerInfo):

git-svn-id: svn://svn.chromium.org/blink/trunk@82996 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 3d630370
2011-04-05 Nico Weber <thakis@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Don't have 'using namespace' declarations in header files
https://bugs.webkit.org/show_bug.cgi?id=57882
* src/EventListenerWrapper.cpp:
* src/EventListenerWrapper.h:
* src/VideoFrameChromiumImpl.h:
* src/WebDOMEventListener.cpp:
* src/WebDOMEventListenerPrivate.cpp:
* src/WebDOMEventListenerPrivate.h:
(WebKit::WebDOMEventListenerPrivate::ListenerInfo::ListenerInfo):
2011-04-05 Zelidrag Hornung <zelidrag@chromium.org> 2011-04-05 Zelidrag Hornung <zelidrag@chromium.org>
Reviewed by David Levin. Reviewed by David Levin.
......
...@@ -37,6 +37,8 @@ ...@@ -37,6 +37,8 @@
#include "WebDOMEvent.h" #include "WebDOMEvent.h"
#include "WebDOMEventListener.h" #include "WebDOMEventListener.h"
using namespace WebCore;
namespace WebKit { namespace WebKit {
EventListenerWrapper::EventListenerWrapper(WebDOMEventListener* webDOMEventListener) EventListenerWrapper::EventListenerWrapper(WebDOMEventListener* webDOMEventListener)
......
...@@ -37,21 +37,19 @@ namespace WebCore { ...@@ -37,21 +37,19 @@ namespace WebCore {
class ScriptExecutionContext; class ScriptExecutionContext;
} }
using namespace WebCore;
namespace WebKit { namespace WebKit {
class WebDOMEventListener; class WebDOMEventListener;
// FIXME: Remove the DeprecatedEventListenerWrapper class below once Chromium // FIXME: Remove the DeprecatedEventListenerWrapper class below once Chromium
// switched to using WebDOMEvent. // switched to using WebDOMEvent.
class EventListenerWrapper : public EventListener { class EventListenerWrapper : public WebCore::EventListener {
public: public:
EventListenerWrapper(WebDOMEventListener*); EventListenerWrapper(WebDOMEventListener*);
~EventListenerWrapper(); ~EventListenerWrapper();
virtual bool operator==(const EventListener&); virtual bool operator==(const WebCore::EventListener&);
virtual void handleEvent(ScriptExecutionContext*, Event*); virtual void handleEvent(WebCore::ScriptExecutionContext*, WebCore::Event*);
void webDOMEventListenerDeleted(); void webDOMEventListenerDeleted();
......
...@@ -34,16 +34,14 @@ ...@@ -34,16 +34,14 @@
#include "VideoFrameChromium.h" #include "VideoFrameChromium.h"
#include "WebVideoFrame.h" #include "WebVideoFrame.h"
using namespace WebCore;
namespace WebKit { namespace WebKit {
// A wrapper class for WebKit::WebVideoFrame. Objects can be created in WebKit // A wrapper class for WebKit::WebVideoFrame. Objects can be created in WebKit
// and used in WebCore because of the VideoFrameChromium interface. // and used in WebCore because of the VideoFrameChromium interface.
class VideoFrameChromiumImpl : public VideoFrameChromium { class VideoFrameChromiumImpl : public WebCore::VideoFrameChromium {
public: public:
// Converts a WebCore::VideoFrameChromium to a WebKit::WebVideoFrame. // Converts a WebCore::VideoFrameChromium to a WebKit::WebVideoFrame.
static WebVideoFrame* toWebVideoFrame(VideoFrameChromium*); static WebVideoFrame* toWebVideoFrame(WebCore::VideoFrameChromium*);
// Creates a VideoFrameChromiumImpl object to wrap the given WebVideoFrame. // Creates a VideoFrameChromiumImpl object to wrap the given WebVideoFrame.
// The VideoFrameChromiumImpl does not take ownership of the WebVideoFrame // The VideoFrameChromiumImpl does not take ownership of the WebVideoFrame
...@@ -59,7 +57,7 @@ public: ...@@ -59,7 +57,7 @@ public:
virtual int stride(unsigned plane) const; virtual int stride(unsigned plane) const;
virtual const void* data(unsigned plane) const; virtual const void* data(unsigned plane) const;
virtual unsigned texture(unsigned plane) const; virtual unsigned texture(unsigned plane) const;
virtual const IntSize requiredTextureSize(unsigned plane) const; virtual const WebCore::IntSize requiredTextureSize(unsigned plane) const;
virtual bool hasPaddingBytes(unsigned plane) const; virtual bool hasPaddingBytes(unsigned plane) const;
private: private:
......
...@@ -33,6 +33,8 @@ ...@@ -33,6 +33,8 @@
#include "WebDOMEventListenerPrivate.h" #include "WebDOMEventListenerPrivate.h"
using namespace WebCore;
namespace WebKit { namespace WebKit {
WebDOMEventListener::WebDOMEventListener() WebDOMEventListener::WebDOMEventListener()
......
...@@ -34,6 +34,8 @@ ...@@ -34,6 +34,8 @@
#include "EventListenerWrapper.h" #include "EventListenerWrapper.h"
#include "WebDOMEventListener.h" #include "WebDOMEventListener.h"
using namespace WebCore;
namespace WebKit { namespace WebKit {
WebDOMEventListenerPrivate::WebDOMEventListenerPrivate(WebDOMEventListener* webDOMEventListener) WebDOMEventListenerPrivate::WebDOMEventListenerPrivate(WebDOMEventListener* webDOMEventListener)
......
...@@ -39,8 +39,6 @@ namespace WebCore { ...@@ -39,8 +39,6 @@ namespace WebCore {
class Node; class Node;
} }
using namespace WebCore;
namespace WebKit { namespace WebKit {
class EventListenerWrapper; class EventListenerWrapper;
...@@ -52,12 +50,12 @@ public: ...@@ -52,12 +50,12 @@ public:
~WebDOMEventListenerPrivate(); ~WebDOMEventListenerPrivate();
EventListenerWrapper* createEventListenerWrapper( EventListenerWrapper* createEventListenerWrapper(
const WebString& eventType, bool useCapture, Node* node); const WebString& eventType, bool useCapture, WebCore::Node*);
// Gets the ListenerEventWrapper for a specific node. // Gets the ListenerEventWrapper for a specific node.
// Used by WebNode::removeDOMEventListener(). // Used by WebNode::removeDOMEventListener().
EventListenerWrapper* getEventListenerWrapper( EventListenerWrapper* getEventListenerWrapper(
const WebString& eventType, bool useCapture, Node* node); const WebString& eventType, bool useCapture, WebCore::Node*);
// Called by the WebDOMEventListener when it is about to be deleted. // Called by the WebDOMEventListener when it is about to be deleted.
void webDOMEventListenerDeleted(); void webDOMEventListenerDeleted();
...@@ -68,7 +66,7 @@ public: ...@@ -68,7 +66,7 @@ public:
struct ListenerInfo { struct ListenerInfo {
ListenerInfo(const WebString& eventType, bool useCapture, ListenerInfo(const WebString& eventType, bool useCapture,
EventListenerWrapper* eventListenerWrapper, EventListenerWrapper* eventListenerWrapper,
Node* node) WebCore::Node* node)
: eventType(eventType) : eventType(eventType)
, useCapture(useCapture) , useCapture(useCapture)
, eventListenerWrapper(eventListenerWrapper) , eventListenerWrapper(eventListenerWrapper)
...@@ -79,7 +77,7 @@ public: ...@@ -79,7 +77,7 @@ public:
WebString eventType; WebString eventType;
bool useCapture; bool useCapture;
EventListenerWrapper* eventListenerWrapper; EventListenerWrapper* eventListenerWrapper;
Node* node; WebCore::Node* node;
}; };
private: private:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment