Remove noisy "uninteresting calls" logging.

Change-Id: Ifa68ca8083ccb12602ae62f0f1e19e4827bc2afa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392711Reviewed-by: Zach Trudo <zatrudo@google.com>
Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804316}

chrome/browser/policy/messaging_layer/encryption/test_encryption_module.cc

@@ -14,7 +14,7 @@ using ::testing::Invoke;
 namespace reporting {
 namespace test {
 
-TestEncryptionModule::TestEncryptionModule() {
+TestEncryptionModuleStrict::TestEncryptionModuleStrict() {
   ON_CALL(*this, EncryptRecord)
       .WillByDefault(
           Invoke([](base::StringPiece record,
@@ -26,7 +26,7 @@ TestEncryptionModule::TestEncryptionModule() {
           }));
 }
 
-void TestEncryptionModule::UpdateAsymmetricKey(
+void TestEncryptionModuleStrict::UpdateAsymmetricKey(
     base::StringPiece new_key,
     base::OnceCallback<void(Status)> response_cb) {
   std::move(response_cb)
@@ -34,7 +34,7 @@ void TestEncryptionModule::UpdateAsymmetricKey(
                   "Test Encryption Module does not accept any keys"));
 }
 
-TestEncryptionModule::~TestEncryptionModule() = default;
+TestEncryptionModuleStrict::~TestEncryptionModuleStrict() = default;
 
 }  // namespace test
 }  // namespace reporting

chrome/browser/policy/messaging_layer/encryption/test_encryption_module.h

@@ -17,9 +17,9 @@ namespace reporting {
 namespace test {
 
 // An |EncryptionModule| that does no encryption.
-class TestEncryptionModule : public EncryptionModule {
+class TestEncryptionModuleStrict : public EncryptionModule {
  public:
-  TestEncryptionModule();
+  TestEncryptionModuleStrict();
 
   MOCK_METHOD(void,
               EncryptRecord,
@@ -32,9 +32,12 @@ class TestEncryptionModule : public EncryptionModule {
       base::OnceCallback<void(Status)> response_cb) override;
 
  protected:
-  ~TestEncryptionModule() override;
+  ~TestEncryptionModuleStrict() override;
 };
 
+// Most of the time no need to log uninterested calls to |EncryptRecord|.
+typedef ::testing::NiceMock<TestEncryptionModuleStrict> TestEncryptionModule;
+
 }  // namespace test
 }  // namespace reporting
 

chrome/browser/policy/messaging_layer/storage/test_storage_module.cc

@@ -18,24 +18,24 @@ using ::testing::Invoke;
 namespace reporting {
 namespace test {
 
-TestStorageModule::TestStorageModule() {
+TestStorageModuleStrict::TestStorageModuleStrict() {
   ON_CALL(*this, AddRecord)
       .WillByDefault(Invoke(this, &TestStorageModule::AddRecordSuccessfully));
 }
 
-TestStorageModule::~TestStorageModule() = default;
+TestStorageModuleStrict::~TestStorageModuleStrict() = default;
 
-Record TestStorageModule::record() const {
+Record TestStorageModuleStrict::record() const {
   EXPECT_TRUE(record_.has_value());
   return record_.value();
 }
 
-Priority TestStorageModule::priority() const {
+Priority TestStorageModuleStrict::priority() const {
   EXPECT_TRUE(priority_.has_value());
   return priority_.value();
 }
 
-void TestStorageModule::AddRecordSuccessfully(
+void TestStorageModuleStrict::AddRecordSuccessfully(
     Priority priority,
     Record record,
     base::OnceCallback<void(Status)> callback) {

chrome/browser/policy/messaging_layer/storage/test_storage_module.h

@@ -18,11 +18,11 @@
 namespace reporting {
 namespace test {
 
-class TestStorageModule : public StorageModule {
+class TestStorageModuleStrict : public StorageModule {
  public:
   // As opposed to the production |StorageModule|, test module does not need to
   // call factory method - it is created directly by constructor.
-  TestStorageModule();
+  TestStorageModuleStrict();
 
   MOCK_METHOD(void,
               AddRecord,
@@ -35,7 +35,7 @@ class TestStorageModule : public StorageModule {
   Priority priority() const;
 
  protected:
-  ~TestStorageModule() override;
+  ~TestStorageModuleStrict() override;
 
  private:
   void AddRecordSuccessfully(Priority priority,
@@ -46,6 +46,9 @@ class TestStorageModule : public StorageModule {
   base::Optional<Priority> priority_;
 };
 
+// Most of the time no need to log uninterested calls to |AddRecord|.
+typedef ::testing::NiceMock<TestStorageModuleStrict> TestStorageModule;
+
 }  // namespace test
 }  // namespace reporting