Enable "gn check" for //third_party/blink/renderer/core

Bug: 800764
Change-Id: I54f490a37baee7f8e98198fa28794aa216f9f33c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469563Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818849}

.gn

@@ -198,7 +198,6 @@ no_check_targets = [
   "//third_party/blink/renderer/core/exported:*",  # 470 errors
   "//third_party/blink/renderer/core/probe:*",  # 9 errors
   "//third_party/blink/renderer/core/typed_arrays:*",  # 24 errors
-  "//third_party/blink/renderer/core:*",  # 823 errors
 
   "//third_party/breakpad:*",  # 34 errors
   "//third_party/ced/*",

third_party/blink/renderer/bindings/core/v8/script_streamer.cc

@@ -16,7 +16,6 @@
 #include "third_party/blink/renderer/core/dom/document.h"
 #include "third_party/blink/renderer/core/dom/element.h"
 #include "third_party/blink/renderer/core/frame/settings.h"
-#include "third_party/blink/renderer/core/html/parser/text_resource_decoder.h"
 #include "third_party/blink/renderer/core/inspector/inspector_trace_events.h"
 #include "third_party/blink/renderer/core/loader/resource/script_resource.h"
 #include "third_party/blink/renderer/platform/bindings/v8_per_isolate_data.h"

third_party/blink/renderer/core/BUILD.gn

@@ -270,6 +270,7 @@ component("core") {
     "//skia",
     "//skia:skcms",
     "//third_party/blink/public:buildflags",
+    "//third_party/blink/public:image_resources_grit",
     "//third_party/blink/public:resources",
     "//third_party/blink/public/common",
     "//third_party/blink/public/strings",
@@ -293,8 +294,11 @@ component("core") {
     deps += [ "//printing" ]
   }
 
-  allow_circular_includes_from =
-      [ "//third_party/blink/renderer/core/xml:xpath_generated" ]
+  allow_circular_includes_from = [
+    ":core_generated",
+    ":core_hot",
+    "//third_party/blink/renderer/core/xml:xpath_generated",
+  ]
 
   public_configs = [ ":core_include_dirs" ]
 
@@ -321,6 +325,11 @@ blink_core_sources("core_hot") {
     configs -= [ "//build/config/compiler:default_optimization" ]
     configs += [ "//build/config/compiler:optimize_max" ]
   }
+
+  deps = [
+    "//services/metrics/public/cpp:ukm_builders",
+    "//third_party/blink/renderer/core/probe:probe",
+  ]
 }
 
 source_set("testing") {
@@ -336,6 +345,7 @@ source_set("testing") {
     ":core",
     ":generated_testing_idls",
     "//third_party/blink/renderer/bindings/core/v8:testing",
+    "//third_party/blink/renderer/platform:test_support",
     "//ui/base/cursor:cursor_base",
     "//ui/base/cursor/mojom:cursor_type_blink",
   ]
@@ -1067,7 +1077,11 @@ target(core_generated_target_type, "core_generated") {
   foreach(current, targets_generating_sources) {
     sources += get_target_outputs(current)
   }
-  deps = []
+  deps = [
+    "//services/metrics/public/cpp:ukm_builders",
+    "//third_party/blink/renderer/core/exported:exported",
+    "//third_party/blink/renderer/core/probe:probe",
+  ]
   public_deps = [ ":all_generators" ]
 
   configs -= core_config_remove
@@ -1508,6 +1522,7 @@ source_set("unit_tests") {
     "script/module_script_test.cc",
     "script/script_runner_test.cc",
     "scroll/scrollable_area_test.cc",
+    "scroll/scrollbar_test_suite.h",
     "scroll/scrollbar_theme_overlay_test.cc",
     "streams/miscellaneous_operations_test.cc",
     "streams/queue_with_sizes_test.cc",
@@ -1578,17 +1593,23 @@ source_set("unit_tests") {
     ":core",
     ":unit_test_support",
     "//components/paint_preview/common:common",
+    "//components/ukm:test_support",
     "//mojo/public/cpp/system",
+    "//mojo/public/cpp/test_support:test_utils",
+    "//services/metrics/public/cpp:ukm_builders",
     "//services/network/trust_tokens:test_support",
     "//skia",
     "//skia:skcms",
     "//testing/gmock",
     "//testing/gtest",
+    "//third_party/blink/public:buildflags",
+    "//third_party/blink/public:test_headers",
     "//third_party/blink/renderer/controller:blink_bindings_test_sources",
     "//third_party/blink/renderer/core",
     "//third_party/blink/renderer/core:testing",
     "//third_party/blink/renderer/core:unit_test_support",
     "//third_party/blink/renderer/platform:test_support",
+    "//third_party/blink/renderer/platform:unit_tests",
     "//ui/accessibility:ax_base",
     "//ui/base/cursor:cursor_base",
     "//ui/base/cursor/mojom:cursor_type_blink",
@@ -1654,6 +1675,7 @@ source_set("perf_tests") {
     "//mojo/public/cpp/system",
     "//testing/gmock",
     "//testing/gtest",
+    "//third_party/blink/renderer/platform:test_support",
   ]
 }
 
@@ -1698,8 +1720,11 @@ source_set("unit_test_support") {
 
   deps = [
     ":core",
+    "//content/test:test_support",
     "//testing/gmock",
     "//testing/gtest",
+    "//third_party/blink/renderer/core:testing",
+    "//third_party/blink/renderer/platform:test_support",
   ]
 }
 
@@ -1744,6 +1769,7 @@ fuzzer_test("content_security_policy_fuzzer") {
   sources = [ "frame/csp/content_security_policy_fuzzer.cc" ]
   deps = [
     ":core",
+    "//third_party/blink/renderer/core:testing",
     "//third_party/blink/renderer/platform:blink_fuzzer_test_support",
   ]
   dict = "//testing/libfuzzer/fuzzers/dicts/content_security_policy.dict"
@@ -1781,6 +1807,7 @@ fuzzer_test("blink_html_tokenizer_fuzzer") {
 fuzzer_test("feature_policy_fuzzer") {
   sources = [ "feature_policy/feature_policy_fuzzer.cc" ]
   deps = [
+    "//third_party/blink/renderer/core",
     "//third_party/blink/renderer/platform:blink_fuzzer_test_support",
     "//third_party/icu",
   ]
@@ -1792,6 +1819,7 @@ fuzzer_test("feature_policy_fuzzer") {
 fuzzer_test("feature_policy_attr_fuzzer") {
   sources = [ "feature_policy/feature_policy_attr_fuzzer.cc" ]
   deps = [
+    "//third_party/blink/renderer/core",
     "//third_party/blink/renderer/platform:blink_fuzzer_test_support",
     "//third_party/icu",
   ]
@@ -1803,6 +1831,7 @@ fuzzer_test("feature_policy_attr_fuzzer") {
 fuzzer_test("document_policy_fuzzer") {
   sources = [ "feature_policy/document_policy_fuzzer.cc" ]
   deps = [
+    "//third_party/blink/renderer/core",
     "//third_party/blink/renderer/platform:blink_fuzzer_test_support",
     "//third_party/icu",
   ]
@@ -1814,6 +1843,7 @@ fuzzer_test("document_policy_fuzzer") {
 fuzzer_test("permissions_policy_fuzzer") {
   sources = [ "feature_policy/permissions_policy_fuzzer.cc" ]
   deps = [
+    "//third_party/blink/renderer/core",
     "//third_party/blink/renderer/platform:blink_fuzzer_test_support",
     "//third_party/icu",
   ]

third_party/blink/renderer/core/dom/document.cc

@@ -44,7 +44,6 @@
 #include "base/time/time.h"
 #include "cc/input/overscroll_behavior.h"
 #include "cc/input/scroll_snap_data.h"
-#include "components/performance_manager/public/mojom/coordination_unit.mojom-blink.h"
 #include "mojo/public/cpp/bindings/pending_remote.h"
 #include "mojo/public/cpp/bindings/remote.h"
 #include "mojo/public/mojom/base/text_direction.mojom-blink.h"

third_party/blink/renderer/core/layout/build.gni

@@ -704,7 +704,6 @@ blink_core_sources_layout = [
   "text_decoration_offset_base.h",
   "text_run_constructor.cc",
   "text_run_constructor.h",
-  "theme_types.h",
   "traced_layout_object.cc",
   "traced_layout_object.h",
   "vertical_position_cache.h",

third_party/blink/renderer/core/scroll/build.gni

@@ -24,7 +24,6 @@ blink_core_sources_scroll = [
   "scrollbar.h",
   "scrollbar_layer_delegate.cc",
   "scrollbar_layer_delegate.h",
-  "scrollbar_test_suite.h",
   "scrollbar_theme.cc",
   "scrollbar_theme.h",
   "scrollbar_theme_overlay.cc",

third_party/blink/renderer/core/streams/build.gni

@@ -33,7 +33,6 @@ blink_core_sources_streams = [
   "transform_stream.h",
   "transform_stream_default_controller.cc",
   "transform_stream_default_controller.h",
-  "transform_stream_default_controller_interface.h",
   "transform_stream_transformer.h",
   "underlying_sink_base.h",
   "underlying_source_base.cc",

third_party/blink/renderer/core/typed_arrays/BUILD.gn

@@ -26,4 +26,9 @@ blink_core_sources("typed_arrays") {
     "flexible_array_buffer_view.h",
     "typed_flexible_array_buffer_view.h",
   ]
+
+  deps = [ "//third_party/blink/renderer/core:core_generated" ]
+
+  allow_circular_includes_from =
+      [ "//third_party/blink/renderer/core:core_generated" ]
 }