Commit 78180291 authored by Tim van der Lippe's avatar Tim van der Lippe Committed by Commit Bot

Migrate browser_sdk/ to ESM

Bug: 1006759
Change-Id: I2aa0c1df1f4d2ae12c328782d2aa4de63c57161a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845716
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: default avatarPaul Lewis <aerotwist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704214}
parent 8079a023
......@@ -77,7 +77,6 @@ if (!external_devtools_frontend) {
"front_end/browser_debugger/eventListenerBreakpoints.css",
"front_end/browser_debugger/module.json",
"front_end/browser_debugger/xhrBreakpointsSidebarPane.css",
"front_end/browser_sdk/LogManager.js",
"front_end/browser_sdk/module.json",
"front_end/css_overview/cssOverview.css",
"front_end/css_overview/cssOverviewStartView.css",
......@@ -821,6 +820,8 @@ if (!external_devtools_frontend) {
all_devtools_files += lighthouse_locale_files
all_devtools_modules = [
"front_end/browser_sdk/browser_sdk.js",
"front_end/browser_sdk/LogManager.js",
"front_end/persistence/persistence.js",
"front_end/persistence/WorkspaceSettingsTab.js",
"front_end/persistence/PlatformFileSystem.js",
......@@ -1209,6 +1210,8 @@ if (!external_devtools_frontend) {
]
copied_devtools_modules = [
"$resources_out_dir/browser_sdk/browser_sdk.js",
"$resources_out_dir/browser_sdk/LogManager.js",
"$resources_out_dir/persistence/persistence.js",
"$resources_out_dir/persistence/WorkspaceSettingsTab.js",
"$resources_out_dir/persistence/PlatformFileSystem.js",
......
......@@ -5,7 +5,7 @@
/**
* @implements {SDK.SDKModelObserver<!SDK.LogModel>}
*/
BrowserSDK.LogManager = class {
export default class LogManager {
constructor() {
SDK.targetManager.observeModels(SDK.LogModel, this);
}
......@@ -17,7 +17,7 @@ BrowserSDK.LogManager = class {
modelAdded(logModel) {
const eventListeners = [];
eventListeners.push(logModel.addEventListener(SDK.LogModel.Events.EntryAdded, this._logEntryAdded, this));
logModel[BrowserSDK.LogManager._eventSymbol] = eventListeners;
logModel[_eventSymbol] = eventListeners;
}
/**
......@@ -25,7 +25,7 @@ BrowserSDK.LogManager = class {
* @param {!SDK.LogModel} logModel
*/
modelRemoved(logModel) {
Common.EventTarget.removeEventListeners(logModel[BrowserSDK.LogManager._eventSymbol]);
Common.EventTarget.removeEventListeners(logModel[_eventSymbol]);
}
/**
......@@ -62,8 +62,20 @@ BrowserSDK.LogManager = class {
SDK.consoleModel.addMessage(consoleMessage);
}
}
};
}
BrowserSDK.LogManager._eventSymbol = Symbol('_events');
export const _eventSymbol = Symbol('_events');
new BrowserSDK.LogManager();
/* Legacy exported object */
self.BrowserSDK = self.BrowserSDK || {};
/* Legacy exported object */
BrowserSDK = BrowserSDK || {};
/** @constructor */
BrowserSDK.LogManager = LogManager;
BrowserSDK.LogManager._eventSymbol = _eventSymbol;
// TODO(crbug.com/1006759): Move out of this module
new LogManager();
\ No newline at end of file
// Copyright 2019 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import * as LogManager from './LogManager.js';
export {
LogManager,
};
......@@ -20,7 +20,9 @@
]
}
],
"scripts": [
"scripts": [],
"modules": [
"browser_sdk.js",
"LogManager.js"
],
"dependencies": [
......
......@@ -16,3 +16,4 @@ import './workspace/workspace.js';
import './bindings/bindings.js';
import './components/components.js';
import './persistence/persistence.js';
import './browser_sdk/browser_sdk.js';
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment