Commit 787bd0b8 authored by Maggie Chen's avatar Maggie Chen Committed by Commit Bot

Set Windows GPU watchdog timeout based on the number of CPU cores

This was enabled by finch. Now enable it by default.

Bug: 949839
Change-Id: Ib0f417bacde686d43193a58c1b3a9b0cc0c6b999
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506570Reviewed-by: default avatarZhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822225}
parent 2540e4a2
...@@ -138,16 +138,16 @@ std::unique_ptr<GpuWatchdogThread> GpuWatchdogThread::Create( ...@@ -138,16 +138,16 @@ std::unique_ptr<GpuWatchdogThread> GpuWatchdogThread::Create(
int restart_factor = kRestartFactor; int restart_factor = kRestartFactor;
int max_extra_cycles_before_kill = kMaxExtraCyclesBeforeKill; int max_extra_cycles_before_kill = kMaxExtraCyclesBeforeKill;
#if defined(OS_WIN)
gpu_watchdog_timeout = GetGpuWatchdogTimeoutBasedOnCpuCores();
#endif
if (base::FeatureList::IsEnabled(features::kGpuWatchdogV2NewTimeout)) { if (base::FeatureList::IsEnabled(features::kGpuWatchdogV2NewTimeout)) {
const char kNewTimeOutParam[] = "new_time_out"; const char kNewTimeOutParam[] = "new_time_out";
const char kMaxExtraCyclesBeforeKillParam[] = const char kMaxExtraCyclesBeforeKillParam[] =
"max_extra_cycles_before_kill"; "max_extra_cycles_before_kill";
#if defined(OS_WIN) #if defined(OS_WIN)
// The purpose of finch on Windows is to know the impact of the number of
// CPU cores while the rest of platforms are to try a different watchdog
// timeout length.
gpu_watchdog_timeout = GetGpuWatchdogTimeoutBasedOnCpuCores();
constexpr int kFinchMaxExtraCyclesBeforeKill = 0; constexpr int kFinchMaxExtraCyclesBeforeKill = 0;
#elif defined(OS_ANDROID) #elif defined(OS_ANDROID)
constexpr int kFinchMaxExtraCyclesBeforeKill = 0; constexpr int kFinchMaxExtraCyclesBeforeKill = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment