Skip to content

GitLab

T
tangled
Commit 79e212da authored by Reilly Grant's avatar Reilly Grant Committed by Commit Bot
Browse files
Options

Remove @VisibleForTesting from WebsitePreferenceBridge.java 

This annotation is incorrect as the JNI bindings defined in this class
are used from other classes and not just tests.

Bug: 1107950
Change-Id: I07f33b11f8718d6fba1a3039b4bde85e31fc7451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360593
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: default avatarAndy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799049}
parent 7803f009
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 355 deletions
chrome/android/expectations/lint-baseline.xml
View file @ 79e212da
...@@ -478,17 +478,6 @@ ...@@ -478,17 +478,6 @@
column="30"/> column="30"/>
</issue> </issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" || !WebsitePreferenceBridgeJni.get().isContentSettingsPatternValid("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/AddExceptionPreference.java"
line="187"
column="70"/>
</issue>
<issue <issue
id="VisibleForTests" id="VisibleForTests"
message="This method should only be accessed from tests or within private scope" message="This method should only be accessed from tests or within private scope"
...@@ -2865,17 +2854,6 @@ ...@@ -2865,17 +2854,6 @@
column="18"/> column="18"/>
</issue> </issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().revokeObjectPermission("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/ChosenObjectInfo.java"
line="84"
column="46"/>
</issue>
<issue <issue
id="VisibleForTests" id="VisibleForTests"
message="This method should only be accessed from tests or within private scope" message="This method should only be accessed from tests or within private scope"
...@@ -3503,28 +3481,6 @@ ...@@ -3503,28 +3481,6 @@
column="20"/> column="20"/>
</issue> </issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().clearCookieData(browserContextHandle, mOrigin);"
errorLine2=" ~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/LocalStorageInfo.java"
line="36"
column="42"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().clearLocalStorageData("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/LocalStorageInfo.java"
line="37"
column="42"/>
</issue>
<issue <issue
id="VisibleForTests" id="VisibleForTests"
message="This method should only be accessed from tests or within private scope" message="This method should only be accessed from tests or within private scope"
...@@ -3734,248 +3690,6 @@ ...@@ -3734,248 +3690,6 @@
column="39"/> column="39"/>
</issue> </issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" return WebsitePreferenceBridgeJni.get().getArSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="97"
column="57"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" return WebsitePreferenceBridgeJni.get().getCameraSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="100"
column="57"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" return WebsitePreferenceBridgeJni.get().getClipboardSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="103"
column="57"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" return WebsitePreferenceBridgeJni.get().getGeolocationSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="106"
column="57"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" return WebsitePreferenceBridgeJni.get().getMicrophoneSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="109"
column="57"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" return WebsitePreferenceBridgeJni.get().getMidiSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="112"
column="57"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" return WebsitePreferenceBridgeJni.get().getNfcSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="115"
column="57"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" return WebsitePreferenceBridgeJni.get().getNotificationSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="118"
column="57"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" return WebsitePreferenceBridgeJni.get().getProtectedMediaIdentifierSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="121"
column="57"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" return WebsitePreferenceBridgeJni.get().getSensorsSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="124"
column="57"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" return WebsitePreferenceBridgeJni.get().getVrSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="127"
column="57"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().setArSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="142"
column="50"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().setCameraSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="146"
column="50"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().setClipboardSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="150"
column="50"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().setGeolocationSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="154"
column="50"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().setMicrophoneSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="158"
column="50"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().setMidiSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="162"
column="50"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().setNfcSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="166"
column="50"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().setNotificationSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="170"
column="50"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().setProtectedMediaIdentifierSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="174"
column="50"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().setSensorsSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="178"
column="50"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().setVrSettingForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/PermissionInfo.java"
line="182"
column="50"/>
</issue>
<issue <issue
id="VisibleForTests" id="VisibleForTests"
message="This method should only be accessed from tests or within private scope" message="This method should only be accessed from tests or within private scope"
...@@ -4108,50 +3822,6 @@ ...@@ -4108,50 +3822,6 @@
column="48"/> column="48"/>
</issue> </issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().reportNotificationRevokedForOrigin("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/SingleWebsiteSettings.java"
line="646"
column="50"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().clearCookieData(browserContextHandle, origin);"
errorLine2=" ~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/SiteDataCleaner.java"
line="22"
column="42"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().clearBannerData(browserContextHandle, origin);"
errorLine2=" ~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/SiteDataCleaner.java"
line="23"
column="42"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().clearMediaLicenses(browserContextHandle, origin);"
errorLine2=" ~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/SiteDataCleaner.java"
line="24"
column="42"/>
</issue>
<issue <issue
id="VisibleForTests" id="VisibleForTests"
message="This method should only be accessed from tests or within private scope" message="This method should only be accessed from tests or within private scope"
...@@ -4185,17 +3855,6 @@ ...@@ -4185,17 +3855,6 @@
column="26"/> column="26"/>
</issue> </issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" WebsitePreferenceBridgeJni.get().clearStorageData("
errorLine2=" ~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/StorageInfo.java"
line="35"
column="42"/>
</issue>
<issue <issue
id="VisibleForTests" id="VisibleForTests"
message="This method should only be accessed from tests or within private scope" message="This method should only be accessed from tests or within private scope"
...@@ -5076,17 +4735,6 @@ ...@@ -5076,17 +4735,6 @@
column="59"/> column="59"/>
</issue> </issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" return WebsitePreferenceBridgeJni.get().urlMatchesContentSettingsPattern("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/WebsiteAddress.java"
line="108"
column="49"/>
</issue>
<issue <issue
id="VisibleForTests" id="VisibleForTests"
message="This method should only be accessed from tests or within private scope" message="This method should only be accessed from tests or within private scope"
......
components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/WebsitePreferenceBridge.java
View file @ 79e212da
...@@ -4,8 +4,6 @@ ...@@ -4,8 +4,6 @@
package org.chromium.components.browser_ui.site_settings; package org.chromium.components.browser_ui.site_settings;
import androidx.annotation.VisibleForTesting;
import org.chromium.base.Callback; import org.chromium.base.Callback;
import org.chromium.base.annotations.CalledByNative; import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.NativeMethods; import org.chromium.base.annotations.NativeMethods;
...@@ -596,7 +594,6 @@ public class WebsitePreferenceBridge { ...@@ -596,7 +594,6 @@ public class WebsitePreferenceBridge {
contentSettingType, primaryPattern, secondaryPattern, setting); contentSettingType, primaryPattern, secondaryPattern, setting);
} }
@VisibleForTesting
@NativeMethods @NativeMethods
public interface Natives { public interface Natives {
void getArOrigins(BrowserContextHandle browserContextHandle, Object list); void getArOrigins(BrowserContextHandle browserContextHandle, Object list);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment