Commit 7a05a8f5 authored by Ben Pastene's avatar Ben Pastene Committed by Commit Bot

Add symbol_level=2 to CrOS thin-lto bots.

In crbug.com/1129937, we saw build-time regressions during chrome-uprevs
that were believed to only show up when symbol_level=2.

Now that crbug.com/1129937 is resolved, this adds full symbols to a
couple of chrome's Simple Chrome bots which may help catch any similar
regressions in the future.

Bug: 1129937
Change-Id: I0f37f642f7cb8a6a6a082a3b2cf83a2032620058
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488701
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: default avatarGarrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826821}
parent c6f73ba7
...@@ -12,6 +12,9 @@ ...@@ -12,6 +12,9 @@
], ],
"gtest_tests": [ "gtest_tests": [
{ {
"args": [
"--strip-chrome"
],
"merge": { "merge": {
"args": [], "args": [],
"script": "//testing/merge_scripts/standard_gtest_merge.py" "script": "//testing/merge_scripts/standard_gtest_merge.py"
......
...@@ -670,6 +670,16 @@ ...@@ -670,6 +670,16 @@
'mac-archive-rel', 'mac-archive-rel',
], ],
}, },
'chrome_all_tast_tests': {
'modifications': {
'chromeos-betty-pi-arc-cfi-thin-lto-chrome': {
'args': [
# This bot sets symbol_level=2, which doesn't fit inside a normal VM.
'--strip-chrome',
],
},
},
},
'chrome_java_test_pagecontroller_tests': { 'chrome_java_test_pagecontroller_tests': {
'modifications': { 'modifications': {
'android-pie-arm64-rel': { 'android-pie-arm64-rel': {
......
...@@ -1591,7 +1591,7 @@ ...@@ -1591,7 +1591,7 @@
], ],
'chromeos_arm-generic_cfi_thin_lto_official': [ 'chromeos_arm-generic_cfi_thin_lto_official': [
'chromeos_device', 'arm-generic', 'cfi_full', 'thin_lto', 'official', 'chromeos_device', 'arm-generic', 'cfi_full', 'thin_lto', 'official', 'full_symbols',
], ],
'chromeos_arm-generic_dcheck_always_on': [ 'chromeos_arm-generic_dcheck_always_on': [
...@@ -1607,7 +1607,7 @@ ...@@ -1607,7 +1607,7 @@
], ],
'chromeos_betty-pi-arc_cfi_thin_lto_official': [ 'chromeos_betty-pi-arc_cfi_thin_lto_official': [
'chromeos_device', 'betty-pi-arc', 'cfi_full', 'thin_lto', 'official', 'chromeos_device', 'betty-pi-arc', 'cfi_full', 'thin_lto', 'official', 'full_symbols',
], ],
'chromeos_betty-arc-r_include_unwind_tables_official_use_fake_dbus_clients': [ 'chromeos_betty-arc-r_include_unwind_tables_official_use_fake_dbus_clients': [
......
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
"is_chromeos_device": true, "is_chromeos_device": true,
"is_official_build": true, "is_official_build": true,
"ozone_platform_headless": true, "ozone_platform_headless": true,
"symbol_level": 2,
"use_cfi_cast": true, "use_cfi_cast": true,
"use_goma": true, "use_goma": true,
"use_thin_lto": true "use_thin_lto": true
...@@ -20,6 +21,7 @@ ...@@ -20,6 +21,7 @@
"is_chromeos_device": true, "is_chromeos_device": true,
"is_official_build": true, "is_official_build": true,
"ozone_platform_headless": true, "ozone_platform_headless": true,
"symbol_level": 2,
"use_cfi_cast": true, "use_cfi_cast": true,
"use_goma": true, "use_goma": true,
"use_thin_lto": true "use_thin_lto": true
......
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
"is_chromeos_device": true, "is_chromeos_device": true,
"is_official_build": true, "is_official_build": true,
"ozone_platform_headless": true, "ozone_platform_headless": true,
"symbol_level": 2,
"use_cfi_cast": true, "use_cfi_cast": true,
"use_goma": true, "use_goma": true,
"use_thin_lto": true "use_thin_lto": true
...@@ -32,6 +33,7 @@ ...@@ -32,6 +33,7 @@
"is_chromeos_device": true, "is_chromeos_device": true,
"is_official_build": true, "is_official_build": true,
"ozone_platform_headless": true, "ozone_platform_headless": true,
"symbol_level": 2,
"use_cfi_cast": true, "use_cfi_cast": true,
"use_goma": true, "use_goma": true,
"use_thin_lto": true "use_thin_lto": true
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment