DevTools: implement Target.getBrowserContexts() method

This patch implements Target.getBrowserContexts() method that
returns all the contexts created with Target.createBrowserContext()
calls.

R=dgozman, alexclarke, caseq

BUG: 836272
Change-Id: Ib39f947c5591ddb2d6158d8417bc1c8b82561d15
Reviewed-on: https://chromium-review.googlesource.com/1049266
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556977}

chrome/browser/devtools/inspector_protocol_config.json

@@ -18,7 +18,7 @@
             },
             {
                 "domain": "Target",
-                "include": [ "setRemoteLocations", "createBrowserContext", "createTarget", "disposeBrowserContext" ],
+                "include": [ "setRemoteLocations", "createBrowserContext", "getBrowserContexts", "createTarget", "disposeBrowserContext" ],
                 "async": ["disposeBrowserContext"],
                 "include_events": []
             },

chrome/browser/devtools/protocol/target_handler.cc

@@ -17,6 +17,8 @@ class DevToolsBrowserContextManager : public BrowserListObserver {
  public:
   DevToolsBrowserContextManager();
   protocol::Response CreateBrowserContext(std::string* out_context_id);
+  protocol::Response GetBrowserContexts(
+      std::unique_ptr<protocol::Array<protocol::String>>* browser_context_ids);
   Profile* GetBrowserContext(const std::string& context_id);
   void DisposeBrowserContext(
       const std::string& context_id,
@@ -64,6 +66,16 @@ protocol::Response DevToolsBrowserContextManager::CreateBrowserContext(
   return protocol::Response::OK();
 }
 
+protocol::Response DevToolsBrowserContextManager::GetBrowserContexts(
+    std::unique_ptr<protocol::Array<protocol::String>>* browser_context_ids) {
+  *browser_context_ids = std::make_unique<protocol::Array<protocol::String>>();
+  for (const auto& registration_pair : registrations_) {
+    (*browser_context_ids)
+        ->addItem(registration_pair.second->profile()->UniqueId());
+  }
+  return protocol::Response::OK();
+}
+
 void DevToolsBrowserContextManager::DisposeBrowserContext(
     const std::string& context_id,
     std::unique_ptr<TargetHandler::DisposeBrowserContextCallback> callback) {
@@ -206,6 +218,12 @@ protocol::Response TargetHandler::CreateBrowserContext(
       out_context_id);
 }
 
+protocol::Response TargetHandler::GetBrowserContexts(
+    std::unique_ptr<protocol::Array<protocol::String>>* browser_context_ids) {
+  return g_devtools_browser_context_manager.Get().GetBrowserContexts(
+      browser_context_ids);
+}
+
 void TargetHandler::DisposeBrowserContext(
     const std::string& context_id,
     std::unique_ptr<DisposeBrowserContextCallback> callback) {

chrome/browser/devtools/protocol/target_handler.h

@@ -36,6 +36,9 @@ class TargetHandler : public protocol::Target::Backend {
       protocol::Maybe<std::string> browser_context_id,
       protocol::Maybe<bool> enable_begin_frame_control,
       std::string* out_target_id) override;
+  protocol::Response GetBrowserContexts(
+      std::unique_ptr<protocol::Array<protocol::String>>* browser_context_ids)
+      override;
   void DisposeBrowserContext(
       const std::string& context_id,
       std::unique_ptr<DisposeBrowserContextCallback> callback) override;

content/browser/devtools/protocol/target_handler.cc

@@ -396,6 +396,11 @@ Response TargetHandler::DisposeBrowserContext(const std::string& context_id) {
   return Response::Error("Not supported");
 }
 
+Response TargetHandler::GetBrowserContexts(
+    std::unique_ptr<protocol::Array<String>>* browser_context_ids) {
+  return Response::Error("Not supported");
+}
+
 Response TargetHandler::CreateTarget(const std::string& url,
                                      Maybe<int> width,
                                      Maybe<int> height,

content/browser/devtools/protocol/target_handler.h

@@ -64,6 +64,8 @@ class TargetHandler : public DevToolsDomainHandler,
                        bool* out_success) override;
   Response CreateBrowserContext(std::string* out_context_id) override;
   Response DisposeBrowserContext(const std::string& context_id) override;
+  Response GetBrowserContexts(
+      std::unique_ptr<protocol::Array<String>>* browser_context_ids) override;
   Response CreateTarget(const std::string& url,
                         Maybe<int> width,
                         Maybe<int> height,

headless/lib/browser/protocol/target_handler.cc

@@ -101,5 +101,15 @@ Response TargetHandler::DisposeBrowserContext(const std::string& context_id) {
   return Response::OK();
 }
 
+Response TargetHandler::GetBrowserContexts(
+    std::unique_ptr<protocol::Array<protocol::String>>* browser_context_ids) {
+  *browser_context_ids = std::make_unique<protocol::Array<protocol::String>>();
+  for (auto* context : browser()->GetAllBrowserContexts()) {
+    if (context != browser()->GetDefaultBrowserContext())
+      (*browser_context_ids)->addItem(context->Id());
+  }
+  return Response::OK();
+}
+
 }  // namespace protocol
 }  // namespace headless

headless/lib/browser/protocol/target_handler.h

@@ -29,6 +29,9 @@ class TargetHandler : public DomainHandler, public Target::Backend {
                        bool* out_success) override;
   Response CreateBrowserContext(std::string* out_context_id) override;
   Response DisposeBrowserContext(const std::string& context_id) override;
+  Response GetBrowserContexts(
+      std::unique_ptr<protocol::Array<protocol::String>>* browser_context_ids)
+      override;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TargetHandler);

headless/lib/headless_devtools_client_browsertest.cc

@@ -642,6 +642,21 @@ class TargetDomainCreateTwoContexts : public HeadlessAsyncDevTooledBrowserTest,
     if (context_id_one_.empty() || context_id_two_.empty())
       return;
 
+    devtools_client_->GetTarget()->GetExperimental()->GetBrowserContexts(
+        target::GetBrowserContextsParams::Builder().Build(),
+        base::BindOnce(&TargetDomainCreateTwoContexts::OnGetBrowserContexts,
+                       base::Unretained(this)));
+  }
+
+  void OnGetBrowserContexts(
+      std::unique_ptr<target::GetBrowserContextsResult> result) {
+    const std::vector<std::string>* contexts = result->GetBrowserContextIds();
+    EXPECT_EQ(2u, contexts->size());
+    EXPECT_TRUE(std::find(contexts->begin(), contexts->end(),
+                          context_id_one_) != contexts->end());
+    EXPECT_TRUE(std::find(contexts->begin(), contexts->end(),
+                          context_id_two_) != contexts->end());
+
     devtools_client_->GetTarget()->GetExperimental()->CreateTarget(
         target::CreateTargetParams::Builder()
             .SetUrl("about://blank")

headless/protocol_config.json

@@ -12,7 +12,7 @@
         "options": [
             {
                 "domain": "Target",
-                "include": ["createTarget", "closeTarget", "createBrowserContext", "disposeBrowserContext"],
+                "include": ["createTarget", "closeTarget", "getBrowserContexts", "createBrowserContext", "disposeBrowserContext"],
                 "include_events": []
             },
             {

third_party/blink/renderer/core/inspector/browser_protocol.pdl

@@ -5528,6 +5528,12 @@ domain Target
       # The id of the context created.
       BrowserContextID browserContextId
 
+  # Returns all browser contexts created with `Target.createBrowserContext` method.
+  experimental command getBrowserContexts
+    returns
+      # An array of browser context ids.
+      array of BrowserContextID browserContextIds
+
   # Creates a new page.
   command createTarget
     parameters

third_party/blink/renderer/devtools/front_end/Tests.js

@@ -1113,10 +1113,16 @@
   TestSuite.prototype.testCreateBrowserContext = async function(url) {
     this.takeControl();
     const browserContextIds = [];
+    const targetAgent = SDK.targetManager.mainTarget().targetAgent();
 
     const target1 = await createIsolatedTarget(url);
     const target2 = await createIsolatedTarget(url);
 
+    const response = await targetAgent.invoke_getBrowserContexts();
+    this.assertEquals(response.browserContextIds.length, 2);
+    this.assertTrue(response.browserContextIds.includes(browserContextIds[0]));
+    this.assertTrue(response.browserContextIds.includes(browserContextIds[1]));
+
     await evalCode(target1, 'localStorage.setItem("page1", "page1")');
     await evalCode(target2, 'localStorage.setItem("page2", "page2")');
 
@@ -1139,7 +1145,6 @@
      * @return {!Promise<!SDK.Target>}
      */
     async function createIsolatedTarget(url) {
-      const targetAgent = SDK.targetManager.mainTarget().targetAgent();
       const {browserContextId} = await targetAgent.invoke_createBrowserContext();
       browserContextIds.push(browserContextId);