Commit 7cc3e781 authored by rtoy@chromium.org's avatar rtoy@chromium.org

Remove noteOn and noteOff methods from OscillatorNode

The WebAudio spec removed these methods a year ago in favor of start
and stop.  Chrome had removed these methods for
AudioBuffserSourceNodes, but not OscillatorNodes.

BUG=430995
TESTS=dom-exceptions updated

Review URL: https://codereview.chromium.org/707753006

git-svn-id: svn://svn.chromium.org/blink/trunk@185070 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 0a95c057
...@@ -127,6 +127,10 @@ PASS script.channelCountMode = 'explicit' did not throw exception. ...@@ -127,6 +127,10 @@ PASS script.channelCountMode = 'explicit' did not throw exception.
PASS script.channelCountMode = 'max' threw exception NotSupportedError: Failed to set the 'channelCountMode' property on 'AudioNode': channelCountMode cannot be changed from 'explicit' to 'max'. PASS script.channelCountMode = 'max' threw exception NotSupportedError: Failed to set the 'channelCountMode' property on 'AudioNode': channelCountMode cannot be changed from 'explicit' to 'max'.
PASS script.channelCountMode = 'clamped-max' threw exception NotSupportedError: Failed to set the 'channelCountMode' property on 'AudioNode': channelCountMode cannot be changed from 'explicit' to 'clamped-max'. PASS script.channelCountMode = 'clamped-max' threw exception NotSupportedError: Failed to set the 'channelCountMode' property on 'AudioNode': channelCountMode cannot be changed from 'explicit' to 'clamped-max'.
PASS script.channelCountMode = 'junk' did not throw exception. PASS script.channelCountMode = 'junk' did not throw exception.
PASS osc.noteOn is undefined.
PASS osc.noteOff is undefined.
PASS source.noteOn is undefined.
PASS source.noteOff is undefined.
PASS successfullyParsed is true PASS successfullyParsed is true
TEST COMPLETE TEST COMPLETE
......
...@@ -248,6 +248,12 @@ function runTest() { ...@@ -248,6 +248,12 @@ function runTest() {
shouldThrow("script.channelCountMode = 'max'"); shouldThrow("script.channelCountMode = 'max'");
shouldThrow("script.channelCountMode = 'clamped-max'"); shouldThrow("script.channelCountMode = 'clamped-max'");
shouldNotThrow("script.channelCountMode = 'junk'"); shouldNotThrow("script.channelCountMode = 'junk'");
// noteOn and noteOff don't exist anymore
shouldBeUndefined("osc.noteOn");
shouldBeUndefined("osc.noteOff");
shouldBeUndefined("source.noteOn");
shouldBeUndefined("source.noteOff");
} }
runTest(); runTest();
......
...@@ -43,9 +43,6 @@ enum OscillatorType { ...@@ -43,9 +43,6 @@ enum OscillatorType {
[RaisesException] void start(optional double when); [RaisesException] void start(optional double when);
[RaisesException] void stop(optional double when); [RaisesException] void stop(optional double when);
[RaisesException, ImplementedAs=start] void noteOn(double when);
[RaisesException, ImplementedAs=stop] void noteOff(double when);
void setPeriodicWave(PeriodicWave periodicWave); void setPeriodicWave(PeriodicWave periodicWave);
attribute EventHandler onended; attribute EventHandler onended;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment