Convert GN visibility to lists.

GN visibility currently allows either string or list types, but this is causing
some problems for some templates. I'm going to require it to be lists, so am
changing all callers before pushing the new binary.

Review URL: https://codereview.chromium.org/550333003

git-svn-id: svn://svn.chromium.org/blink/trunk@181583 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/Source/BUILD.gn

@@ -7,7 +7,7 @@ if (is_clang) {
   import("//build/config/clang/clang.gni")
 }
 
-visibility = "//third_party/WebKit/*"
+visibility = [ "//third_party/WebKit/*" ]
 
 # features ---------------------------------------------------------------------
 

third_party/WebKit/Source/bindings/BUILD.gn

@@ -7,7 +7,7 @@ import("//third_party/WebKit/Source/build/scripts/scripts.gni")
 import("//third_party/WebKit/Source/core/core.gni")
 import("//third_party/WebKit/Source/modules/modules.gni")
 
-visibility = "//third_party/WebKit/*"
+visibility = [ "//third_party/WebKit/*" ]
 
 # Main interface IDL files (excluding dependencies and testing)
 # are included as properties on global objects, and in aggregate bindings.

third_party/WebKit/Source/bindings/core/BUILD.gn

@@ -6,7 +6,7 @@ import("//third_party/WebKit/Source/bindings/core/core.gni")
 import("//third_party/WebKit/Source/bindings/core/idl.gni")
 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni")
 
-visibility = "//third_party/WebKit/*"
+visibility = [ "//third_party/WebKit/*" ]
 
 # GYP version: Source/bindings/core/generated.gyp:interfaces_info_individual_core
 compute_interfaces_info_individual("interfaces_info_individual_core") {

third_party/WebKit/Source/bindings/core/v8/BUILD.gn

@@ -8,7 +8,7 @@ import("//third_party/WebKit/Source/bindings/core/v8/generated.gni")
 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni")
 import("//third_party/WebKit/Source/core/core.gni")
 
-visibility = "//third_party/WebKit/Source/*"
+visibility = [ "//third_party/WebKit/Source/*" ]
 
 # bindings_core_v8_generated in core/v8/generated.gyp
 group("bindings_core_v8_generated") {

third_party/WebKit/Source/bindings/modules/BUILD.gn

@@ -8,7 +8,7 @@ import("//third_party/WebKit/Source/bindings/modules/modules.gni")
 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni")
 import("//third_party/WebKit/Source/build/scripts/scripts.gni")
 
-visibility = "//third_party/WebKit/*"
+visibility = [ "//third_party/WebKit/*" ]
 
 # GYP version: Source/bindings/modules/generated.gyp:bindings_modules_generated
 group("bindings_modules_generated") {

third_party/WebKit/Source/bindings/modules/v8/BUILD.gn

@@ -6,7 +6,7 @@ import("//third_party/WebKit/Source/bindings/modules/v8/generated.gni")
 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni")
 import("//third_party/WebKit/Source/modules/modules.gni")
 
-visibility = "//third_party/WebKit/*"
+visibility = [ "//third_party/WebKit/*" ]
 
 # bindings_modules_generated in modules/v8/generated.gyp
 group("bindings_modules_generated") {

third_party/WebKit/Source/bindings/scripts/BUILD.gn

@@ -6,7 +6,7 @@ import("//third_party/WebKit/Source/bindings/bindings.gni")
 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni")
 import("//third_party/WebKit/Source/bindings/templates/templates.gni")
 
-visibility = "//third_party/WebKit/*"
+visibility = [ "//third_party/WebKit/*" ]
 
 # This separate pre-caching step is required to use lex/parse table
 # caching in PLY, since PLY itself does not check if the cache is

third_party/WebKit/Source/core/BUILD.gn

@@ -13,7 +13,7 @@ import("//third_party/WebKit/Source/core/core.gni")
 import("//third_party/WebKit/Source/build/scripts/scripts.gni")
 import("//third_party/WebKit/Source/platform/platform_generated.gni")
 
-visibility = "//third_party/WebKit/Source/*"
+visibility = [ "//third_party/WebKit/Source/*" ]
 
 rel_blink_core_gen_dir = rebase_path(blink_core_output_dir, root_build_dir)
 
@@ -122,7 +122,8 @@ source_set("prerequisites") {
 #
 # GYP version: WebKit/Source/core/core.gyp:webcore
 source_set("core") {
-  visibility = "//third_party/WebKit/*"
+  visibility = []  # Allow re-assignment of list.
+  visibility = [ "//third_party/WebKit/*" ]
 
   exported_deps = [
     ":core_generated",
@@ -930,7 +931,8 @@ make_token_matcher("make_core_generated_make_token_matcher_for_viewport") {
 # You can use Blink-in-JS in your local experiment, but don't ship it.
 # crbug.com/341031
 action("make_core_generated_private_script") {
-  visibility = ":make_core_generated"
+  visibility = []  # Allow re-assignment of list.
+  visibility = [ ":make_core_generated" ]
   script = "../build/scripts/make_private_script_source.py"
 
   inputs = [
@@ -949,7 +951,8 @@ action("make_core_generated_private_script") {
 }
 
 action("make_core_generated_private_script_for_testing") {
-  visibility = ":make_core_generated"
+  visibility = []  # Allow re-assignment of list.
+  visibility = [ ":make_core_generated" ]
   script = "../build/scripts/make_private_script_source.py"
 
   inputs = [
@@ -968,7 +971,8 @@ action("make_core_generated_private_script_for_testing") {
 
 # "HTMLEntityTable" in make_core_generated from GYP.
 action("make_core_generated_html_entity_table") {
-  visibility = ":make_core_generated"
+  visibility = []  # Allow re-assignment of list.
+  visibility = [ ":make_core_generated" ]
   script = "html/parser/create-html-entity-table"
 
   inputs = [
@@ -986,7 +990,8 @@ action("make_core_generated_html_entity_table") {
 
 # "MediaQueryTokenizerCodepoints" in make_core_generated from GYP.
 action("make_core_generated_media_query_tokenizer_codepoints") {
-  visibility = ":make_core_generated"
+  visibility = []  # Allow re-assignment of list.
+  visibility = [ ":make_core_generated" ]
   script = "../build/scripts/make_mediaquery_tokenizer_codepoints.py"
 
   outputs = [
@@ -1002,7 +1007,8 @@ action("make_core_generated_media_query_tokenizer_codepoints") {
 
 # "UserAgentStyleSheets" in make_core_generated from GYP.
 action("make_core_generated_user_agent_style_sheets") {
-  visibility = ":make_core_generated"
+  visibility = []  # Allow re-assignment of list.
+  visibility = [ ":make_core_generated" ]
   script = "../build/scripts/make-file-arrays.py"
 
   inputs = [
@@ -1043,7 +1049,8 @@ action("make_core_generated_user_agent_style_sheets") {
 
 # "HTMLElementLookupTrie" in make_core_generated from GYP.
 action("make_core_generated_html_element_lookup_trie") {
-  visibility = ":make_core_generated"
+  visibility = []  # Allow re-assignment of list.
+  visibility = [ ":make_core_generated" ]
   script = "../build/scripts/make_element_lookup_trie.py"
 
   input_file = "html/HTMLTagNames.in"

third_party/WebKit/Source/core/inspector/BUILD.gn

@@ -5,7 +5,7 @@
 import("//third_party/WebKit/Source/bindings/bindings.gni")
 import("//third_party/WebKit/Source/core/core.gni")
 
-visibility = "//third_party/WebKit/Source/*"
+visibility = [ "//third_party/WebKit/Source/*" ]
 
 protocol_file = "../../devtools/protocol.json"
 

third_party/WebKit/Source/devtools/BUILD.gn

@@ -33,7 +33,7 @@ devtools_extensions_js_files = gypi_values.devtools_extensions_js_files -
 
 #-------------------------------------------------------------------------------
 
-visibility = "//third_party/WebKit/*"
+visibility = [ "//third_party/WebKit/*" ]
 
 # Probably need to parameterize this. If we set it to true, there will be some
 # further work in the scripts below.

third_party/WebKit/Source/modules/BUILD.gn

@@ -9,11 +9,12 @@ import("//third_party/WebKit/Source/build/make_file_arrays.gni")
 import("//third_party/WebKit/Source/build/scripts/scripts.gni")
 import("//third_party/WebKit/Source/modules/modules.gni")
 
-visibility = "//third_party/WebKit/Source/*"
+visibility = [ "//third_party/WebKit/Source/*" ]
 
 # GYP version: WebKit/Source/modules/modules.gyp:modules
 source_set("modules") {
-  visibility = "//third_party/WebKit/*"
+  visibility = []  # Allow re-assignment of list.
+  visibility = [ "//third_party/WebKit/*" ]
 
   sources = rebase_path(modules_files, ".", "//")
   sources += bindings_modules_v8_files

third_party/WebKit/Source/platform/BUILD.gn

@@ -9,7 +9,7 @@ import("//third_party/WebKit/Source/platform/platform.gni")
 import("//third_party/WebKit/Source/platform/platform_generated.gni")
 
 # Most targets in this file are private actions so use that as the default.
-visibility = ":*"
+visibility = [ ":*" ]
 
 heap_gypi = exec_script(
     "//build/gypi_to_gn.py",
@@ -27,7 +27,8 @@ blink_platform_neon_files = [
 
 # blink_common in blink_platform.gyp
 component("blink_common") {
-  visibility = "//third_party/WebKit/*"
+  visibility = []  # Allow re-assignment of list.
+  visibility = [ "//third_party/WebKit/*" ]
   sources = [
     "exported/WebCString.cpp",
     "exported/WebString.cpp",
@@ -149,7 +150,8 @@ action("color_data") {
 # This isn't strictly necessary since we can just add the deps to "platform",
 # but it helps to have the targets match the GYP build.
 group("make_platform_generated") {
-  visibility = "//third_party/WebKit/Source/*"
+  visibility = []  # Allow re-assignment of list.
+  visibility = [ "//third_party/WebKit/Source/*" ]
   deps = [
     ":blink_common",
     ":color_data",
@@ -161,7 +163,8 @@ group("make_platform_generated") {
 # TODO(brettw) Objective C Renaming postbuild steps on Mac.
 # blink_platform target in blink_platform.gyp
 component("platform") {
-  visibility = "//third_party/WebKit/*"
+  visibility = []  # Allow re-assignment of list.
+  visibility = [ "//third_party/WebKit/*" ]
   output_name = "blink_platform"
 
   sources = platform_files
@@ -333,7 +336,8 @@ component("platform") {
 }
 
 test("heap_unittests") {
-  visibility = "//third_party/WebKit/*"
+  visibility = []  # Allow re-assignment of list.
+  visibility = [ "//third_party/WebKit/*" ]
   output_name = "blink_heap_unittests"
 
   sources = rebase_path(heap_gypi.platform_heap_test_files, ".", "heap")
@@ -357,7 +361,8 @@ test("heap_unittests") {
 }
 
 test("platform_unittests") {
-  visibility = "//third_party/WebKit/*"
+  visibility = []  # Allow re-assignment of list.
+  visibility = [ "//third_party/WebKit/*" ]
   output_name = "blink_platform_unittests"
 
   sources = platform_test_files

third_party/WebKit/Source/platform/heap/BUILD.gn

@@ -2,7 +2,7 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-visibility = "//third_party/WebKit/Source/*"
+visibility = [ "//third_party/WebKit/Source/*" ]
 
 source_set("heap") {
   sources = [

third_party/WebKit/Source/web/BUILD.gn

@@ -9,7 +9,7 @@ import("//third_party/WebKit/Source/core/core.gni")
 import("//third_party/WebKit/Source/modules/modules.gni")
 import("//third_party/WebKit/Source/platform/platform.gni")
 
-visibility = "//third_party/WebKit/*"
+visibility = [ "//third_party/WebKit/*" ]
 web_gypi = exec_script(
     "//build/gypi_to_gn.py",
     [ rebase_path("web.gypi") ],

third_party/WebKit/Source/wtf/BUILD.gn

@@ -8,7 +8,7 @@ gypi_values = exec_script("//build/gypi_to_gn.py",
                           "scope",
                           [ "wtf.gypi" ])
 
-visibility = "//third_party/WebKit/*"
+visibility = [ "//third_party/WebKit/*" ]
 
 config("wtf_config") {
   if (is_win) {