Commit 7eb92377 authored by jonross's avatar jonross Committed by Commit Bot

Update GpuProcessHostDisableGLBrowserTest.CreateAndDestroy Disabling Hardware

GpuProcessHostDisableGLBrowserTest.CreateAndDestroy wants to use software
compositing, not the hardware path. The vulkan_content_browsertests were
enforcing that software fallback not be allowed. Causing this test to crash.

However BrowserTestBase::UseSoftwareCompositing already is in use by tests which
wish to explicitly be software compositing only. I'm adding this to the setup
of the test to allow it to run in the vulkan_content_browsertests suite.

TEST=vulkan_content_browsertests
GpuProcessHostDisableGLBrowserTest.CreateAndDestroy

Bug: 1009664
Change-Id: I85f00e2e3a4bf710d946ac69d46bd3e0e0879233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003251Reviewed-by: default avatarJonathan Backer <backer@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733397}
parent 46154835
...@@ -339,6 +339,7 @@ IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest, CreateTransferBuffer) { ...@@ -339,6 +339,7 @@ IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest, CreateTransferBuffer) {
class GpuProcessHostDisableGLBrowserTest : public GpuProcessHostBrowserTest { class GpuProcessHostDisableGLBrowserTest : public GpuProcessHostBrowserTest {
public: public:
void SetUpCommandLine(base::CommandLine* command_line) override { void SetUpCommandLine(base::CommandLine* command_line) override {
UseSoftwareCompositing();
GpuProcessHostBrowserTest::SetUpCommandLine(command_line); GpuProcessHostBrowserTest::SetUpCommandLine(command_line);
command_line->AppendSwitchASCII(switches::kUseGL, command_line->AppendSwitchASCII(switches::kUseGL,
gl::kGLImplementationDisabledName); gl::kGLImplementationDisabledName);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment