Open help app when 'Need help' button is pressed on parent access dialog

Help app will present help topic about parent access code:
https://support.google.com/families/answer/7307262
This change requires submitting new offline resources to
chromeos-assets (WIP).

Bug: 941702
Test: ParentAccessViewTest + manually
Change-Id: Ib7d9846e1e8bc4da3ce3ebb803a5d621994699d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764750Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689537}

ash/login/login_screen_controller.cc

@@ -449,6 +449,10 @@ void LoginScreenController::ShowAccountAccessHelpApp() {
   client_->ShowAccountAccessHelpApp();
 }
 
+void LoginScreenController::ShowParentAccessHelpApp() {
+  client_->ShowParentAccessHelpApp();
+}
+
 void LoginScreenController::ShowLockScreenNotificationSettings() {
   client_->ShowLockScreenNotificationSettings();
 }

ash/login/login_screen_controller.h

@@ -97,6 +97,7 @@ class ASH_EXPORT LoginScreenController : public LoginScreen,
   void ShowFeedback();
   void ShowResetScreen();
   void ShowAccountAccessHelpApp();
+  void ShowParentAccessHelpApp();
   void ShowLockScreenNotificationSettings();
   void FocusOobeDialog();
   void NotifyUserActivity();

ash/login/mock_login_screen_client.h

@@ -120,6 +120,7 @@ class MockLoginScreenClient : public LoginScreenClient {
   MOCK_METHOD(void, ShowFeedback, (), (override));
   MOCK_METHOD(void, ShowResetScreen, (), (override));
   MOCK_METHOD(void, ShowAccountAccessHelpApp, (), (override));
+  MOCK_METHOD(void, ShowParentAccessHelpApp, (), (override));
   MOCK_METHOD(void, ShowLockScreenNotificationSettings, (), (override));
   MOCK_METHOD(void, FocusOobeDialog, (), (override));
   MOCK_METHOD(void, OnFocusLeavingSystemTray, (bool reverse), (override));

ash/login/ui/parent_access_view.cc

@@ -542,7 +542,6 @@ ParentAccessView::ParentAccessView(const AccountId& account_id,
   add_spacer(kTitleToDescriptionDistanceDp);
 
   // Main view description.
-  // TODO(crbug.com/970223): Add learn more link after description.
   description_label_ = new views::Label(GetDescription(request_reason_),
                                         views::style::CONTEXT_LABEL,
                                         views::style::STYLE_PRIMARY);
@@ -684,8 +683,7 @@ void ParentAccessView::ButtonPressed(views::Button* sender,
   if (sender == back_button_) {
     callbacks_.on_finished.Run(false);
   } else if (sender == help_button_) {
-    // TODO(agawronska): Implement help view.
-    NOTIMPLEMENTED();
+    Shell::Get()->login_screen_controller()->ShowParentAccessHelpApp();
   } else if (sender == submit_button_) {
     SubmitCode();
   }

ash/login/ui/parent_access_view_unittest.cc

@@ -176,6 +176,18 @@ TEST_F(ParentAccessViewTest, SubmitButton) {
   EXPECT_EQ(1, successful_validation_);
 }
 
+// Tests that help button opens help app.
+TEST_F(ParentAccessViewTest, HelpButton) {
+  auto client = std::make_unique<MockLoginScreenClient>();
+  StartView();
+
+  ParentAccessView::TestApi test_api(view_);
+  EXPECT_TRUE(test_api.help_button()->GetEnabled());
+
+  EXPECT_CALL(*client, ShowParentAccessHelpApp()).Times(1);
+  SimulateButtonPress(test_api.help_button());
+}
+
 // Tests that access code can be entered with numpad.
 TEST_F(ParentAccessViewTest, Numpad) {
   StartView();

ash/public/cpp/login_screen_client.h

@@ -150,6 +150,9 @@ class ASH_PUBLIC_EXPORT LoginScreenClient {
   // Show the help app for when users have trouble signing in to their account.
   virtual void ShowAccountAccessHelpApp() = 0;
 
+  // Shows help app for users that have trouble using parent access code.
+  virtual void ShowParentAccessHelpApp() = 0;
+
   // Show the lockscreen notification settings page.
   virtual void ShowLockScreenNotificationSettings() = 0;
 

chrome/browser/chromeos/login/help_app_launcher.h

@@ -40,6 +40,8 @@ class HelpAppLauncher : public base::RefCountedThreadSafe<HelpAppLauncher> {
     HELP_WILCO_BATTERY_CHARGER = 9383188,
     // Shown as "Learn more" for Wilco notifications related to dock station.
     HELP_WILCO_DOCK = 9385025,
+    // Shown under "Need help?" button on parent access dialog.
+    HELP_PARENT_ACCESS_CODE = 7307262,
   };
 
   // The dialog is shown as a child of |parent_window|. If |parent_window| is

chrome/browser/ui/ash/login_screen_client.cc

@@ -233,6 +233,12 @@ void LoginScreenClient::ShowAccountAccessHelpApp() {
       ->ShowHelpTopic(chromeos::HelpAppLauncher::HELP_CANT_ACCESS_ACCOUNT);
 }
 
+void LoginScreenClient::ShowParentAccessHelpApp() {
+  scoped_refptr<chromeos::HelpAppLauncher>(
+      new chromeos::HelpAppLauncher(nullptr))
+      ->ShowHelpTopic(chromeos::HelpAppLauncher::HELP_PARENT_ACCESS_CODE);
+}
+
 void LoginScreenClient::ShowLockScreenNotificationSettings() {
   chrome::SettingsWindowManager::GetInstance()->ShowOSSettings(
       ProfileManager::GetActiveUserProfile(), chrome::kLockScreenSubPage);

chrome/browser/ui/ash/login_screen_client.h

@@ -117,6 +117,7 @@ class LoginScreenClient : public ash::LoginScreenClient {
   void ShowFeedback() override;
   void ShowResetScreen() override;
   void ShowAccountAccessHelpApp() override;
+  void ShowParentAccessHelpApp() override;
   void ShowLockScreenNotificationSettings() override;
   void OnFocusLeavingSystemTray(bool reverse) override;
   void OnUserActivity() override;