Skip to content

GitLab

T
tangled
Commit 807295bd authored by Juan Antonio Navarro Perez's avatar Juan Antonio Navarro Perez Committed by Commit Bot
Browse files
Options

[tools/perf] Remove contrib heap_profiler.* benchmarks 

These appear to be no longer used. Also deschedule them from
android-nexus5x-perf-fyi_map, where they used to be running.

That fyi bot might be useful, though, so we keep it for now running
another benchmark.

Bug: 1029016
Change-Id: I80258ba901b4cafd3012c532fef027d47fd53987
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944671
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: default avatarCaleb Rouleau <crouleau@chromium.org>
Reviewed-by: default avatarSami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720942}
parent 4b14f5d8
Show whitespace changes
Inline Side-by-side
Showing with 34 additions and 164 deletions
tools/perf/contrib/heap_profiling/OWNERS deleted 100644 → 0
View file @ 4b14f5d8
primiano@chromium.org
perezju@chromium.org
tools/perf/contrib/heap_profiling/heap_profiling.py deleted 100644 → 0
View file @ 4b14f5d8
# Copyright 2017 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import os
from benchmarks import loading_metrics_category
from core import perf_benchmark
from telemetry import story
from telemetry.timeline import chrome_trace_category_filter
from telemetry.timeline import chrome_trace_config
from telemetry.web_perf import timeline_based_measurement
import page_sets
from page_sets.system_health import loading_stories
_PAGE_SETS_DATA = os.path.join(os.path.dirname(page_sets.__file__), 'data')
class _HeapProfilingStorySet(story.StorySet):
"""Small story set containing loading stories and invoking memory dumps."""
def __init__(self, platform):
super(_HeapProfilingStorySet, self).__init__(
archive_data_file=
os.path.join(_PAGE_SETS_DATA, 'system_health_%s.json' % platform),
cloud_storage_bucket=story.PARTNER_BUCKET)
self.AddStory(
loading_stories.LoadGoogleStory2018(self, take_memory_measurement=True))
self.AddStory(
loading_stories.LoadTwitterStory(self, take_memory_measurement=True))
self.AddStory(
loading_stories.LoadCnnStory2018(self, take_memory_measurement=True))
class _HeapProfilingBenchmark(perf_benchmark.PerfBenchmark):
"""Bechmark to measure heap profiling overhead."""
PROFILING_MODE = NotImplemented
PLATFORM = NotImplemented
def CreateCoreTimelineBasedMeasurementOptions(self):
cat_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter(
filter_string='-*,toplevel,rail,disabled-by-default-memory-infra')
options = timeline_based_measurement.Options(cat_filter)
options.SetTimelineBasedMetrics([
'cpuTimeMetric',
'loadingMetric',
'memoryMetric',
'tracingMetric',
])
loading_metrics_category.AugmentOptionsForLoadingMetrics(options)
# Disable periodic dumps by setting default config.
options.config.chrome_trace_config.SetMemoryDumpConfig(
chrome_trace_config.MemoryDumpConfig())
return options
def CreateStorySet(self, options):
return _HeapProfilingStorySet(self.PLATFORM)
def SetExtraBrowserOptions(self, options):
super(_HeapProfilingBenchmark, self).SetExtraBrowserOptions(options)
args = []
if self.PROFILING_MODE == 'pseudo':
args += [
'--memlog=all', '--memlog-stack-mode=pseudo', '--memlog-sampling']
elif self.PROFILING_MODE == 'native':
args += [
'--memlog=all', '--memlog-stack-mode=native-with-thread-names',
'--memlog-sampling']
options.AppendExtraBrowserArgs(args)
class PseudoHeapProfilingDesktopBenchmark(_HeapProfilingBenchmark):
PROFILING_MODE = 'pseudo'
PLATFORM = 'desktop'
SUPPORTED_PLATFORMS = [story.expectations.ALL_DESKTOP]
@classmethod
def Name(cls):
return 'heap_profiling.desktop.pseudo'
class NativeHeapProfilingDesktopBenchmark(_HeapProfilingBenchmark):
PROFILING_MODE = 'native'
PLATFORM = 'desktop'
SUPPORTED_PLATFORMS = [story.expectations.ALL_DESKTOP]
@classmethod
def Name(cls):
return 'heap_profiling.desktop.native'
class DisabledHeapProfilingDesktopBenchmark(_HeapProfilingBenchmark):
PROFILING_MODE = 'disabled'
PLATFORM = 'desktop'
SUPPORTED_PLATFORMS = [story.expectations.ALL_DESKTOP]
@classmethod
def Name(cls):
return 'heap_profiling.desktop.disabled'
class PseudoHeapProfilingMobileBenchmark(_HeapProfilingBenchmark):
PROFILING_MODE = 'pseudo'
PLATFORM = 'mobile'
SUPPORTED_PLATFORMS = [story.expectations.ALL_MOBILE]
@classmethod
def Name(cls):
return 'heap_profiling.mobile.pseudo'
class NativeHeapProfilingMobileBenchmark(_HeapProfilingBenchmark):
PROFILING_MODE = 'native'
PLATFORM = 'mobile'
SUPPORTED_PLATFORMS = [story.expectations.ALL_MOBILE]
@classmethod
def Name(cls):
return 'heap_profiling.mobile.native'
class DisabledHeapProfilingMobileBenchmark(_HeapProfilingBenchmark):
PROFILING_MODE = 'disabled'
PLATFORM = 'mobile'
SUPPORTED_PLATFORMS = [story.expectations.ALL_MOBILE]
@classmethod
def Name(cls):
return 'heap_profiling.mobile.disabled'
tools/perf/core/bot_platforms.py
View file @ 807295bd
......@@ -195,9 +195,9 @@ _ANDROID_PIXEL2_WEBLAYER_BENCHMARK_CONFIGS = frozenset([
_GetBenchmarkConfig('system_health.common_mobile', True),
_GetBenchmarkConfig('system_health.memory_mobile', True)])
_ANDROID_NEXUS5X_FYI_BENCHMARK_CONFIGS = frozenset([
_GetBenchmarkConfig('heap_profiling.mobile.disabled'),
_GetBenchmarkConfig('heap_profiling.mobile.native'),
_GetBenchmarkConfig('heap_profiling.mobile.pseudo')])
# Running a sample benchmark to help testing out the work on
# trace_processor_shell: crbug.com/1028612
_GetBenchmarkConfig('tracing.tracing_with_background_memory_infra')])
_ANDROID_PIXEL2_FYI_BENCHMARK_CONFIGS = frozenset([
_GetBenchmarkConfig('v8.browsing_mobile'),
_GetBenchmarkConfig('system_health.memory_mobile'),
......
tools/perf/core/shard_maps/android-nexus5x-perf-fyi_map.json
View file @ 807295bd
{
"0": {
"benchmarks": {
"heap_profiling.mobile.disabled": {
"tracing.tracing_with_background_memory_infra": {
"end": 3,
"abridged": false
}
}
},
"1": {
"benchmarks": {
"heap_profiling.mobile.native": {
"tracing.tracing_with_background_memory_infra": {
"begin": 3,
"end": 6,
"abridged": false
}
}
},
"2": {
"benchmarks": {
"heap_profiling.mobile.pseudo": {
"tracing.tracing_with_background_memory_infra": {
"begin": 6,
"abridged": false
}
}
},
"extra_infos": {
"num_stories": 9,
"predicted_min_shard_time": 170.0,
"predicted_min_shard_time": 116.0,
"predicted_min_shard_index": 2,
"predicted_max_shard_time": 180.0,
"predicted_max_shard_time": 136.0,
"predicted_max_shard_index": 0,
"shard #0": 180.0,
"shard #1": 172.0,
"shard #2": 170.0
"shard #0": 136.0,
"shard #1": 136.0,
"shard #2": 116.0
}
}
\ No newline at end of file
tools/perf/core/shard_maps/timing_data/android-nexus5x-perf-fyi_timing.json
View file @ 807295bd
[
{
"duration": "37.0",
"name": "heap_profiling.mobile.disabled/load:news:cnn:2018"
"duration": "23.0",
"name": "tracing.tracing_with_background_memory_infra/Facebook"
},
{
"duration": "27.0",
"name": "heap_profiling.mobile.disabled/load:search:google:2018"
"duration": "23.0",
"name": "tracing.tracing_with_background_memory_infra/Wikipedia"
},
{
"duration": "26.0",
"name": "heap_profiling.mobile.disabled/load:social:twitter"
"duration": "22.0",
"name": "tracing.tracing_with_background_memory_infra/http://www.amazon.com"
},
{
"duration": "35.0",
"name": "heap_profiling.mobile.native/load:news:cnn:2018"
"duration": "19.0",
"name": "tracing.tracing_with_background_memory_infra/http://www.ask.com/"
},
{
"duration": "25.0",
"name": "heap_profiling.mobile.native/load:search:google:2018"
"duration": "19.0",
"name": "tracing.tracing_with_background_memory_infra/http://www.bing.com/"
},
{
"duration": "26.0",
"name": "heap_profiling.mobile.native/load:social:twitter"
"duration": "20.0",
"name": "tracing.tracing_with_background_memory_infra/http://www.yahoo.com/"
},
{
"duration": "35.0",
"name": "heap_profiling.mobile.pseudo/load:news:cnn:2018"
"duration": "22.0",
"name": "tracing.tracing_with_background_memory_infra/http://www.youtube.com"
},
{
"duration": "25.0",
"name": "heap_profiling.mobile.pseudo/load:search:google:2018"
"duration": "24.0",
"name": "tracing.tracing_with_background_memory_infra/https://www.google.com/#hl=en&q=barack+obama"
},
{
"duration": "25.0",
"name": "heap_profiling.mobile.pseudo/load:social:twitter"
"duration": "22.0",
"name": "tracing.tracing_with_background_memory_infra/https://www.google.com/calendar/"
}
]
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment