Commit 80c1caf8 authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

Fix v8_context_snapshot_generator incremental builds

Add a v8_maybe_snapshot dependency to generate_v8_context_snapshot so
it is rebuilt when the v8 snapshot changes. Without this change, in
component builds v8 changes would cause libv8.so to rebuild but would
rarely trigger a v8 context snapshot build.

Fixed: 865389
Change-Id: Ib35b564bc28147fcb090c3b7f7fa852c11846684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878249Reviewed-by: default avatarTakuto Ikuta <tikuta@chromium.org>
Reviewed-by: default avatarMichael Achenbach <machenbach@chromium.org>
Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709461}
parent 06360431
...@@ -67,13 +67,24 @@ if (use_v8_context_snapshot) { ...@@ -67,13 +67,24 @@ if (use_v8_context_snapshot) {
"--output_file=$output_path", "--output_file=$output_path",
] ]
outputs = [
output_file,
]
deps = [ deps = [
":v8_context_snapshot_generator($v8_snapshot_toolchain)", ":v8_context_snapshot_generator($v8_snapshot_toolchain)",
] ]
if (is_component_build) {
# In component builds, this forces the generator to rerun whenever the v8
# shared library is rebuilt. Without it would only regenerate if the
# generator itself was rebuilt.
inputs = [
"$root_out_dir/${shlib_prefix}v8${shlib_extension}",
]
deps += [ "//v8" ]
}
outputs = [
output_file,
]
} }
# This config disables a link time optimization "ICF", which may merge different # This config disables a link time optimization "ICF", which may merge different
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment