Commit 816a8363 authored by Varun Khaneja's avatar Varun Khaneja Committed by Commit Bot

Don't remove CPMC from RenderWidgetHost InputEvent observers

This CL effectively reverts crrev.com/c/2309814 because:
1) It caused a reduction in password reuse pings, thereby reducing
   phishing protection. See issue 1148252.
2) It was a speculative fix that didn't work.

I'm keeping this CL as small as possible so that the merge to earlier
milestones is straightforward and less scary.

Bug: 1104919
Change-Id: I9893b2e11e7947a0b74c3e948f72b02a1cef5109
Fixed: 1148252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533652
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Reviewed-by: default avatarJan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826755}
parent 1aa35ea2
...@@ -194,14 +194,14 @@ void AddToWidgetInputEventObservers( ...@@ -194,14 +194,14 @@ void AddToWidgetInputEventObservers(
} }
// Removes |observer| from the input observers of |widget_host|. // Removes |observer| from the input observers of |widget_host|.
void RemoveFromWidgetInputEventObservers( // This method is a NOOP for branded builds.
void MaybeRemoveFromWidgetInputEventObservers(
content::RenderWidgetHost* widget_host, content::RenderWidgetHost* widget_host,
content::RenderWidgetHost::InputEventObserver* observer) { content::RenderWidgetHost::InputEventObserver* observer) {
#if !BUILDFLAG(GOOGLE_CHROME_BRANDING) #if !BUILDFLAG(GOOGLE_CHROME_BRANDING)
// TODO(https://crbug.com/1104919): Remove this logging. // TODO(https://crbug.com/1104919): Remove this logging.
VLOG(1) << __FUNCTION__ << ": widget_host: " << widget_host VLOG(1) << __FUNCTION__ << ": widget_host: " << widget_host
<< "; observer: " << observer; << "; observer: " << observer;
#endif
if (!widget_host) if (!widget_host)
return; return;
...@@ -210,6 +210,7 @@ void RemoveFromWidgetInputEventObservers( ...@@ -210,6 +210,7 @@ void RemoveFromWidgetInputEventObservers(
widget_host->RemoveImeInputEventObserver(observer); widget_host->RemoveImeInputEventObserver(observer);
#endif #endif
widget_host->RemoveInputEventObserver(observer); widget_host->RemoveInputEventObserver(observer);
#endif // !BUILDFLAG(GOOGLE_CHROME_BRANDING)
} }
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
...@@ -1282,7 +1283,7 @@ void ChromePasswordManagerClient::WebContentsDestroyed() { ...@@ -1282,7 +1283,7 @@ void ChromePasswordManagerClient::WebContentsDestroyed() {
VLOG(1) << "wc->GetRenderViewHost(): " VLOG(1) << "wc->GetRenderViewHost(): "
<< web_contents()->GetMainFrame()->GetRenderViewHost(); << web_contents()->GetMainFrame()->GetRenderViewHost();
#endif #endif
RemoveFromWidgetInputEventObservers( MaybeRemoveFromWidgetInputEventObservers(
web_contents()->GetMainFrame()->GetRenderViewHost()->GetWidget(), this); web_contents()->GetMainFrame()->GetRenderViewHost()->GetWidget(), this);
auto* autofill_assistant_manager = auto* autofill_assistant_manager =
...@@ -1343,7 +1344,7 @@ void ChromePasswordManagerClient::RenderFrameDeleted( ...@@ -1343,7 +1344,7 @@ void ChromePasswordManagerClient::RenderFrameDeleted(
if (!render_frame_host->GetView()) if (!render_frame_host->GetView())
return; return;
RemoveFromWidgetInputEventObservers( MaybeRemoveFromWidgetInputEventObservers(
render_frame_host->GetView()->GetRenderWidgetHost(), this); render_frame_host->GetView()->GetRenderWidgetHost(), this);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment