Cleanup breadcrumbs logs

Breakpad imposes the limit to Breadcrumbs string, so the number of
uploaded events is limited. This CL removes logs which are less useful
to allow including more events.

Notable changes:
 - Remove "UserAction: " prefix as it does not make log more useful
 - Remove milliseconds from timestamp (take extra 3 digits per event)
 - Remove WillDetachWebStateAt event (having WebStateDetachedAt
   is sufficient)
 - Remove TitleWasSet event which happens for all pageloads

Bug: 1046231
Change-Id: I264b78942d4ad31c6790006e97a325dc9e04c366
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026167
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736466}

ios/chrome/browser/crash_report/breadcrumbs/application_breadcrumbs_logger.mm

@@ -38,8 +38,7 @@ void ApplicationBreadcrumbsLogger::OnUserAction(const std::string& action) {
     return;
   }
 
-  std::string event = base::StringPrintf("UserAction: %s", action.c_str());
-  breadcrumb_manager_->AddEvent(event);
+  breadcrumb_manager_->AddEvent(action.c_str());
 }
 
 void ApplicationBreadcrumbsLogger::OnMemoryPressure(

ios/chrome/browser/crash_report/breadcrumbs/application_breadcrumbs_logger_unittest.mm

@@ -47,8 +47,6 @@ TEST_F(ApplicationBreadcrumbsLoggerTest, UserAction) {
   std::list<std::string> events = breadcrumb_manager_.GetEvents(0);
   ASSERT_EQ(2ul, events.size());
   EXPECT_NE(std::string::npos, events.front().find(kUserAction1Name));
-  // Ensure UserAction events are labeled as such.
-  EXPECT_NE(std::string::npos, events.front().find("UserAction: "));
   events.pop_front();
   EXPECT_NE(std::string::npos, events.front().find(kUserAction2Name));
 }

ios/chrome/browser/crash_report/breadcrumbs/breadcrumb_manager.cc

@@ -63,8 +63,8 @@ void BreadcrumbManager::AddEvent(const std::string& event) {
 
   base::Time::Exploded exploded;
   time.UTCExplode(&exploded);
-  std::string timestamp = base::StringPrintf(
-      "%02d:%02d.%03d", exploded.minute, exploded.second, exploded.millisecond);
+  std::string timestamp =
+      base::StringPrintf("%02d:%02d", exploded.minute, exploded.second);
   std::string event_log =
       base::StringPrintf("%s %s", timestamp.c_str(), event.c_str());
   event_buckets_.back().second.push_back(event_log);

ios/chrome/browser/crash_report/breadcrumbs/breadcrumb_manager_browser_agent.h

@@ -64,9 +64,6 @@ class BreadcrumbManagerBrowserAgent
                           web::WebState* old_web_state,
                           web::WebState* new_web_state,
                           int index) override;
-  void WillDetachWebStateAt(WebStateList* web_state_list,
-                            web::WebState* web_state,
-                            int index) override;
   void WebStateDetachedAt(WebStateList* web_state_list,
                           web::WebState* web_state,
                           int index) override;

ios/chrome/browser/crash_report/breadcrumbs/breadcrumb_manager_browser_agent.mm

@@ -85,14 +85,6 @@ void BreadcrumbManagerBrowserAgent::WebStateReplacedAt(
   LogEvent(base::StringPrintf("Replaced Tab%d with Tab%d at %d",
                               old_web_state_id, new_web_state_id, index));
 }
-void BreadcrumbManagerBrowserAgent::WillDetachWebStateAt(
-    WebStateList* web_state_list,
-    web::WebState* web_state,
-    int index) {
-  int web_state_id =
-      BreadcrumbManagerTabHelper::FromWebState(web_state)->GetUniqueId();
-  LogEvent(base::StringPrintf("Will Detatch Tab%d at %d", web_state_id, index));
-}
 void BreadcrumbManagerBrowserAgent::WebStateDetachedAt(
     WebStateList* web_state_list,
     web::WebState* web_state,

ios/chrome/browser/crash_report/breadcrumbs/breadcrumb_manager_tab_helper.h

@@ -51,7 +51,6 @@ class BreadcrumbManagerTabHelper
       web::WebState* web_state,
       web::PageLoadCompletionStatus load_completion_status) override;
   void DidChangeBackForwardState(web::WebState* web_state) override;
-  void TitleWasSet(web::WebState* web_state) override;
   void DidChangeVisibleSecurityState(web::WebState* web_state) override;
   void RenderProcessGone(web::WebState* web_state) override;
   void WebStateDestroyed(web::WebState* web_state) override;

ios/chrome/browser/crash_report/breadcrumbs/breadcrumb_manager_tab_helper.mm

@@ -79,10 +79,6 @@ void BreadcrumbManagerTabHelper::DidChangeBackForwardState(
   LogEvent("DidChangeBackForwardState");
 }
 
-void BreadcrumbManagerTabHelper::TitleWasSet(web::WebState* web_state) {
-  LogEvent("TitleWasSet");
-}
-
 void BreadcrumbManagerTabHelper::DidChangeVisibleSecurityState(
     web::WebState* web_state) {
   LogEvent("DidChangeVisibleSecurityState");