Commit 82a08db1 authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Disable NotificationImageReporterTest. (try 2)

Its use of feature flags causes data races.

The first attempt in https://chromium-review.googlesource.com/1026462
got incorrectly reverted by FindIt.

BUG=836359
TBR=xidachen@chromium.org
NOTRY=true

Change-Id: Icfeaf23ccb69b3b1e80f6df10556f5c75e663a71
Reviewed-on: https://chromium-review.googlesource.com/1026557Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553263}
parent 3a1317cc
......@@ -192,7 +192,8 @@ void NotificationImageReporterTest::ReportNotificationImage() {
image_);
}
TEST_F(NotificationImageReporterTest, ReportSuccess) {
// Disabled due to data race. https://crbug.com/836359
TEST_F(NotificationImageReporterTest, DISABLED_ReportSuccess) {
SetExtendedReportingLevel(SBER_LEVEL_SCOUT);
ReportNotificationImage();
......@@ -217,7 +218,8 @@ TEST_F(NotificationImageReporterTest, ReportSuccess) {
EXPECT_FALSE(report.image().has_original_dimensions());
}
TEST_F(NotificationImageReporterTest, ImageDownscaling) {
// Disabled due to data race. https://crbug.com/836359
TEST_F(NotificationImageReporterTest, DISABLED_ImageDownscaling) {
SetExtendedReportingLevel(SBER_LEVEL_SCOUT);
image_ = CreateBitmap(640 /* w */, 360 /* h */);
......@@ -238,7 +240,8 @@ TEST_F(NotificationImageReporterTest, ImageDownscaling) {
EXPECT_EQ(360, report.image().original_dimensions().height());
}
TEST_F(NotificationImageReporterTest, NoReportWithoutSBER) {
// Disabled due to data race. https://crbug.com/836359
TEST_F(NotificationImageReporterTest, DISABLED_NoReportWithoutSBER) {
SetExtendedReportingLevel(SBER_LEVEL_OFF);
ReportNotificationImage();
......@@ -247,7 +250,8 @@ TEST_F(NotificationImageReporterTest, NoReportWithoutSBER) {
EXPECT_EQ(0, notification_image_reporter_->sent_report_count());
}
TEST_F(NotificationImageReporterTest, NoReportWithoutScout) {
// Disabled due to data race. https://crbug.com/836359
TEST_F(NotificationImageReporterTest, DISABLED_NoReportWithoutScout) {
SetExtendedReportingLevel(SBER_LEVEL_LEGACY);
ReportNotificationImage();
......@@ -280,7 +284,8 @@ TEST_F(NotificationImageReporterTest, NoReportOnWhitelistedUrl) {
EXPECT_EQ(0, notification_image_reporter_->sent_report_count());
}
TEST_F(NotificationImageReporterTest, MaxReportsPerDay) {
// Disabled due to data race. https://crbug.com/836359
TEST_F(NotificationImageReporterTest, DISABLED_MaxReportsPerDay) {
SetExtendedReportingLevel(SBER_LEVEL_SCOUT);
const int kMaxReportsPerDay = 5;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment