Don't set a default Value for content settigns type AutoSelectCertificate

BUG=106149
TEST=DefaultProviderTest*

Review URL: http://codereview.chromium.org/8776044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112680 0039d316-1c4b-4281-b951-d872f2087c98
parent c651e106
...@@ -55,6 +55,7 @@ namespace { ...@@ -55,6 +55,7 @@ namespace {
class DefaultRuleIterator : public RuleIterator { class DefaultRuleIterator : public RuleIterator {
public: public:
explicit DefaultRuleIterator(const base::Value* value) { explicit DefaultRuleIterator(const base::Value* value) {
if (value)
value_.reset(value->DeepCopy()); value_.reset(value->DeepCopy());
} }
...@@ -316,10 +317,12 @@ void DefaultProvider::ReadDefaultSettings(bool overwrite) { ...@@ -316,10 +317,12 @@ void DefaultProvider::ReadDefaultSettings(bool overwrite) {
void DefaultProvider::ForceDefaultsToBeExplicit() { void DefaultProvider::ForceDefaultsToBeExplicit() {
for (int i = 0; i < CONTENT_SETTINGS_NUM_TYPES; ++i) { for (int i = 0; i < CONTENT_SETTINGS_NUM_TYPES; ++i) {
ContentSettingsType type = ContentSettingsType(i); ContentSettingsType type = ContentSettingsType(i);
if (!default_settings_[type].get()) if (!default_settings_[type].get() &&
kDefaultSettings[i] != CONTENT_SETTING_DEFAULT) {
default_settings_[type].reset( default_settings_[type].reset(
Value::CreateIntegerValue(kDefaultSettings[i])); Value::CreateIntegerValue(kDefaultSettings[i]));
} }
}
} }
void DefaultProvider::GetSettingsFromDictionary( void DefaultProvider::GetSettingsFromDictionary(
......
...@@ -78,6 +78,15 @@ TEST_F(DefaultProviderTest, DefaultValues) { ...@@ -78,6 +78,15 @@ TEST_F(DefaultProviderTest, DefaultValues) {
CONTENT_SETTINGS_TYPE_GEOLOCATION, CONTENT_SETTINGS_TYPE_GEOLOCATION,
std::string(), std::string(),
false)); false));
scoped_ptr<base::Value> value(
GetContentSettingValue(&provider_,
GURL("http://example.com/"),
GURL("http://example.com/"),
CONTENT_SETTINGS_TYPE_AUTO_SELECT_CERTIFICATE,
std::string(),
false));
EXPECT_FALSE(value.get());
} }
TEST_F(DefaultProviderTest, IgnoreNonDefaultSettings) { TEST_F(DefaultProviderTest, IgnoreNonDefaultSettings) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment