Commit 83114ea3 authored by Ross McIlroy's avatar Ross McIlroy Committed by Commit Bot

[Cleanup] Avoid using deprecated v8::Function::Call in guest_view.

BUG=v8:7290,v8:8238

Change-Id: I826a5cba05bb6c5f322ddde79eecd2f64a942045
Reviewed-on: https://chromium-review.googlesource.com/c/1349261
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: default avatarLucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610634}
parent 5f5b8c3d
......@@ -181,7 +181,8 @@ void GuestViewContainer::RunDestructionCallback(bool embedder_frame_destroyed) {
v8::MicrotasksScope microtasks(
destruction_isolate_, v8::MicrotasksScope::kDoNotRunMicrotasks);
callback->Call(context->Global(), 0 /* argc */, nullptr);
callback->Call(context, context->Global(), 0 /* argc */, nullptr)
.FromMaybe(v8::Local<v8::Value>());
}
}
......@@ -269,7 +270,8 @@ void GuestViewContainer::CallElementResizeCallback(
v8::MicrotasksScope microtasks(
element_resize_isolate_, v8::MicrotasksScope::kDoNotRunMicrotasks);
callback->Call(context->Global(), argc, argv);
callback->Call(context, context->Global(), argc, argv)
.FromMaybe(v8::Local<v8::Value>());
}
base::WeakPtr<content::BrowserPluginDelegate> GuestViewContainer::GetWeakPtr() {
......
......@@ -45,7 +45,8 @@ void GuestViewRequest::ExecuteCallbackIfAvailable(
v8::MicrotasksScope microtasks(
isolate(), v8::MicrotasksScope::kDoNotRunMicrotasks);
callback->Call(context->Global(), argc, argv.get());
callback->Call(context, context->Global(), argc, argv.get())
.FromMaybe(v8::Local<v8::Value>());
}
GuestViewAttachRequest::GuestViewAttachRequest(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment