Commit 8332115e authored by Dale Curtis's avatar Dale Curtis Committed by Commit Bot

Add a media log event for SUSPENDED for clarity on internals page.

This causes the summary for a player to show up as "SUSPENDED"
when looking at the list of players in chrome://media-internals.
Making it easier to see which players are active and which are
now suspended.

Change-Id: I142efaaec97f533488831b9e26d77a95283c28c6
Reviewed-on: https://chromium-review.googlesource.com/c/1357615Reviewed-by: default avatarThomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612890}
parent 275a8025
...@@ -84,6 +84,8 @@ std::string MediaLog::EventTypeToString(MediaLogEvent::Type type) { ...@@ -84,6 +84,8 @@ std::string MediaLog::EventTypeToString(MediaLogEvent::Type type) {
return "MEDIA_DEBUG_LOG_ENTRY"; return "MEDIA_DEBUG_LOG_ENTRY";
case MediaLogEvent::PROPERTY_CHANGE: case MediaLogEvent::PROPERTY_CHANGE:
return "PROPERTY_CHANGE"; return "PROPERTY_CHANGE";
case MediaLogEvent::SUSPENDED:
return "SUSPENDED";
} }
NOTREACHED(); NOTREACHED();
return NULL; return NULL;
......
...@@ -89,7 +89,10 @@ struct MediaLogEvent { ...@@ -89,7 +89,10 @@ struct MediaLogEvent {
// A property has changed without any special event occurring. // A property has changed without any special event occurring.
PROPERTY_CHANGE, PROPERTY_CHANGE,
TYPE_LAST = PROPERTY_CHANGE // Issued when a player is suspended.
SUSPENDED,
TYPE_LAST = SUSPENDED
}; };
int32_t id; int32_t id;
......
...@@ -1509,6 +1509,9 @@ void WebMediaPlayerImpl::OnPipelineSeeked(bool time_updated) { ...@@ -1509,6 +1509,9 @@ void WebMediaPlayerImpl::OnPipelineSeeked(bool time_updated) {
} }
void WebMediaPlayerImpl::OnPipelineSuspended() { void WebMediaPlayerImpl::OnPipelineSuspended() {
// Add a log event so the player shows up as "SUSPENDED" in media-internals.
media_log_->AddEvent(media_log_->CreateEvent(MediaLogEvent::SUSPENDED));
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
if (IsRemote() && !IsNewRemotePlaybackPipelineEnabled()) { if (IsRemote() && !IsNewRemotePlaybackPipelineEnabled()) {
scoped_refptr<VideoFrame> frame = cast_impl_.GetCastingBanner(); scoped_refptr<VideoFrame> frame = cast_impl_.GetCastingBanner();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment