Commit 833de908 authored by Mohamed Abdelhalim's avatar Mohamed Abdelhalim Committed by Commit Bot

Navigation: Remove NavigationHandleImpl usages 2.

This is the 2nd CL of multiple CLs to remove the usages of
NavigationHandleImpl completely and replace it with NavigationRequest.

This CL replaces NavigationHandleImpl in NavigationControllerImpl with
NavigationRequest.

Bug: 995268
Change-Id: If80620bb63341089ffff78a37091afe008cdba48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803445
Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org>
Reviewed-by: default avatarArthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696848}
parent 9ca47047
...@@ -30,6 +30,7 @@ struct FrameHostMsg_DidCommitProvisionalLoad_Params; ...@@ -30,6 +30,7 @@ struct FrameHostMsg_DidCommitProvisionalLoad_Params;
namespace content { namespace content {
class FrameTreeNode; class FrameTreeNode;
class NavigationRequest;
class RenderFrameHostImpl; class RenderFrameHostImpl;
class SiteInstance; class SiteInstance;
struct LoadCommittedDetails; struct LoadCommittedDetails;
...@@ -368,8 +369,8 @@ class CONTENT_EXPORT NavigationControllerImpl : public NavigationController { ...@@ -368,8 +369,8 @@ class CONTENT_EXPORT NavigationControllerImpl : public NavigationController {
bool is_history_navigation_in_new_child_frame); bool is_history_navigation_in_new_child_frame);
// Returns whether there is a pending NavigationEntry whose unique ID matches // Returns whether there is a pending NavigationEntry whose unique ID matches
// the given NavigationHandle's pending_nav_entry_id. // the given NavigationRequest's pending_nav_entry_id.
bool PendingEntryMatchesHandle(NavigationHandleImpl* handle) const; bool PendingEntryMatchesRequest(NavigationRequest* request) const;
// Classifies the given renderer navigation (see the NavigationType enum). // Classifies the given renderer navigation (see the NavigationType enum).
NavigationType ClassifyNavigation( NavigationType ClassifyNavigation(
...@@ -396,30 +397,30 @@ class CONTENT_EXPORT NavigationControllerImpl : public NavigationController { ...@@ -396,30 +397,30 @@ class CONTENT_EXPORT NavigationControllerImpl : public NavigationController {
bool is_same_document, bool is_same_document,
bool replace_entry, bool replace_entry,
bool previous_document_was_activated, bool previous_document_was_activated,
NavigationHandleImpl* handle); NavigationRequest* request);
void RendererDidNavigateToExistingPage( void RendererDidNavigateToExistingPage(
RenderFrameHostImpl* rfh, RenderFrameHostImpl* rfh,
const FrameHostMsg_DidCommitProvisionalLoad_Params& params, const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
bool is_same_document, bool is_same_document,
bool was_restored, bool was_restored,
NavigationHandleImpl* handle, NavigationRequest* request,
bool keep_pending_entry); bool keep_pending_entry);
void RendererDidNavigateToSamePage( void RendererDidNavigateToSamePage(
RenderFrameHostImpl* rfh, RenderFrameHostImpl* rfh,
const FrameHostMsg_DidCommitProvisionalLoad_Params& params, const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
bool is_same_document, bool is_same_document,
NavigationHandleImpl* handle); NavigationRequest* request);
void RendererDidNavigateNewSubframe( void RendererDidNavigateNewSubframe(
RenderFrameHostImpl* rfh, RenderFrameHostImpl* rfh,
const FrameHostMsg_DidCommitProvisionalLoad_Params& params, const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
bool is_same_document, bool is_same_document,
bool replace_entry, bool replace_entry,
bool previous_document_was_activated, bool previous_document_was_activated,
NavigationHandleImpl* handle); NavigationRequest* request);
bool RendererDidNavigateAutoSubframe( bool RendererDidNavigateAutoSubframe(
RenderFrameHostImpl* rfh, RenderFrameHostImpl* rfh,
const FrameHostMsg_DidCommitProvisionalLoad_Params& params, const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
NavigationHandleImpl* handle); NavigationRequest* request);
// Allows the derived class to issue notifications that a load has been // Allows the derived class to issue notifications that a load has been
// committed. This will fill in the active entry to the details structure. // committed. This will fill in the active entry to the details structure.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment