Keep Google tts engine alive when Select to Speak is enabled
This change is somewhat of a workaround to shield Chrome from any issues contained within the underlying tts engine. Issues: - the extension system evicts extensions that don't explicitly fire an Activity as defined by extensions/browser/activity.h - audio playback isn't plumbed through as an activity - engines like Espeak work even for long utterances that hit the eviction time, because they trigger the extension api activity via word callbacks - the Google tts engine currently is buggy for some sentences in emitting callbacks All interleavings of increment/decrements were considered: - engine loads, enable ChromeVox/STS, disable ChromeVox/STS - enable ChromeVox, engine loads, enable STS, disable STS/ChromeVox - enable both STS and ChromeVox, engine loads, disable STS/ChromeVox In all cases, the keep alive count will be 0 at the end. R=dmazzoni@chromium.org Fixed: 1128093 Change-Id: I92b3fc32cd777961e4fbba40c5891c49943b9645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416571 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#808936}
Showing
Please register or sign in to comment