Skip to content

GitLab

T
tangled
Commit 8423730b authored by rune@opera.com's avatar rune@opera.com
Browse files
Options

Use style invalidation sets for :-webkit-autofill. 

Add invalidation features to a set for :-webkit-autofill and move
CSSSelector::PseudoAutofill away from the list of pseudo classes requiring
subtree style recalc.

The pseudo type cases in invalidationSetForSelector were re-ordered to
match the enum order.

R=chrishtr@chromium.org,esprehn@chromium.org
BUG=424581

Review URL: https://codereview.chromium.org/660273002

git-svn-id: svn://svn.chromium.org/blink/trunk@183955 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent f4a6c227
Show whitespace changes
Inline Side-by-side
Showing with 47 additions and 5 deletions
third_party/WebKit/LayoutTests/fast/css/invalidation/autofill-pseudo-expected.txt 0 → 100644
View file @ 8423730b
Use descendant invalidation set for :-webkit-autofill pseudo class.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS [object Internals] is defined.
PASS getComputedStyle(text, '').textDecorationLine is 'none'
PASS internals.updateStyleAndReturnAffectedElementCount() is 1
PASS getComputedStyle(text, '').textDecorationLine is 'underline'
PASS successfullyParsed is true
TEST COMPLETE
third_party/WebKit/LayoutTests/fast/css/invalidation/autofill-pseudo.html 0 → 100644
View file @ 8423730b
<!DOCTYPE html>
<script src="../../../resources/js-test.js"></script>
<style>
:-webkit-autofill { text-decoration: underline }
input + div { color: pink }
</style>
<input id="text" type="text"></input>
<div>
<div></div>
<div></div>
<div></div>
<div></div>
</div>
<script>
description("Use descendant invalidation set for :-webkit-autofill pseudo class.")
shouldBeDefined(window.internals);
shouldBe("getComputedStyle(text, '').textDecorationLine", "'none'");
text.offsetTop; // Force recalc.
internals.setAutofilled(text, true);
shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "1");
shouldBe("getComputedStyle(text, '').textDecorationLine", "'underline'");
</script>
third_party/WebKit/Source/core/css/RuleFeature.cpp
View file @ 8423730b
...@@ -87,6 +87,7 @@ static bool supportsInvalidation(CSSSelector::PseudoType type) ...@@ -87,6 +87,7 @@ static bool supportsInvalidation(CSSSelector::PseudoType type)
case CSSSelector::PseudoVisited: case CSSSelector::PseudoVisited:
case CSSSelector::PseudoAny: case CSSSelector::PseudoAny:
case CSSSelector::PseudoAnyLink: case CSSSelector::PseudoAnyLink:
case CSSSelector::PseudoAutofill:
case CSSSelector::PseudoHover: case CSSSelector::PseudoHover:
case CSSSelector::PseudoDrag: case CSSSelector::PseudoDrag:
case CSSSelector::PseudoFocus: case CSSSelector::PseudoFocus:
...@@ -151,7 +152,6 @@ static bool requiresSubtreeInvalidation(const CSSSelector& selector) ...@@ -151,7 +152,6 @@ static bool requiresSubtreeInvalidation(const CSSSelector& selector)
switch (selector.pseudoType()) { switch (selector.pseudoType()) {
case CSSSelector::PseudoFirstLine: case CSSSelector::PseudoFirstLine:
case CSSSelector::PseudoFirstLetter: case CSSSelector::PseudoFirstLetter:
case CSSSelector::PseudoAutofill:
case CSSSelector::PseudoFullPageMedia: case CSSSelector::PseudoFullPageMedia:
case CSSSelector::PseudoResizer: case CSSSelector::PseudoResizer:
case CSSSelector::PseudoWindowInactive: case CSSSelector::PseudoWindowInactive:
...@@ -295,16 +295,17 @@ DescendantInvalidationSet* RuleFeatureSet::invalidationSetForSelector(const CSSS ...@@ -295,16 +295,17 @@ DescendantInvalidationSet* RuleFeatureSet::invalidationSetForSelector(const CSSS
if (selector.match() == CSSSelector::PseudoClass) { if (selector.match() == CSSSelector::PseudoClass) {
switch (selector.pseudoType()) { switch (selector.pseudoType()) {
case CSSSelector::PseudoEmpty: case CSSSelector::PseudoEmpty:
case CSSSelector::PseudoLink:
case CSSSelector::PseudoVisited:
case CSSSelector::PseudoAutofill:
case CSSSelector::PseudoHover: case CSSSelector::PseudoHover:
case CSSSelector::PseudoActive:
case CSSSelector::PseudoFocus: case CSSSelector::PseudoFocus:
case CSSSelector::PseudoActive:
case CSSSelector::PseudoChecked: case CSSSelector::PseudoChecked:
case CSSSelector::PseudoEnabled: case CSSSelector::PseudoEnabled:
case CSSSelector::PseudoDisabled: case CSSSelector::PseudoDisabled:
case CSSSelector::PseudoIndeterminate: case CSSSelector::PseudoIndeterminate:
case CSSSelector::PseudoLink:
case CSSSelector::PseudoTarget: case CSSSelector::PseudoTarget:
case CSSSelector::PseudoVisited:
return &ensurePseudoInvalidationSet(selector.pseudoType()); return &ensurePseudoInvalidationSet(selector.pseudoType());
default: default:
break; break;
......
third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp
View file @ 8423730b
...@@ -206,7 +206,7 @@ void HTMLFormControlElement::setAutofilled(bool autofilled) ...@@ -206,7 +206,7 @@ void HTMLFormControlElement::setAutofilled(bool autofilled)
return; return;
m_isAutofilled = autofilled; m_isAutofilled = autofilled;
setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::ControlValue)); pseudoStateChanged(CSSSelector::PseudoAutofill);
} }
static bool shouldAutofocusOnAttach(const HTMLFormControlElement* element) static bool shouldAutofocusOnAttach(const HTMLFormControlElement* element)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment