Commit 843905c6 authored by Morten Stenshorne's avatar Morten Stenshorne Committed by Commit Bot

Compile unproblematic core directories with -Wshadow

No problems detected in these directories, so just enable it there.
Separate CLs are filed for directories that need fixing.

Bug: 294205
Change-Id: I0632b59a91ddc27f9be342d5141a34c08a624c0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460900
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816027}
parent f7a720e9
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("accessibility") { blink_core_sources("accessibility") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"ax_context.cc", "ax_context.cc",
"ax_context.h", "ax_context.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("animation_frame") { blink_core_sources("animation_frame") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"worker_animation_frame_provider.cc", "worker_animation_frame_provider.cc",
"worker_animation_frame_provider.h", "worker_animation_frame_provider.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("aom") { blink_core_sources("aom") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"accessible_node.cc", "accessible_node.cc",
"accessible_node.h", "accessible_node.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("clipboard") { blink_core_sources("clipboard") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"clipboard_mime_types.cc", "clipboard_mime_types.cc",
"clipboard_mime_types.h", "clipboard_mime_types.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("content_capture") { blink_core_sources("content_capture") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"content_capture_manager.cc", "content_capture_manager.cc",
"content_capture_manager.h", "content_capture_manager.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("context_features") { blink_core_sources("context_features") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"context_feature_settings.cc", "context_feature_settings.cc",
"context_feature_settings.h", "context_feature_settings.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("display_lock") { blink_core_sources("display_lock") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"display_lock_context.cc", "display_lock_context.cc",
"display_lock_context.h", "display_lock_context.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("events") { blink_core_sources("events") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"after_print_event.h", "after_print_event.h",
"animation_event.cc", "animation_event.cc",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("execution_context") { blink_core_sources("execution_context") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"agent.cc", "agent.cc",
"agent.h", "agent.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("feature_policy") { blink_core_sources("feature_policy") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"document_policy_parser.cc", "document_policy_parser.cc",
"document_policy_parser.h", "document_policy_parser.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("fileapi") { blink_core_sources("fileapi") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"blob.cc", "blob.cc",
"blob.h", "blob.h",
......
...@@ -6,6 +6,8 @@ import("//printing/buildflags/buildflags.gni") ...@@ -6,6 +6,8 @@ import("//printing/buildflags/buildflags.gni")
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("frame") { blink_core_sources("frame") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"ad_tracker.cc", "ad_tracker.cc",
"ad_tracker.h", "ad_tracker.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("fullscreen") { blink_core_sources("fullscreen") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"document_fullscreen.cc", "document_fullscreen.cc",
"document_fullscreen.h", "document_fullscreen.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("geometry") { blink_core_sources("geometry") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"dom_matrix.cc", "dom_matrix.cc",
"dom_matrix.h", "dom_matrix.h",
......
...@@ -6,6 +6,8 @@ import("//testing/libfuzzer/fuzzer_test.gni") ...@@ -6,6 +6,8 @@ import("//testing/libfuzzer/fuzzer_test.gni")
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("parser") { blink_core_sources("parser") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"atomic_html_token.cc", "atomic_html_token.cc",
"atomic_html_token.h", "atomic_html_token.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("imagebitmap") { blink_core_sources("imagebitmap") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"image_bitmap.cc", "image_bitmap.cc",
"image_bitmap.h", "image_bitmap.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("intersection_observer") { blink_core_sources("intersection_observer") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"element_intersection_observer_data.cc", "element_intersection_observer_data.cc",
"element_intersection_observer_data.h", "element_intersection_observer_data.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("messaging") { blink_core_sources("messaging") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"blink_cloneable_message.cc", "blink_cloneable_message.cc",
"blink_cloneable_message.h", "blink_cloneable_message.h",
......
...@@ -6,6 +6,8 @@ import("//mojo/public/tools/bindings/mojom.gni") ...@@ -6,6 +6,8 @@ import("//mojo/public/tools/bindings/mojom.gni")
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("mojo") { blink_core_sources("mojo") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"mojo.cc", "mojo.cc",
"mojo.h", "mojo.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("offscreencanvas") { blink_core_sources("offscreencanvas") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"offscreen_canvas.cc", "offscreen_canvas.cc",
"offscreen_canvas.h", "offscreen_canvas.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("origin_trials") { blink_core_sources("origin_trials") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"navigation_origin_trial_features.cc", "navigation_origin_trial_features.cc",
"origin_trial_context.cc", "origin_trial_context.cc",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("page") { blink_core_sources("page") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"autoscroll_controller.cc", "autoscroll_controller.cc",
"autoscroll_controller.h", "autoscroll_controller.h",
......
...@@ -36,6 +36,8 @@ source_set("generated") { ...@@ -36,6 +36,8 @@ source_set("generated") {
# Compiles the sources generated above. # Compiles the sources generated above.
blink_core_sources("probe") { blink_core_sources("probe") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"async_task_id.h", "async_task_id.h",
"core_probes.cc", "core_probes.cc",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("resize_observer") { blink_core_sources("resize_observer") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"resize_observation.cc", "resize_observation.cc",
"resize_observation.h", "resize_observation.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("script") { blink_core_sources("script") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"classic_pending_script.cc", "classic_pending_script.cc",
"classic_pending_script.h", "classic_pending_script.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("scroll") { blink_core_sources("scroll") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"ns_scroller_imp_details.h", "ns_scroller_imp_details.h",
"programmatic_scroll_animator.cc", "programmatic_scroll_animator.cc",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("streams") { blink_core_sources("streams") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"byte_length_queuing_strategy.cc", "byte_length_queuing_strategy.cc",
"byte_length_queuing_strategy.h", "byte_length_queuing_strategy.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("rendering") { blink_core_sources("rendering") {
configs += [ "//build/config/compiler:noshadowing" ]
visibility = [ "//third_party/blink/renderer/core/*" ] visibility = [ "//third_party/blink/renderer/core/*" ]
sources = [ sources = [
...@@ -102,6 +104,8 @@ blink_core_sources("rendering") { ...@@ -102,6 +104,8 @@ blink_core_sources("rendering") {
} }
blink_core_sources("svg_style") { blink_core_sources("svg_style") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"svg_computed_style.cc", "svg_computed_style.cc",
"svg_computed_style.h", "svg_computed_style.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("svg") { blink_core_sources("svg") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"animation/element_smil_animations.cc", "animation/element_smil_animations.cc",
"animation/element_smil_animations.h", "animation/element_smil_animations.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("timezone") { blink_core_sources("timezone") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"timezone_controller.cc", "timezone_controller.cc",
"timezone_controller.h", "timezone_controller.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("timing") { blink_core_sources("timing") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"dom_window_performance.cc", "dom_window_performance.cc",
"dom_window_performance.h", "dom_window_performance.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("trustedtypes") { blink_core_sources("trustedtypes") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"trusted_html.cc", "trusted_html.cc",
"trusted_html.h", "trusted_html.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("typed_arrays") { blink_core_sources("typed_arrays") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"array_buffer/array_buffer_contents.cc", "array_buffer/array_buffer_contents.cc",
"array_buffer/array_buffer_contents.h", "array_buffer/array_buffer_contents.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("url") { blink_core_sources("url") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"dom_url.cc", "dom_url.cc",
"dom_url.h", "dom_url.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("workers") { blink_core_sources("workers") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"abstract_worker.cc", "abstract_worker.cc",
"abstract_worker.h", "abstract_worker.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("xml") { blink_core_sources("xml") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"document_xml_tree_viewer.cc", "document_xml_tree_viewer.cc",
"document_xml_tree_viewer.h", "document_xml_tree_viewer.h",
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
import("//third_party/blink/renderer/core/core.gni") import("//third_party/blink/renderer/core/core.gni")
blink_core_sources("xmlhttprequest") { blink_core_sources("xmlhttprequest") {
configs += [ "//build/config/compiler:noshadowing" ]
sources = [ sources = [
"xml_http_request.cc", "xml_http_request.cc",
"xml_http_request.h", "xml_http_request.h",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment