Commit 845a7de9 authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

Enable "gn check" for //third_party/blink/renderer/modules

* Add missing dependencies

* Move html_media_test_helper.* from html:unit_tests to
  core:unit_test_support
* Move fake_canvas_resource_host.h from platform:unit_tests to
  platform:test_support
  Because they are used in modules:unit_tests, and it can't depend on
  html:unit_tests and platform:unit_tests.

This CL has no behavior changes.

Bug: 800764
Change-Id: Ia97540cb14b51dabd36fe70bbb74c2c3abf21fe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406233
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: default avatarTakuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806533}
parent c2a5c562
...@@ -253,7 +253,6 @@ no_check_targets = [ ...@@ -253,7 +253,6 @@ no_check_targets = [
"//third_party/blink/renderer/modules/canvas:*", # 1 error "//third_party/blink/renderer/modules/canvas:*", # 1 error
"//third_party/blink/renderer/modules/font_access:*", # 3 errors "//third_party/blink/renderer/modules/font_access:*", # 3 errors
"//third_party/blink/renderer/modules/peerconnection:*", # 43 errors "//third_party/blink/renderer/modules/peerconnection:*", # 43 errors
"//third_party/blink/renderer/modules:*", # 321 errors
"//third_party/blink/renderer/platform:*", # 10 errors "//third_party/blink/renderer/platform:*", # 10 errors
"//third_party/breakpad:*", # 34 errors "//third_party/breakpad:*", # 34 errors
......
...@@ -1523,6 +1523,8 @@ source_set("unit_test_support") { ...@@ -1523,6 +1523,8 @@ source_set("unit_test_support") {
sources = [ sources = [
"frame/frame_test_helpers.cc", "frame/frame_test_helpers.cc",
"frame/frame_test_helpers.h", "frame/frame_test_helpers.h",
"html/media/html_media_test_helper.cc",
"html/media/html_media_test_helper.h",
"script/mock_script_element_base.h", "script/mock_script_element_base.h",
"testing/core_unit_test_helper.cc", "testing/core_unit_test_helper.cc",
"testing/core_unit_test_helper.h", "testing/core_unit_test_helper.h",
......
...@@ -687,8 +687,6 @@ blink_core_tests("unit_tests") { ...@@ -687,8 +687,6 @@ blink_core_tests("unit_tests") {
"media/autoplay_uma_helper_test.cc", "media/autoplay_uma_helper_test.cc",
"media/html_media_element_event_listeners_test.cc", "media/html_media_element_event_listeners_test.cc",
"media/html_media_element_test.cc", "media/html_media_element_test.cc",
"media/html_media_test_helper.cc",
"media/html_media_test_helper.h",
"media/html_video_element_persistent_test.cc", "media/html_video_element_persistent_test.cc",
"media/html_video_element_test.cc", "media/html_video_element_test.cc",
"media/media_custom_controls_fullscreen_detector_test.cc", "media/media_custom_controls_fullscreen_detector_test.cc",
......
...@@ -245,9 +245,11 @@ source_set("modules_testing") { ...@@ -245,9 +245,11 @@ source_set("modules_testing") {
"//third_party/blink/renderer/core:blink_core_pch", "//third_party/blink/renderer/core:blink_core_pch",
] ]
public_deps = [ "//testing/gmock:gmock" ]
deps = [ deps = [
"//third_party/blink/renderer/bindings/modules/v8:testing", "//third_party/blink/renderer/bindings/modules/v8:testing",
"//third_party/blink/renderer/core", "//third_party/blink/renderer/core",
"//third_party/blink/renderer/core:testing",
"//third_party/blink/renderer/modules", "//third_party/blink/renderer/modules",
] ]
} }
...@@ -496,23 +498,34 @@ source_set("unit_tests") { ...@@ -496,23 +498,34 @@ source_set("unit_tests") {
"//components/schema_org/common:mojom_blink", "//components/schema_org/common:mojom_blink",
"//media:test_support", "//media:test_support",
"//media/mojo/mojom", "//media/mojo/mojom",
"//media/webrtc:webrtc",
"//mojo/public/cpp/bindings", "//mojo/public/cpp/bindings",
"//net:quic_test_tools", "//net:quic_test_tools",
"//net:test_support",
"//services/device/public/cpp:test_support", "//services/device/public/cpp:test_support",
"//skia", "//skia",
"//testing/gmock", "//testing/gmock",
"//testing/gtest", "//testing/gtest",
"//third_party/blink/public:blink_headers", "//third_party/blink/public:blink_headers",
"//third_party/blink/public:test_headers",
"//third_party/blink/public/strings:strings_grit",
"//third_party/blink/renderer/controller:blink_bindings_test_sources",
"//third_party/blink/renderer/core", "//third_party/blink/renderer/core",
"//third_party/blink/renderer/core:testing",
"//third_party/blink/renderer/core:unit_test_support", "//third_party/blink/renderer/core:unit_test_support",
"//third_party/blink/renderer/modules/gamepad:unit_tests", "//third_party/blink/renderer/modules/gamepad:unit_tests",
"//third_party/blink/renderer/modules/hid:unit_tests", "//third_party/blink/renderer/modules/hid:unit_tests",
"//third_party/blink/renderer/modules/mediarecorder:buildflags",
"//third_party/blink/renderer/modules/mediastream:test_support",
"//third_party/blink/renderer/modules/native_file_system:unit_tests", "//third_party/blink/renderer/modules/native_file_system:unit_tests",
"//third_party/blink/renderer/modules/peerconnection:test_support",
"//third_party/blink/renderer/modules/storage:unit_tests", "//third_party/blink/renderer/modules/storage:unit_tests",
"//third_party/blink/renderer/modules/webcodecs:unit_tests", "//third_party/blink/renderer/modules/webcodecs:unit_tests",
"//third_party/blink/renderer/modules/webtransport:unit_tests", "//third_party/blink/renderer/modules/webtransport:unit_tests",
"//third_party/blink/renderer/platform", "//third_party/blink/renderer/platform",
"//third_party/blink/renderer/platform:test_support",
"//third_party/blink/renderer/platform/wtf", "//third_party/blink/renderer/platform/wtf",
"//third_party/googletest:gmock",
"//third_party/opus", "//third_party/opus",
"//third_party/webrtc_overrides:webrtc_component", "//third_party/webrtc_overrides:webrtc_component",
"//v8", "//v8",
...@@ -552,6 +565,7 @@ if (use_libfuzzer) { ...@@ -552,6 +565,7 @@ if (use_libfuzzer) {
deps = [ deps = [
":modules", ":modules",
"//third_party/blink/renderer/core:testing",
"//third_party/blink/renderer/modules/media_capabilities:fuzzer_media_configuration_proto", "//third_party/blink/renderer/modules/media_capabilities:fuzzer_media_configuration_proto",
"//third_party/blink/renderer/platform:blink_fuzzer_test_support", "//third_party/blink/renderer/platform:blink_fuzzer_test_support",
"//third_party/libprotobuf-mutator", "//third_party/libprotobuf-mutator",
...@@ -570,6 +584,7 @@ if (use_libfuzzer) { ...@@ -570,6 +584,7 @@ if (use_libfuzzer) {
deps = [ deps = [
":modules", ":modules",
"//third_party/blink/renderer/core:testing",
"//third_party/blink/renderer/modules/webcodecs:fuzzer_protos", "//third_party/blink/renderer/modules/webcodecs:fuzzer_protos",
"//third_party/blink/renderer/platform:blink_fuzzer_test_support", "//third_party/blink/renderer/platform:blink_fuzzer_test_support",
"//third_party/libprotobuf-mutator", "//third_party/libprotobuf-mutator",
...@@ -588,6 +603,7 @@ if (use_libfuzzer) { ...@@ -588,6 +603,7 @@ if (use_libfuzzer) {
deps = [ deps = [
":modules", ":modules",
"//third_party/blink/renderer/core:testing",
"//third_party/blink/renderer/modules/webcodecs:fuzzer_protos", "//third_party/blink/renderer/modules/webcodecs:fuzzer_protos",
"//third_party/blink/renderer/platform:blink_fuzzer_test_support", "//third_party/blink/renderer/platform:blink_fuzzer_test_support",
"//third_party/libprotobuf-mutator", "//third_party/libprotobuf-mutator",
...@@ -606,6 +622,7 @@ if (use_libfuzzer) { ...@@ -606,6 +622,7 @@ if (use_libfuzzer) {
deps = [ deps = [
":modules", ":modules",
"//third_party/blink/renderer/core:testing",
"//third_party/blink/renderer/modules/webcodecs:fuzzer_protos", "//third_party/blink/renderer/modules/webcodecs:fuzzer_protos",
"//third_party/blink/renderer/platform:blink_fuzzer_test_support", "//third_party/blink/renderer/platform:blink_fuzzer_test_support",
"//third_party/libprotobuf-mutator", "//third_party/libprotobuf-mutator",
......
...@@ -1736,6 +1736,7 @@ static_library("test_support") { ...@@ -1736,6 +1736,7 @@ static_library("test_support") {
sources = [ sources = [
"graphics/gpu/drawing_buffer_test_helpers.h", "graphics/gpu/drawing_buffer_test_helpers.h",
"graphics/paint/paint_controller_test.h", "graphics/paint/paint_controller_test.h",
"graphics/test/fake_canvas_resource_host.h",
"graphics/test/fake_gles2_interface.h", "graphics/test/fake_gles2_interface.h",
"graphics/test/fake_web_graphics_context_3d_provider.h", "graphics/test/fake_web_graphics_context_3d_provider.h",
"graphics/test/gpu_memory_buffer_test_platform.h", "graphics/test/gpu_memory_buffer_test_platform.h",
...@@ -2404,7 +2405,6 @@ source_set("unit_tests") { ...@@ -2404,7 +2405,6 @@ source_set("unit_tests") {
"graphics/image_decoding_store_test.cc", "graphics/image_decoding_store_test.cc",
"graphics/image_frame_generator_test.cc", "graphics/image_frame_generator_test.cc",
"graphics/paint_worklet_paint_dispatcher_test.cc", "graphics/paint_worklet_paint_dispatcher_test.cc",
"graphics/test/fake_canvas_resource_host.h",
"graphics/test/stub_image.h", "graphics/test/stub_image.h",
# Tests migrated from the web/tests directory. # Tests migrated from the web/tests directory.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment