Commit 8462afe8 authored by Philip Rogers's avatar Philip Rogers Committed by Commit Bot

[PaintTouchActionRects] Remove redundant paint offset parameter

This patch removes the paint offset parameter for RecordHitTestData
which is now baked into the paint_rect parameter.

Change-Id: Idecbde110b50db2d62e3cec720861a1f39aecd88
Reviewed-on: https://chromium-review.googlesource.com/c/1329855
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: default avatarXianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607298}
parent ce7ecc9b
...@@ -91,7 +91,7 @@ void BoxPainter::PaintBoxDecorationBackground(const PaintInfo& paint_info, ...@@ -91,7 +91,7 @@ void BoxPainter::PaintBoxDecorationBackground(const PaintInfo& paint_info,
} }
if (RuntimeEnabledFeatures::PaintTouchActionRectsEnabled()) if (RuntimeEnabledFeatures::PaintTouchActionRectsEnabled())
RecordHitTestData(paint_info, paint_offset, paint_rect, *background_client); RecordHitTestData(paint_info, paint_rect, *background_client);
} }
bool BoxPainter::BackgroundIsKnownToBeOpaque(const PaintInfo& paint_info) { bool BoxPainter::BackgroundIsKnownToBeOpaque(const PaintInfo& paint_info) {
...@@ -252,7 +252,6 @@ void BoxPainter::PaintMaskImages(const PaintInfo& paint_info, ...@@ -252,7 +252,6 @@ void BoxPainter::PaintMaskImages(const PaintInfo& paint_info,
} }
void BoxPainter::RecordHitTestData(const PaintInfo& paint_info, void BoxPainter::RecordHitTestData(const PaintInfo& paint_info,
const LayoutPoint& paint_offset,
const LayoutRect& paint_rect, const LayoutRect& paint_rect,
const DisplayItemClient& background_client) { const DisplayItemClient& background_client) {
// Hit test display items are only needed for compositing. This flag is used // Hit test display items are only needed for compositing. This flag is used
......
...@@ -42,7 +42,6 @@ class BoxPainter { ...@@ -42,7 +42,6 @@ class BoxPainter {
// called in the background paint phase even if there is no other painted // called in the background paint phase even if there is no other painted
// content. // content.
void RecordHitTestData(const PaintInfo&, void RecordHitTestData(const PaintInfo&,
const LayoutPoint& paint_offset,
const LayoutRect& paint_rect, const LayoutRect& paint_rect,
const DisplayItemClient& background_client); const DisplayItemClient& background_client);
......
...@@ -81,8 +81,7 @@ void FieldsetPainter::PaintBoxDecorationBackground( ...@@ -81,8 +81,7 @@ void FieldsetPainter::PaintBoxDecorationBackground(
if (RuntimeEnabledFeatures::PaintTouchActionRectsEnabled()) { if (RuntimeEnabledFeatures::PaintTouchActionRectsEnabled()) {
BoxPainter(layout_fieldset_) BoxPainter(layout_fieldset_)
.RecordHitTestData(paint_info, paint_offset, paint_rect, .RecordHitTestData(paint_info, paint_rect, layout_fieldset_);
layout_fieldset_);
} }
} }
......
...@@ -125,7 +125,7 @@ void ReplacedPainter::Paint(const PaintInfo& paint_info) { ...@@ -125,7 +125,7 @@ void ReplacedPainter::Paint(const PaintInfo& paint_info) {
// the background but still need to paint the touch action rects. // the background but still need to paint the touch action rects.
if (RuntimeEnabledFeatures::PaintTouchActionRectsEnabled()) { if (RuntimeEnabledFeatures::PaintTouchActionRectsEnabled()) {
BoxPainter(layout_replaced_) BoxPainter(layout_replaced_)
.RecordHitTestData(local_paint_info, paint_offset, border_rect, .RecordHitTestData(local_paint_info, border_rect,
layout_replaced_); layout_replaced_);
} }
return; return;
......
...@@ -120,7 +120,7 @@ void TableCellPainter::PaintBoxDecorationBackground( ...@@ -120,7 +120,7 @@ void TableCellPainter::PaintBoxDecorationBackground(
if (RuntimeEnabledFeatures::PaintTouchActionRectsEnabled()) { if (RuntimeEnabledFeatures::PaintTouchActionRectsEnabled()) {
LayoutRect rect = PaintRectNotIncludingVisualOverflow(paint_offset); LayoutRect rect = PaintRectNotIncludingVisualOverflow(paint_offset);
BoxPainter(layout_table_cell_) BoxPainter(layout_table_cell_)
.RecordHitTestData(paint_info, paint_offset, rect, layout_table_cell_); .RecordHitTestData(paint_info, rect, layout_table_cell_);
} }
} }
......
...@@ -66,7 +66,7 @@ void TablePainter::PaintBoxDecorationBackground( ...@@ -66,7 +66,7 @@ void TablePainter::PaintBoxDecorationBackground(
if (RuntimeEnabledFeatures::PaintTouchActionRectsEnabled()) { if (RuntimeEnabledFeatures::PaintTouchActionRectsEnabled()) {
BoxPainter(layout_table_) BoxPainter(layout_table_)
.RecordHitTestData(paint_info, paint_offset, rect, layout_table_); .RecordHitTestData(paint_info, rect, layout_table_);
} }
} }
......
...@@ -74,8 +74,8 @@ void ViewPainter::PaintBoxDecorationBackground(const PaintInfo& paint_info) { ...@@ -74,8 +74,8 @@ void ViewPainter::PaintBoxDecorationBackground(const PaintInfo& paint_info) {
} }
if (has_touch_action_rect) { if (has_touch_action_rect) {
BoxPainter(layout_view_) BoxPainter(layout_view_)
.RecordHitTestData(paint_info, LayoutPoint(), .RecordHitTestData(paint_info, LayoutRect(background_rect),
LayoutRect(background_rect), *background_client); *background_client);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment