Commit 850aa23b authored by Xiyuan Xia's avatar Xiyuan Xia Committed by Commit Bot

ash: Use CONTINUE_ON_SHUTDOWN for AccelerometerReader

AccelerometerReader's data reading blocks shutdown on certain
devices. Use CONTINUE_ON_SHUTDOWN to run it on a thread that
Chrome does not wait to join during shutdown.

Bug: 1023989
Change-Id: I4fdad845fd59b45f3dc58a28edea031e733d934a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916691Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715336}
parent 5b1ca7b1
...@@ -546,11 +546,13 @@ Shell::Shell(std::unique_ptr<ShellDelegate> shell_delegate, ...@@ -546,11 +546,13 @@ Shell::Shell(std::unique_ptr<ShellDelegate> shell_delegate,
// AccelerometerReader is important for screen orientation so we need // AccelerometerReader is important for screen orientation so we need
// USER_VISIBLE priority. // USER_VISIBLE priority.
// Use CONTINUE_ON_SHUTDOWN to avoid blocking shutdown since the data reading
// could get blocked on certain devices. See https://crbug.com/1023989.
AccelerometerReader::GetInstance()->Initialize( AccelerometerReader::GetInstance()->Initialize(
base::CreateSequencedTaskRunner( base::CreateSequencedTaskRunner(
{base::ThreadPool(), base::MayBlock(), {base::ThreadPool(), base::MayBlock(),
base::TaskPriority::USER_VISIBLE, base::TaskPriority::USER_VISIBLE,
base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN})); base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN}));
login_screen_controller_ = login_screen_controller_ =
std::make_unique<LoginScreenController>(system_tray_notifier_.get()); std::make_unique<LoginScreenController>(system_tray_notifier_.get());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment