Mojo: Move test_embedder.* to the mojo_system_impl component.

Also, tighten up DEPS: things outside mojo/system/ shouldn't include
things in mojo/system/, unless they're an embedder in which case they
can include things in mojo/system/embedder/.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/136473007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245381 0039d316-1c4b-4281-b951-d872f2087c98
parent cd0f7afb
...@@ -2,6 +2,7 @@ include_rules = [ ...@@ -2,6 +2,7 @@ include_rules = [
"+base", "+base",
"+build", "+build",
"+mojo", "+mojo",
"-mojo/system",
"+mojom", "+mojom",
"+testing", "+testing",
] ]
...@@ -140,6 +140,12 @@ ...@@ -140,6 +140,12 @@
'system/waiter.h', 'system/waiter.h',
'system/waiter_list.cc', 'system/waiter_list.cc',
'system/waiter_list.h', 'system/waiter_list.h',
# Test-only code:
# TODO(vtl): It's a little unfortunate that these end up in the same
# component as non-test-only code. In the static build, this code should
# hopefully be dead-stripped.
'system/embedder/test_embedder.cc',
'system/embedder/test_embedder.h',
], ],
}, },
{ {
...@@ -166,10 +172,6 @@ ...@@ -166,10 +172,6 @@
'system/raw_channel_posix_unittest.cc', 'system/raw_channel_posix_unittest.cc',
'system/remote_message_pipe_posix_unittest.cc', 'system/remote_message_pipe_posix_unittest.cc',
'system/simple_dispatcher_unittest.cc', 'system/simple_dispatcher_unittest.cc',
# TODO(vtl): Move this to mojo_system_impl (and mojo_system_impl's
# exports).
'system/embedder/test_embedder.cc',
'system/embedder/test_embedder.h',
'system/test_utils.cc', 'system/test_utils.cc',
'system/test_utils.h', 'system/test_utils.h',
'system/waiter_list_unittest.cc', 'system/waiter_list_unittest.cc',
......
include_rules = [ include_rules = [
"+mojo/system/embedder",
"+net", "+net",
"+ui/gl", "+ui/gl",
] ]
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
#ifndef MOJO_SYSTEM_EMBEDDER_TEST_EMBEDDER_H_ #ifndef MOJO_SYSTEM_EMBEDDER_TEST_EMBEDDER_H_
#define MOJO_SYSTEM_EMBEDDER_TEST_EMBEDDER_H_ #define MOJO_SYSTEM_EMBEDDER_TEST_EMBEDDER_H_
#include "mojo/system/system_impl_export.h"
namespace mojo { namespace mojo {
namespace embedder { namespace embedder {
namespace test { namespace test {
...@@ -12,9 +14,7 @@ namespace test { ...@@ -12,9 +14,7 @@ namespace test {
// This shuts down the global, singleton instance. (Note: "Real" embedders are // This shuts down the global, singleton instance. (Note: "Real" embedders are
// not expected to ever shut down this instance. This |Shutdown()| function will // not expected to ever shut down this instance. This |Shutdown()| function will
// do more work to ensure that tests don't leak, etc.) // do more work to ensure that tests don't leak, etc.)
// TODO(vtl): Figure out the library/component/DLL/export situation for test MOJO_SYSTEM_IMPL_EXPORT void Shutdown();
// embedder stuff. For now, it's linked directly into the unit test binary.
void Shutdown();
} // namespace test } // namespace test
} // namespace embedder } // namespace embedder
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment