[ios] Place Infobar banner just under omnibox

Bug: 1152900
Change-Id: Id9b1db55a09487cf3e237d2d5de390c5afb9b5ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587388
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836376}

ios/chrome/browser/ui/infobars/coordinators/infobar_coordinator.mm

@@ -296,7 +296,7 @@
   UIView* omniboxView = omniboxGuide.owningView;
   CGRect omniboxFrame = [omniboxView convertRect:omniboxGuide.layoutFrame
                                           toView:omniboxView.window];
-  return CGRectGetMaxY(omniboxFrame) - kInfobarBannerOverlapWithOmnibox;
+  return CGRectGetMaxY(omniboxFrame);
 }
 
 - (UIView*)bannerView {

ios/chrome/browser/ui/infobars/infobar_constants.h

@@ -20,8 +20,4 @@ extern const NSTimeInterval kInfobarBannerDefaultPresentationDurationInSeconds;
 // banner will be presented for.
 extern const NSTimeInterval kInfobarBannerLongPresentationDurationInSeconds;
 
-// The overlap from the bottom of the omnibox NamedGuide for which the banner
-// should be laid out.
-extern const CGFloat kInfobarBannerOverlapWithOmnibox;
-
 #endif  // IOS_CHROME_BROWSER_UI_INFOBARS_INFOBAR_CONSTANTS_H_

ios/chrome/browser/ui/infobars/infobar_constants.mm

@@ -18,6 +18,3 @@ NSString* const kConfirmInfobarButton2AccessibilityIdentifier =
 
 const NSTimeInterval kInfobarBannerDefaultPresentationDurationInSeconds = 8.0;
 const NSTimeInterval kInfobarBannerLongPresentationDurationInSeconds = 15.0;
-
-// Banner View constant.
-const CGFloat kInfobarBannerOverlapWithOmnibox = 5.0;

ios/chrome/browser/ui/overlays/infobar_banner/infobar_banner_overlay_coordinator.mm

@@ -74,7 +74,7 @@
   UIView* owningView = omniboxGuide.owningView;
   CGRect omniboxFrame = [owningView convertRect:omniboxGuide.layoutFrame
                                          toView:owningView.window];
-  return CGRectGetMaxY(omniboxFrame) - kInfobarBannerOverlapWithOmnibox;
+  return CGRectGetMaxY(omniboxFrame);
 }
 
 - (UIView*)bannerView {