Commit 86451593 authored by Balazs Engedy's avatar Balazs Engedy Committed by Commit Bot

CM API: Move Mojo interface definition into Blink

Move components/password_manager/content/common/credential_manager.mojom
into third_party/WebKit/public/platform/modules/credentialmanager/.

This is preparation for letting WebKit/Source/modules/ talk to the
Credential Manager API implementation directly using Mojo, instead of
needing to go through components/password_manager/content/renderer.

Bug: 740081
Change-Id: I5b59ac13fc088c0e6482fb2bfd5bd9dbb73b084b
Reviewed-on: https://chromium-review.googlesource.com/563407
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: default avatarMike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485259}
parent 1ab1bcf7
...@@ -4593,7 +4593,6 @@ static_library("test_support_ui") { ...@@ -4593,7 +4593,6 @@ static_library("test_support_ui") {
deps += [ deps += [
"//components/metrics:test_support", "//components/metrics:test_support",
"//components/password_manager/content/common:mojo_interfaces",
"//components/password_manager/core/browser:test_support", "//components/password_manager/core/browser:test_support",
"//components/translate/content/common", "//components/translate/content/common",
"//skia", "//skia",
......
...@@ -233,7 +233,6 @@ static_library("common") { ...@@ -233,7 +233,6 @@ static_library("common") {
"//components/ntp_tiles", "//components/ntp_tiles",
"//components/offline_pages/core:switches", "//components/offline_pages/core:switches",
"//components/omnibox/common", "//components/omnibox/common",
"//components/password_manager/content/common:mojo_interfaces",
"//components/password_manager/core/common", "//components/password_manager/core/common",
"//components/policy:generated", "//components/policy:generated",
"//components/policy/core/common", "//components/policy/core/common",
......
...@@ -24,7 +24,6 @@ static_library("browser") { ...@@ -24,7 +24,6 @@ static_library("browser") {
"//components/autofill/content/common:mojo_interfaces", "//components/autofill/content/common:mojo_interfaces",
"//components/autofill/core/common", "//components/autofill/core/common",
"//components/keyed_service/content", "//components/keyed_service/content",
"//components/password_manager/content/common:mojo_interfaces",
"//components/password_manager/core/browser", "//components/password_manager/core/browser",
"//components/password_manager/core/common", "//components/password_manager/core/common",
"//components/prefs", "//components/prefs",
......
...@@ -10,7 +10,6 @@ ...@@ -10,7 +10,6 @@
#include "base/callback.h" #include "base/callback.h"
#include "base/macros.h" #include "base/macros.h"
#include "base/memory/weak_ptr.h" #include "base/memory/weak_ptr.h"
#include "components/password_manager/content/common/credential_manager.mojom.h"
#include "components/password_manager/core/browser/credential_manager_password_form_manager.h" #include "components/password_manager/core/browser/credential_manager_password_form_manager.h"
#include "components/password_manager/core/browser/credential_manager_pending_prevent_silent_access_task.h" #include "components/password_manager/core/browser/credential_manager_pending_prevent_silent_access_task.h"
#include "components/password_manager/core/browser/credential_manager_pending_request_task.h" #include "components/password_manager/core/browser/credential_manager_pending_request_task.h"
...@@ -19,6 +18,7 @@ ...@@ -19,6 +18,7 @@
#include "components/prefs/pref_member.h" #include "components/prefs/pref_member.h"
#include "content/public/browser/web_contents_observer.h" #include "content/public/browser/web_contents_observer.h"
#include "mojo/public/cpp/bindings/associated_binding.h" #include "mojo/public/cpp/bindings/associated_binding.h"
#include "third_party/WebKit/public/platform/modules/credentialmanager/credential_manager.mojom.h"
class GURL; class GURL;
......
# Copyright 2016 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import("//mojo/public/tools/bindings/mojom.gni")
mojom("mojo_interfaces") {
sources = [
"credential_manager.mojom",
]
public_deps = [
"//url/mojo:url_mojom_gurl",
"//url/mojo:url_mojom_origin",
]
}
per-file *.mojom=set noparent
per-file *.mojom=file://ipc/SECURITY_OWNERS
per-file *_struct_traits*.*=set noparent per-file *_struct_traits*.*=set noparent
per-file *_struct_traits*.*=file://ipc/SECURITY_OWNERS per-file *_struct_traits*.*=file://ipc/SECURITY_OWNERS
per-file *.typemap=set noparent per-file *.typemap=set noparent
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be # Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file. # found in the LICENSE file.
mojom = "//components/password_manager/content/common/credential_manager.mojom" mojom = "//third_party/WebKit/public/platform/modules/credentialmanager/credential_manager.mojom"
public_headers = public_headers =
[ "//components/password_manager/core/common/credential_manager_types.h" ] [ "//components/password_manager/core/common/credential_manager_types.h" ]
traits_headers = [ "//components/password_manager/content/common/credential_manager_struct_traits.h" ] traits_headers = [ "//components/password_manager/content/common/credential_manager_struct_traits.h" ]
......
...@@ -6,9 +6,9 @@ ...@@ -6,9 +6,9 @@
#define COMPONENTS_PASSWORD_MANAGER_CONTENT_COMMON_CREDENTIAL_MANAGER_STRUCT_TRAITS_H_ #define COMPONENTS_PASSWORD_MANAGER_CONTENT_COMMON_CREDENTIAL_MANAGER_STRUCT_TRAITS_H_
#include "base/strings/string16.h" #include "base/strings/string16.h"
#include "components/password_manager/content/common/credential_manager.mojom.h"
#include "components/password_manager/core/common/credential_manager_types.h" #include "components/password_manager/core/common/credential_manager_types.h"
#include "mojo/public/cpp/bindings/struct_traits.h" #include "mojo/public/cpp/bindings/struct_traits.h"
#include "third_party/WebKit/public/platform/modules/credentialmanager/credential_manager.mojom.h"
namespace mojo { namespace mojo {
......
...@@ -10,7 +10,6 @@ static_library("renderer") { ...@@ -10,7 +10,6 @@ static_library("renderer") {
deps = [ deps = [
"//base", "//base",
"//components/password_manager/content/common:mojo_interfaces",
"//components/password_manager/core/common", "//components/password_manager/core/common",
"//components/strings", "//components/strings",
"//content/public/common", "//content/public/common",
......
...@@ -7,12 +7,12 @@ ...@@ -7,12 +7,12 @@
#include "base/compiler_specific.h" #include "base/compiler_specific.h"
#include "base/macros.h" #include "base/macros.h"
#include "components/password_manager/content/common/credential_manager.mojom.h"
#include "content/public/renderer/render_view_observer.h" #include "content/public/renderer/render_view_observer.h"
#include "third_party/WebKit/public/platform/WebCredentialManagerClient.h" #include "third_party/WebKit/public/platform/WebCredentialManagerClient.h"
#include "third_party/WebKit/public/platform/WebCredentialManagerError.h" #include "third_party/WebKit/public/platform/WebCredentialManagerError.h"
#include "third_party/WebKit/public/platform/WebCredentialMediationRequirement.h" #include "third_party/WebKit/public/platform/WebCredentialMediationRequirement.h"
#include "third_party/WebKit/public/platform/WebVector.h" #include "third_party/WebKit/public/platform/WebVector.h"
#include "third_party/WebKit/public/platform/modules/credentialmanager/credential_manager.mojom.h"
namespace blink { namespace blink {
class WebCredential; class WebCredential;
......
...@@ -724,6 +724,7 @@ mojom("mojo_bindings") { ...@@ -724,6 +724,7 @@ mojom("mojo_bindings") {
"platform/modules/bluetooth/web_bluetooth.mojom", "platform/modules/bluetooth/web_bluetooth.mojom",
"platform/modules/broadcastchannel/broadcast_channel.mojom", "platform/modules/broadcastchannel/broadcast_channel.mojom",
"platform/modules/budget_service/budget_service.mojom", "platform/modules/budget_service/budget_service.mojom",
"platform/modules/credentialmanager/credential_manager.mojom",
"platform/modules/fetch/fetch_api_request.mojom", "platform/modules/fetch/fetch_api_request.mojom",
"platform/modules/hyphenation/hyphenation.mojom", "platform/modules/hyphenation/hyphenation.mojom",
"platform/modules/keyboard_lock/keyboard_lock.mojom", "platform/modules/keyboard_lock/keyboard_lock.mojom",
......
engedy@chromium.org
mkwst@chromium.org
vasilii@chromium.org
per-file *.mojom=set noparent
per-file *.mojom=file://ipc/SECURITY_OWNERS
# COMPONENT: Blink>SecurityFeature>CredentialManagement
# TEAM: identity-dev@chromium.org
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment