Commit 866e9910 authored by Saman Sami's avatar Saman Sami Committed by Commit Bot

viz: Move StructTraits and typemap files from public/interfaces to public/cpp

Per discussion with rockot and others, StructTraits and typemap files are
language specific and should live in public/cpp instead of public/interfaces.

Change-Id: Id7fb1f5e733f6b2913f0da2332062c72f386ebab
Reviewed-on: https://chromium-review.googlesource.com/596751
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: default avatarKen Rockot <rockot@chromium.org>
Reviewed-by: default avatarTom Sepez <tsepez@chromium.org>
Reviewed-by: default avatarFady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491770}
parent dbafed5c
...@@ -36,7 +36,7 @@ _typemap_imports = [ ...@@ -36,7 +36,7 @@ _typemap_imports = [
"//services/ui/public/interfaces/cursor/typemaps.gni", "//services/ui/public/interfaces/cursor/typemaps.gni",
"//services/ui/public/interfaces/ime/typemaps.gni", "//services/ui/public/interfaces/ime/typemaps.gni",
"//services/viz/compositing/privileged/interfaces/typemaps.gni", "//services/viz/compositing/privileged/interfaces/typemaps.gni",
"//services/viz/public/interfaces/compositing/typemaps.gni", "//services/viz/public/cpp/compositing/typemaps.gni",
"//skia/public/interfaces/typemaps.gni", "//skia/public/interfaces/typemaps.gni",
"//third_party/WebKit/public/public_typemaps.gni", "//third_party/WebKit/public/public_typemaps.gni",
"//ui/base/mojo/typemaps.gni", "//ui/base/mojo/typemaps.gni",
......
...@@ -29,7 +29,7 @@ service_test("services_unittests") { ...@@ -29,7 +29,7 @@ service_test("services_unittests") {
"//services/resource_coordinator:tests", "//services/resource_coordinator:tests",
"//services/shape_detection:tests", "//services/shape_detection:tests",
"//services/viz/compositing/privileged/interfaces:tests", "//services/viz/compositing/privileged/interfaces:tests",
"//services/viz/public/interfaces/compositing:tests", "//services/viz/public/cpp/compositing:tests",
] ]
} }
......
include_rules = [ include_rules = [
"+components/viz", "+components/viz",
"+ui/gfx/mojo",
] ]
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
// found in the LICENSE file. // found in the LICENSE file.
#include "services/viz/compositing/privileged/interfaces/renderer_settings_struct_traits.h" #include "services/viz/compositing/privileged/interfaces/renderer_settings_struct_traits.h"
#include "services/viz/public/interfaces/compositing/resource_settings_struct_traits.h" #include "services/viz/public/cpp/compositing/resource_settings_struct_traits.h"
namespace mojo { namespace mojo {
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
#include "components/viz/common/resources/resource_settings.h" #include "components/viz/common/resources/resource_settings.h"
#include "mojo/public/cpp/bindings/binding_set.h" #include "mojo/public/cpp/bindings/binding_set.h"
#include "services/viz/compositing/privileged/interfaces/renderer_settings_struct_traits.h" #include "services/viz/compositing/privileged/interfaces/renderer_settings_struct_traits.h"
#include "services/viz/public/interfaces/compositing/resource_settings_struct_traits.h" #include "services/viz/public/cpp/compositing/resource_settings_struct_traits.h"
#include "testing/gtest/include/gtest/gtest.h" #include "testing/gtest/include/gtest/gtest.h"
namespace viz { namespace viz {
......
# Copyright 2017 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
source_set("tests") {
testonly = true
sources = [
"struct_traits_unittest.cc",
]
deps = [
"//base/test:test_support",
"//components/viz/common:common",
"//media/capture/mojo:capture_types",
"//services/service_manager/public/cpp",
"//services/service_manager/public/cpp:service_test_support",
"//services/viz/public/interfaces/compositing",
"//testing/gtest",
"//ui/gfx:test_support",
]
}
include_rules = [
"+ui/gfx/mojo",
]
per-file *_struct_traits*.*=set noparent
per-file *_struct_traits*.*=file://ipc/SECURITY_OWNERS
per-file *.typemap=set noparent
per-file *.typemap=file://ipc/SECURITY_OWNERS
...@@ -4,14 +4,14 @@ ...@@ -4,14 +4,14 @@
mojom = "//services/viz/public/interfaces/compositing/resource_settings.mojom" mojom = "//services/viz/public/interfaces/compositing/resource_settings.mojom"
public_headers = [ "//components/viz/common/resources/resource_settings.h" ] public_headers = [ "//components/viz/common/resources/resource_settings.h" ]
traits_headers = [ "//services/viz/public/interfaces/compositing/resource_settings_struct_traits.h" ] traits_headers = [ "//services/viz/public/cpp/compositing/resource_settings_struct_traits.h" ]
deps = [ deps = [
"//cc", "//cc",
"//mojo/common:struct_traits", "//mojo/common:struct_traits",
"//ui/gfx/mojo", "//ui/gfx/mojo",
] ]
sources = [ sources = [
"resource_settings_struct_traits.cc", "//services/viz/public/cpp/compositing/resource_settings_struct_traits.cc",
] ]
type_mappings = [ type_mappings = [
"viz.mojom.BufferToTextureTargetKey=std::pair<gfx::BufferUsage, gfx::BufferFormat>", "viz.mojom.BufferToTextureTargetKey=std::pair<gfx::BufferUsage, gfx::BufferFormat>",
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#include "services/viz/public/interfaces/compositing/resource_settings_struct_traits.h" #include "services/viz/public/cpp/compositing/resource_settings_struct_traits.h"
namespace mojo { namespace mojo {
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
#include "base/message_loop/message_loop.h" #include "base/message_loop/message_loop.h"
#include "components/viz/common/resources/resource_settings.h" #include "components/viz/common/resources/resource_settings.h"
#include "mojo/public/cpp/bindings/binding_set.h" #include "mojo/public/cpp/bindings/binding_set.h"
#include "services/viz/public/interfaces/compositing/resource_settings_struct_traits.h" #include "services/viz/public/cpp/compositing/resource_settings_struct_traits.h"
#include "testing/gtest/include/gtest/gtest.h" #include "testing/gtest/include/gtest/gtest.h"
namespace viz { namespace viz {
......
...@@ -2,5 +2,4 @@ ...@@ -2,5 +2,4 @@
# Use of this source code is governed by a BSD-style license that can be # Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file. # found in the LICENSE file.
typemaps = typemaps = [ "//services/viz/public/cpp/compositing/resource_settings.typemap" ]
[ "//services/viz/public/interfaces/compositing/resource_settings.typemap" ]
...@@ -16,22 +16,3 @@ mojom("compositing") { ...@@ -16,22 +16,3 @@ mojom("compositing") {
"//ui/gfx/mojo", "//ui/gfx/mojo",
] ]
} }
source_set("tests") {
testonly = true
sources = [
"struct_traits_unittest.cc",
]
deps = [
":compositing",
"//base/test:test_support",
"//components/viz/common:common",
"//media/capture/mojo:capture_types",
"//services/service_manager/public/cpp",
"//services/service_manager/public/cpp:service_test_support",
"//testing/gtest",
"//ui/gfx:test_support",
]
}
per-file *.mojom=set noparent per-file *.mojom=set noparent
per-file *.mojom=file://ipc/SECURITY_OWNERS per-file *.mojom=file://ipc/SECURITY_OWNERS
per-file *_struct_traits*.*=set noparent
per-file *_struct_traits*.*=file://ipc/SECURITY_OWNERS
per-file *.typemap=set noparent
per-file *.typemap=file://ipc/SECURITY_OWNERS
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment