Skip to content

GitLab

T
tangled
Commit 86a68788 authored by Denis Kuznetsov's avatar Denis Kuznetsov Committed by Commit Bot
Browse files
Options

Remove unused clearOldAttempts call 

After deprecation of gaia_auth extension in
 https://codereview.chromium.org/2686683002, there is no more
listener of a clearOldAttempts message from GAIA in chrome codebase.

So in current code the only effect of this message is warning in JS
console triggered by authenticator.js:637 during tests.

Change-Id: I1d734b99c44c8f48d41dac737325cb4e859aa057
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534166Reviewed-by: default avatarRoger Tawa <rogerta@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644747}
parent 122f7624
Show whitespace changes
Inline Side-by-side
Showing with 1 addition and 21 deletions
google_apis/test/embedded_setup_chromeos.html
View file @ 86a68788
...@@ -29,8 +29,6 @@ gaia.chromeOSLogin.registerHtml5Listener = function() { ...@@ -29,8 +29,6 @@ gaia.chromeOSLogin.registerHtml5Listener = function() {
gaia.chromeOSLogin.initialized_ = true; gaia.chromeOSLogin.initialized_ = true;
goFirstPage(); goFirstPage();
} }
// Repeat clearOldAttempts as soon as we got parent.
gaia.chromeOSLogin.clearOldAttempts();
} }
}; };
window.addEventListener('message', onMessage); window.addEventListener('message', onMessage);
...@@ -40,14 +38,6 @@ gaia.chromeOSLogin.registerHtml5Listener = function() { ...@@ -40,14 +38,6 @@ gaia.chromeOSLogin.registerHtml5Listener = function() {
call: {method: 'initialize', requestedVersion: 1}}, '/'); call: {method: 'initialize', requestedVersion: 1}}, '/');
} }
gaia.chromeOSLogin.clearOldAttempts = function() {
var msg = {
'method': 'clearOldAttempts'
};
gaia.chromeOSLogin.parent_webview_.postMessage(msg,
gaia.chromeOSLogin.parent_webview_url_);
};
gaia.chromeOSLogin.attemptLogin = function(email, password) { gaia.chromeOSLogin.attemptLogin = function(email, password) {
var msg = { var msg = {
'method': 'attemptLogin', 'method': 'attemptLogin',
......
google_apis/test/service_login.html
View file @ 86a68788
...@@ -17,13 +17,6 @@ gaia.chromeOSLogin.attemptLogin = function(email, password, attemptToken) { ...@@ -17,13 +17,6 @@ gaia.chromeOSLogin.attemptLogin = function(email, password, attemptToken) {
window.parent.postMessage(msg, gaia.chromeOSLogin.parent_page_url_); window.parent.postMessage(msg, gaia.chromeOSLogin.parent_page_url_);
}; };
gaia.chromeOSLogin.clearOldAttempts = function() {
var msg = {
'method': 'clearOldAttempts'
};
window.parent.postMessage(msg, gaia.chromeOSLogin.parent_page_url_);
};
gaia.chromeOSLogin.onAttemptedLogin = function(emailFormElement, gaia.chromeOSLogin.onAttemptedLogin = function(emailFormElement,
passwordFormElement, passwordFormElement,
continueUrlElement) { continueUrlElement) {
...@@ -56,12 +49,9 @@ function onAuthError() { ...@@ -56,12 +49,9 @@ function onAuthError() {
} }
} }
function onLoad() {
gaia.chromeOSLogin.clearOldAttempts();
}
</SCRIPT> </SCRIPT>
</HEAD> </HEAD>
<BODY onload='onLoad();'> <BODY>
Local Auth Server:<BR> Local Auth Server:<BR>
<FORM action='/ServiceLoginAuth' method=POST onsubmit='submitAndGo()'> <FORM action='/ServiceLoginAuth' method=POST onsubmit='submitAndGo()'>
<INPUT TYPE=text id="Email" name="Email"> <INPUT TYPE=text id="Email" name="Email">
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment