Commit 86c326a7 authored by Alex Clarke's avatar Alex Clarke Committed by Commit Bot

Fix fast/block/float/4145535Crash.html with scheduler change

We wish to prioritize loading and compositing tasks until first contentful
paint. This changes the ordering of
LocalFrameView::UpdatePluginsTimerFired  which breaks (or makes flaky)
some web_tests, typically the following console log goes missing:

  CONSOLE MESSAGE: Blink Test Plugin: initializing

This patch fixes this by ensuring LocalFrameView::UpdatePluginsTimerFired
runs in FIFO order with loading tasks.

The spec doesn't seem to specify which task source should be used so I
believe we're free to make this change.

Bug: 971191
Change-Id: Ib62fafd7cf1f86835a7c5b749fa0639f884e7089
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795790Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
Reviewed-by: default avatarSami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696894}
parent 21b25353
...@@ -242,7 +242,8 @@ LocalFrameView::LocalFrameView(LocalFrame& frame, IntRect frame_rect) ...@@ -242,7 +242,8 @@ LocalFrameView::LocalFrameView(LocalFrame& frame, IntRect frame_rect)
layout_count_for_testing_(0), layout_count_for_testing_(0),
lifecycle_update_count_for_testing_(0), lifecycle_update_count_for_testing_(0),
nested_layout_count_(0), nested_layout_count_(0),
update_plugins_timer_(frame.GetTaskRunner(TaskType::kInternalDefault), // We want plugin updates to happen in FIFO order with loading tasks.
update_plugins_timer_(frame.GetTaskRunner(TaskType::kInternalLoading),
this, this,
&LocalFrameView::UpdatePluginsTimerFired), &LocalFrameView::UpdatePluginsTimerFired),
first_layout_(true), first_layout_(true),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment