Commit 87190165 authored by dalecurtis@google.com's avatar dalecurtis@google.com

Put browser side mixing back behind a flag.

BUG=140247
TEST=Tried --enable-audio-mixer flag and observed regression.

Review URL: https://chromiumcodereview.appspot.com/10834159

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149906 0039d316-1c4b-4281-b951-d872f2087c98
parent ac86e2a5
...@@ -142,15 +142,13 @@ AudioOutputStream* AudioManagerBase::MakeAudioOutputStreamProxy( ...@@ -142,15 +142,13 @@ AudioOutputStream* AudioManagerBase::MakeAudioOutputStreamProxy(
if (!dispatcher) { if (!dispatcher) {
base::TimeDelta close_delay = base::TimeDelta close_delay =
base::TimeDelta::FromSeconds(kStreamCloseDelaySeconds); base::TimeDelta::FromSeconds(kStreamCloseDelaySeconds);
// TODO(dalecurtis): Temporarily disable the mixer for non-Windows/Mac platforms
// until a fix for http://crbug.com/138098 can be found.
#if defined(OS_WIN) || defined(OS_MACOSX)
const CommandLine* cmd_line = CommandLine::ForCurrentProcess(); const CommandLine* cmd_line = CommandLine::ForCurrentProcess();
if (!cmd_line->HasSwitch(switches::kDisableAudioMixer)) { // TODO(dalecurtis): Browser side mixing has a couple issues that must be
// fixed before it can be turned on by default: http://crbug.com/138098 and
// http://crbug.com/140247
if (cmd_line->HasSwitch(switches::kEnableAudioMixer)) {
dispatcher = new AudioOutputMixer(this, params, close_delay); dispatcher = new AudioOutputMixer(this, params, close_delay);
} else } else {
#endif
{
dispatcher = new AudioOutputDispatcherImpl(this, params, close_delay); dispatcher = new AudioOutputDispatcherImpl(this, params, close_delay);
} }
} }
......
...@@ -35,7 +35,7 @@ const char kEnableExclusiveAudio[] = "enable-exclusive-audio"; ...@@ -35,7 +35,7 @@ const char kEnableExclusiveAudio[] = "enable-exclusive-audio";
// Set number of threads to use for video decoding. // Set number of threads to use for video decoding.
const char kVideoThreads[] = "video-threads"; const char kVideoThreads[] = "video-threads";
// Disables browser-side audio mixer. // Enable browser-side audio mixer.
const char kDisableAudioMixer[] = "disable-audio-mixer"; const char kEnableAudioMixer[] = "enable-audio-mixer";
} // namespace switches } // namespace switches
...@@ -31,7 +31,7 @@ MEDIA_EXPORT extern const char kEnableExclusiveAudio[]; ...@@ -31,7 +31,7 @@ MEDIA_EXPORT extern const char kEnableExclusiveAudio[];
MEDIA_EXPORT extern const char kVideoThreads[]; MEDIA_EXPORT extern const char kVideoThreads[];
MEDIA_EXPORT extern const char kDisableAudioMixer[]; MEDIA_EXPORT extern const char kEnableAudioMixer[];
} // namespace switches } // namespace switches
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment