Skip to content

GitLab

T
tangled
Commit 8764d28d authored by David Bertoni's avatar David Bertoni Committed by Commit Bot
Browse files
Options

[Extensions] Refactor a Cookies API test. 

This CL splits an existing Cookies API test into two separate tests,
which makes the bulk of the original test compatible with a Service
Worker-based extension. It also adds that test to the other Cookies
API tests that are run for both event page-based and Service Worker-
based extensions.

Bug: 1093066
Change-Id: If4ee1326a73a1c485d126bab54b2516f2892bc4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314876
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791356}
parent 9982e8f3
Hide whitespace changes
Inline Side-by-side
Showing with 583 additions and 549 deletions
chrome/browser/extensions/api/cookies/cookies_apitest.cc
View file @ 8764d28d
...@@ -13,16 +13,10 @@ namespace extensions { ...@@ -13,16 +13,10 @@ namespace extensions {
using ContextType = ExtensionApiTest::ContextType; using ContextType = ExtensionApiTest::ContextType;
// TODO(crbug.com/1093066): This test uses the DOM to set and // This test cannot be run by a Service Worked-based extension
// check cookies for one test. Figure out how to isolate that // because it uses the Document object.
// test and adapt the rest of it for a SW-based extension. IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ReadFromDocument) {
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Cookies) { ASSERT_TRUE(RunExtensionTest("cookies/read_from_doc")) << message_;
ASSERT_TRUE(RunExtensionTestWithArg(
"cookies/api",
net::cookie_util::IsCookiesWithoutSameSiteMustBeSecureEnabled()
? "true"
: "false"))
<< message_;
} }
class CookiesApiTest : public ExtensionApiTest, class CookiesApiTest : public ExtensionApiTest,
...@@ -45,6 +39,16 @@ class CookiesApiTest : public ExtensionApiTest, ...@@ -45,6 +39,16 @@ class CookiesApiTest : public ExtensionApiTest,
return RunTestWithFlags(extension_name, kFlagEnableIncognito); return RunTestWithFlags(extension_name, kFlagEnableIncognito);
} }
bool RunTestWithArg(const std::string& extension_name,
const char* custom_arg) {
int browser_test_flags = kFlagNone;
if (GetParam() == ContextType::kServiceWorker)
browser_test_flags |= kFlagRunAsServiceWorkerBasedExtension;
return RunExtensionTestWithFlagsAndArg(extension_name, custom_arg,
browser_test_flags, kFlagNone);
}
bool RunTestWithFlags(const std::string& extension_name, bool RunTestWithFlags(const std::string& extension_name,
int browser_test_flags) { int browser_test_flags) {
if (GetParam() == ContextType::kServiceWorker) if (GetParam() == ContextType::kServiceWorker)
...@@ -64,6 +68,15 @@ INSTANTIATE_TEST_SUITE_P(ServiceWorker, ...@@ -64,6 +68,15 @@ INSTANTIATE_TEST_SUITE_P(ServiceWorker,
CookiesApiTest, CookiesApiTest,
::testing::Values(ContextType::kServiceWorker)); ::testing::Values(ContextType::kServiceWorker));
IN_PROC_BROWSER_TEST_P(CookiesApiTest, Cookies) {
ASSERT_TRUE(RunTestWithArg(
"cookies/api",
net::cookie_util::IsCookiesWithoutSameSiteMustBeSecureEnabled()
? "true"
: "false"))
<< message_;
}
IN_PROC_BROWSER_TEST_P(CookiesApiTest, CookiesEvents) { IN_PROC_BROWSER_TEST_P(CookiesApiTest, CookiesEvents) {
ASSERT_TRUE(RunTest("cookies/events")) << message_; ASSERT_TRUE(RunTest("cookies/events")) << message_;
} }
......
chrome/test/data/extensions/api_test/cookies/api/background.js
View file @ 8764d28d
...@@ -2,17 +2,505 @@ ...@@ -2,17 +2,505 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Ensure we started with an empty profile. var TEST_DOMAIN = 'cookies.com';
chrome.test.assertEq(document.cookie, ""); var TEST_PATH = '/auth';
var TEST_HOST = 'www.chrome_extensions.' + TEST_DOMAIN;
// Set some cookies with a few different modifiers. var TEST_URL = 'http://' + TEST_HOST + '/foobar.html?arg=toolbar&param=true';
var expire = new Date(); var TEST_URL_HTTPS = 'https://' + TEST_HOST + '/foobar.html?arg=toolbar&param=true';
expire.setDate(expire.getDate() + 1); // tomorrow var TEST_URL2 = 'http://chromium.' + TEST_DOMAIN + '/index.html';
document.cookie = "a=1"; var TEST_URL3 = 'https://' + TEST_HOST + '/content.html';
document.cookie = "b=2; path=/; domain=" + location.host; var TEST_URL4 = 'https://' + TEST_HOST + TEST_PATH + '/content.html';
document.cookie = "c=3; path=/; expires=" + expire + var TEST_URL5 = 'http://' + TEST_HOST + TEST_PATH + '/content.html';
"; domain=" + location.host; var TEST_EXPIRATION_DATE = 12345678900;
var TEST_ODD_DOMAIN_HOST_ONLY = 'strange stuff!!.com';
// Open a tab. This doesn't really prove we're writing to disk, but it is var TEST_ODD_DOMAIN = '.' + TEST_ODD_DOMAIN_HOST_ONLY;
// difficult to prove that without shutting down the process. var TEST_ODD_PATH = '/hello = world';
chrome.tabs.create({url: "tab.html"}); var TEST_ODD_URL = 'http://' + TEST_ODD_DOMAIN_HOST_ONLY + TEST_ODD_PATH + '/index.html';
var TEST_UNPERMITTED_URL = 'http://illegal.' + TEST_DOMAIN + '/';
var TEST_BASIC_COOKIE = {
url: TEST_URL,
name: 'api_test_cookie',
value: 'helloworld'
};
var TEST_DOMAIN_COOKIE = {
url: TEST_URL,
name: 'TEST_domain',
value: '32849395FFDSAA**##@@@',
domain: TEST_DOMAIN,
expirationDate: TEST_EXPIRATION_DATE
};
var TEST_SECURE_COOKIE = {
url: TEST_URL4,
name: 'SECRETCOOKIE',
value: 'foobar_password',
secure: true,
httpOnly: true
};
var TEST_BASIC_EXPIRED_COOKIE = {
url: TEST_BASIC_COOKIE.url,
name: TEST_BASIC_COOKIE.name,
value: TEST_BASIC_COOKIE.value,
expirationDate: 0
};
function expectValidCookie(cookie) {
chrome.test.assertTrue(cookie != null, 'Expected cookie not set.');
}
function expectNullCookie(cookie) {
chrome.test.assertEq(null, cookie);
}
function expectUndefinedCookie(cookie) {
chrome.test.assertEq(undefined, cookie);
}
function removeTestCookies() {
chrome.cookies.remove(
{url: TEST_URL, name: TEST_BASIC_COOKIE.name});
chrome.cookies.remove(
{url: TEST_URL, name: TEST_DOMAIN_COOKIE.name});
chrome.cookies.remove(
{url: TEST_URL4, name: TEST_SECURE_COOKIE.name});
chrome.cookies.remove({url: TEST_URL, name: 'abcd'});
chrome.cookies.remove({url: TEST_URL, name: 'AA'});
chrome.cookies.remove({url: TEST_URL_HTTPS, name: 'A'});
chrome.cookies.remove({url: TEST_URL, name: 'AI'});
chrome.cookies.remove({url: TEST_URL, name: 'B'});
chrome.cookies.remove({url: TEST_URL, name: 'C'});
chrome.cookies.remove({url: TEST_URL, name: 'D'});
chrome.cookies.remove({url: TEST_ODD_URL, name: 'abcd'});
}
var pass = chrome.test.callbackPass;
var fail = chrome.test.callbackFail;
chrome.test.runTests([
function invalidScheme() {
// Invalid schemes don't work with the cookie API.
var ourUrl = chrome.extension.getURL('background.js');
chrome.cookies.get(
{url: ourUrl, name: 'a'},
chrome.test.callbackFail(
'No host permissions for cookies at url: "' +
ourUrl + '".'));
},
function getBasicCookie() {
removeTestCookies();
chrome.cookies.set(TEST_BASIC_COOKIE, pass(function () {
// Domain doesn't match.
chrome.cookies.get(
{url: TEST_URL2, name: TEST_BASIC_COOKIE.name},
pass(expectNullCookie));
// URL invalid.
chrome.cookies.get(
{url: 'invalid url', name: TEST_BASIC_COOKIE.name},
fail('Invalid url: "invalid url".'));
// URL lacking permissions.
chrome.cookies.get(
{url: TEST_UNPERMITTED_URL, name: TEST_BASIC_COOKIE.name},
fail('No host permissions for cookies at url: "' +
TEST_UNPERMITTED_URL + '".'));
// Store ID invalid.
chrome.cookies.get({
url: TEST_BASIC_COOKIE.url,
name: TEST_BASIC_COOKIE.name,
storeId: 'invalid'
}, fail('Invalid cookie store id: "invalid".'));
chrome.cookies.get(
{url: TEST_BASIC_COOKIE.url, name: TEST_BASIC_COOKIE.name},
pass(function(cookie) {
expectValidCookie(cookie);
chrome.test.assertEq(TEST_BASIC_COOKIE.name, cookie.name);
chrome.test.assertEq(TEST_BASIC_COOKIE.value, cookie.value);
chrome.test.assertEq(TEST_HOST, cookie.domain);
chrome.test.assertEq(true, cookie.hostOnly);
chrome.test.assertEq('/', cookie.path);
chrome.test.assertEq(false, cookie.secure);
chrome.test.assertEq(false, cookie.httpOnly);
chrome.test.assertEq('unspecified', cookie.sameSite);
chrome.test.assertEq(true, cookie.session);
chrome.test.assertTrue(typeof cookie.expirationDate === 'undefined',
'Session cookie should not have expirationDate property.');
chrome.test.assertTrue(typeof cookie.storeId !== 'undefined',
'Cookie store ID not provided.');
}));
}));
},
function getDomainCookie() {
removeTestCookies();
chrome.cookies.set(TEST_DOMAIN_COOKIE, pass(function () {
chrome.cookies.get(
{url: TEST_URL2, name: TEST_DOMAIN_COOKIE.name},
pass(function(cookie) {
expectValidCookie(cookie);
chrome.test.assertEq(TEST_DOMAIN_COOKIE.name, cookie.name);
chrome.test.assertEq(TEST_DOMAIN_COOKIE.value, cookie.value);
chrome.test.assertEq('.' + TEST_DOMAIN, cookie.domain);
chrome.test.assertEq(false, cookie.hostOnly);
chrome.test.assertEq('/', cookie.path);
chrome.test.assertEq(false, cookie.secure);
chrome.test.assertEq(false, cookie.httpOnly);
chrome.test.assertEq('unspecified', cookie.sameSite);
chrome.test.assertEq(false, cookie.session);
chrome.test.assertEq(TEST_EXPIRATION_DATE, cookie.expirationDate);
}));
}));
},
function getSecureCookie() {
removeTestCookies();
chrome.cookies.set(TEST_SECURE_COOKIE, pass(function () {
// URL doesn't work because scheme isn't secure.
chrome.cookies.get(
{url: TEST_URL5, name: TEST_SECURE_COOKIE.name},
pass(expectNullCookie));
// Path doesn't match.
chrome.cookies.get(
{url: TEST_URL3, name: TEST_SECURE_COOKIE.name},
pass(expectNullCookie));
chrome.cookies.get(
{url: TEST_URL4, name: TEST_SECURE_COOKIE.name},
pass(function(cookie) {
expectValidCookie(cookie);
chrome.test.assertEq(TEST_SECURE_COOKIE.name, cookie.name);
chrome.test.assertEq(TEST_SECURE_COOKIE.value, cookie.value);
chrome.test.assertEq(TEST_HOST, cookie.domain);
chrome.test.assertEq(true, cookie.hostOnly);
chrome.test.assertEq(TEST_PATH, cookie.path);
chrome.test.assertEq(true, cookie.secure);
chrome.test.assertEq(true, cookie.httpOnly);
chrome.test.assertEq('unspecified', cookie.sameSite);
chrome.test.assertEq(true, cookie.session);
}));
}));
},
function setOddCookies() {
removeTestCookies();
// URL lacking permissions.
chrome.cookies.set(
{url: TEST_UNPERMITTED_URL, name: 'abcd', domain: TEST_DOMAIN},
fail('No host permissions for cookies at url: "' +
TEST_UNPERMITTED_URL + '".',
function () {
chrome.cookies.get({url: TEST_URL, name: 'abcd'},
pass(expectNullCookie));
}));
// Attribute values containing invalid characters are disallowed.
chrome.cookies.set({url: TEST_URL, name: 'abcd=efg'}, fail(
'Failed to parse or set cookie named "abcd=efg".',
function() {
chrome.cookies.get({url: TEST_URL, name: 'abcd'},
pass(expectNullCookie));
}));
chrome.cookies.set(
{url: TEST_URL, name: 'abcd', value: 'HI;LO'},
fail(
'Failed to parse or set cookie named "abcd".',
function () {
chrome.cookies.get({url: TEST_URL, name: 'abcd'},
pass(expectNullCookie));
}));
chrome.cookies.set(
{url: TEST_URL, name: 'abcd', domain: 'cookies.com\r'},
fail(
'Failed to parse or set cookie named "abcd".',
function () {
chrome.cookies.get({url: TEST_URL, name: 'abcd'},
pass(expectNullCookie));
}));
chrome.cookies.set(
{url: TEST_URL, name: 'abcd', domain: 'somedomain.com'},
fail(
'Failed to parse or set cookie named "abcd".',
function () {
chrome.cookies.get({url: TEST_URL, name: 'abcd'},
pass(expectNullCookie));
}));
chrome.cookies.set({
url: TEST_ODD_URL,
name: 'abcd',
domain: TEST_ODD_DOMAIN,
path: TEST_ODD_PATH
}, pass(function () {
chrome.cookies.get({url: TEST_ODD_URL, name: 'abcd'},
pass(function(cookie) {
expectValidCookie(cookie);
chrome.test.assertEq(TEST_ODD_DOMAIN, unescape(cookie.domain));
chrome.test.assertEq(TEST_ODD_PATH, unescape(cookie.path));
}));
}));
},
function setSameSiteCookies() {
removeTestCookies();
// Property is left out
chrome.cookies.set(
{url: TEST_URL, name: "AA", value: "1"},
pass(function () {
chrome.cookies.get({url: TEST_URL, name: "AA"}, pass(function (c) {
expectValidCookie(c);
chrome.test.assertEq('unspecified', c.sameSite);
}));
}));
// No same-site restriction
chrome.cookies.set(
{url: TEST_URL_HTTPS, name: "A", value: "1", sameSite: "no_restriction",
secure: true},
pass(function () {
chrome.cookies.get({url: TEST_URL_HTTPS, name: "A"}, pass(function (c) {
expectValidCookie(c);
chrome.test.assertEq("no_restriction", c.sameSite);
}));
}));
// Lax same-site restriction
chrome.cookies.set(
{url: TEST_URL, name: "B", value: "1", sameSite: "lax"},
pass(function () {
chrome.cookies.get({url: TEST_URL, name: "B"}, pass(function (c) {
expectValidCookie(c);
chrome.test.assertEq("lax", c.sameSite);
}));
}));
// Strict same-site restriction
chrome.cookies.set(
{url: TEST_URL, name: "C", value: "1", sameSite: "strict"},
pass(function () {
chrome.cookies.get({url: TEST_URL, name: "C"}, pass(function (c) {
expectValidCookie(c);
chrome.test.assertEq("strict", c.sameSite);
}));
}));
// Unspecified
chrome.cookies.set(
{url: TEST_URL, name: "D", value: "1", sameSite: "unspecified"},
pass(function () {
chrome.cookies.get({url: TEST_URL, name: "D"}, pass(function (c) {
expectValidCookie(c);
chrome.test.assertEq('unspecified', c.sameSite);
}));
}));
},
function setSameSiteCookiesInsecureNone() {
chrome.test.getConfig(config => {
// No same-site restriction but also not secure. This should succeed if
// and only if the feature requiring SameSite=none cookies to be secure
// cookies is disabled.
var sameSiteNoneRequiresSecure = config.customArg === 'true';
removeTestCookies();
chrome.cookies.set(
{url: TEST_URL, name: "AI", value: "1", sameSite: "no_restriction"},
setResult => {
if (sameSiteNoneRequiresSecure) {
chrome.test.assertLastError(
'Failed to parse or set cookie named "AI".');
chrome.test.assertEq(null, setResult);
chrome.test.succeed();
} else {
chrome.test.assertNoLastError();
chrome.cookies.get(
{url: TEST_URL_HTTPS, name: "AI"},
pass(function (c) {
expectValidCookie(c);
chrome.test.assertEq("no_restriction", c.sameSite);
}));
}
});
});
},
function setCookiesWithCallbacks() {
removeTestCookies();
// Basics.
chrome.cookies.set(
TEST_BASIC_COOKIE,
pass(function(cookie) {
expectValidCookie(cookie);
chrome.test.assertEq(TEST_BASIC_COOKIE.name, cookie.name);
chrome.test.assertEq(TEST_BASIC_COOKIE.value, cookie.value);
chrome.test.assertEq(TEST_HOST, cookie.domain);
chrome.test.assertEq(true, cookie.hostOnly);
chrome.test.assertEq('/', cookie.path);
chrome.test.assertEq(false, cookie.secure);
chrome.test.assertEq(false, cookie.httpOnly);
chrome.test.assertEq(true, cookie.session);
chrome.test.assertTrue(typeof cookie.expirationDate === 'undefined',
'Session cookie should not have expirationDate property.');
chrome.test.assertTrue(typeof cookie.storeId !== 'undefined',
'Cookie store ID not provided.');
}));
// Invalid values generate callback with no arguments, and error messages
chrome.cookies.set(
{url: TEST_UNPERMITTED_URL, name: 'abcd', domain: TEST_DOMAIN},
fail(
'No host permissions for cookies at url: "'
+ TEST_UNPERMITTED_URL + '".',
expectUndefinedCookie));
chrome.cookies.set(
{url: TEST_URL, name: 'abcd=efg'},
fail('Failed to parse or set cookie named "abcd=efg".',
expectUndefinedCookie));
chrome.cookies.set(
{url: TEST_URL, name: 'abcd', value: 'HI;LO'},
fail('Failed to parse or set cookie named "abcd".',
expectUndefinedCookie));
chrome.cookies.set(
{url: TEST_URL, name: 'abcd', domain: 'cookies.com\r'},
fail('Failed to parse or set cookie named "abcd".',
expectUndefinedCookie));
chrome.cookies.set(
{url: TEST_URL, name: 'abcd', domain: 'somedomain.com'},
fail('Failed to parse or set cookie named "abcd".',
expectUndefinedCookie));
// Expired cookies generate callback with "null" cookie
chrome.cookies.set(TEST_BASIC_EXPIRED_COOKIE, pass(expectUndefinedCookie));
// Odd (but valid!) URLs get callbacks too!
chrome.cookies.set({
url: TEST_ODD_URL,
name: 'abcd',
domain: TEST_ODD_DOMAIN,
path: TEST_ODD_PATH
}, pass(function(cookie) {
expectValidCookie(cookie);
chrome.test.assertEq(TEST_ODD_DOMAIN, unescape(cookie.domain));
chrome.test.assertEq(TEST_ODD_PATH, unescape(cookie.path));
}));
},
function removeCookie() {
removeTestCookies();
chrome.cookies.set(TEST_BASIC_COOKIE, pass(function () {
chrome.cookies.get(
{url: TEST_URL, name: TEST_BASIC_COOKIE.name},
pass(function (c) {
expectValidCookie(c);
// Removal with any domain-matching URL will do.
chrome.cookies.remove(
{url: TEST_URL4, name: TEST_BASIC_COOKIE.name},
pass(function () {
chrome.cookies.get(
{url: TEST_URL, name: TEST_BASIC_COOKIE.name},
pass(expectNullCookie));
}));
}));
}));
// Set with an expired date should also remove the cookie.
chrome.cookies.set(TEST_BASIC_COOKIE, pass(function () {
chrome.cookies.get(
{url: TEST_URL, name: TEST_BASIC_COOKIE.name},
pass(expectValidCookie));
chrome.cookies.set(TEST_BASIC_EXPIRED_COOKIE, pass(function () {
chrome.cookies.get(
{url: TEST_URL, name: TEST_BASIC_COOKIE.name},
pass(expectNullCookie));
}));
}));
// Removal with a disallowed URL shouldn't do anything.
chrome.cookies.set(TEST_DOMAIN_COOKIE, pass(function () {
chrome.cookies.get(
{url: TEST_URL2, name: TEST_DOMAIN_COOKIE.name},
pass(function (c) {
expectValidCookie(c);
chrome.cookies.remove(
{url: TEST_UNPERMITTED_URL, name: TEST_DOMAIN_COOKIE.name},
fail(
'No host permissions for cookies at url: "'
+ TEST_UNPERMITTED_URL + '".',
function () {
chrome.cookies.get(
{url: TEST_URL2, name: TEST_DOMAIN_COOKIE.name},
pass(expectValidCookie));
}));
}));
}));
},
function removeCookiesWithCallbacks() {
removeTestCookies();
chrome.cookies.set(TEST_BASIC_COOKIE, pass(function () {
chrome.cookies.get(
{url: TEST_URL, name: TEST_BASIC_COOKIE.name},
pass(expectValidCookie));
// Removal with any domain-matching URL will trigger callback with the
// removed cookie's "url" and "name" fields.
chrome.cookies.remove(
{url: TEST_URL4, name: TEST_BASIC_COOKIE.name},
pass(function(data) {
chrome.test.assertEq(TEST_URL4, data.url);
chrome.test.assertEq(TEST_BASIC_COOKIE.name, data.name);
chrome.test.assertTrue(typeof data.storeId !== 'undefined',
'Cookie store ID not provided.');
}));
}));
// Removal with a disallowed URL should trigger the callback with no
// arguments, and a set error message.
chrome.cookies.set(TEST_DOMAIN_COOKIE, pass(function () {
chrome.cookies.remove(
{url: TEST_UNPERMITTED_URL, name: TEST_DOMAIN_COOKIE.name},
fail(
'No host permissions for cookies at url: "'
+ TEST_UNPERMITTED_URL + '".',
expectUndefinedCookie));
}));
},
function getAllCookies() {
removeTestCookies();
chrome.cookies.getAll({}, pass(function(cookies) {
chrome.test.assertEq(0, cookies.length);
}));
chrome.cookies.set(TEST_BASIC_COOKIE, pass(function () {
chrome.cookies.set(TEST_SECURE_COOKIE, pass(function () {
chrome.cookies.getAll(
{domain: TEST_DOMAIN}, pass(function(cookies) {
chrome.test.assertEq(2, cookies.length);
chrome.test.assertEq(TEST_SECURE_COOKIE.name, cookies[0].name);
chrome.test.assertEq(TEST_BASIC_COOKIE.name, cookies[1].name);
}));
chrome.cookies.getAll({
name: TEST_BASIC_COOKIE.name
}, pass(function(cookies) {
chrome.test.assertEq(1, cookies.length);
chrome.test.assertEq(TEST_BASIC_COOKIE.name, cookies[0].name);
}));
chrome.cookies.getAll({
secure: true
}, pass(function(cookies) {
chrome.test.assertEq(1, cookies.length);
chrome.test.assertEq(TEST_SECURE_COOKIE.name, cookies[0].name);
}));
chrome.cookies.getAll({
url: 'invalid url'
}, fail('Invalid url: "invalid url".'));
chrome.cookies.getAll({
url: TEST_URL,
}, pass(function(cookies) {
chrome.test.assertEq(1, cookies.length);
chrome.test.assertEq(TEST_BASIC_COOKIE.name, cookies[0].name);
}));
}));
}));
},
function getAllCookieStores() {
removeTestCookies();
chrome.cookies.getAllCookieStores(
pass(function(cookieStores) {
chrome.test.assertEq(1, cookieStores.length);
chrome.cookies.set(TEST_BASIC_COOKIE, pass(function () {
chrome.cookies.get(
{url: TEST_URL, name: TEST_BASIC_COOKIE.name},
pass(function(cookie) {
chrome.test.assertEq(cookieStores[0].id, cookie.storeId);
}));
chrome.cookies.getAll(
{storeId: cookieStores[0].id},
pass(function(cookies) {
chrome.test.assertEq(1, cookies.length);
chrome.test.assertEq(TEST_BASIC_COOKIE.name, cookies[0].name);
}));
}));
}));
}
]);
chrome/test/data/extensions/api_test/cookies/api/manifest.json
View file @ 8764d28d
...@@ -4,11 +4,11 @@ ...@@ -4,11 +4,11 @@
"manifest_version": 2, "manifest_version": 2,
"description": "end-to-end browser test for chrome.experimental.cookies API", "description": "end-to-end browser test for chrome.experimental.cookies API",
"background": { "background": {
"scripts": ["background.js"] "scripts": ["background.js"],
"persistent": false
}, },
"permissions": [ "permissions": [
"cookies", "cookies",
"tabs",
"http://*.chrome_extensions.cookies.com/", "http://*.chrome_extensions.cookies.com/",
"http://chromium.cookies.com/", "http://chromium.cookies.com/",
"https://*.cookies.com/", "https://*.cookies.com/",
......
chrome/test/data/extensions/api_test/cookies/api/tab.js deleted 100644 → 0
View file @ 9982e8f3
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
var TEST_DOMAIN = 'cookies.com';
var TEST_PATH = '/auth';
var TEST_HOST = 'www.chrome_extensions.' + TEST_DOMAIN;
var TEST_URL = 'http://' + TEST_HOST + '/foobar.html?arg=toolbar&param=true';
var TEST_URL_HTTPS = 'https://' + TEST_HOST + '/foobar.html?arg=toolbar&param=true';
var TEST_URL2 = 'http://chromium.' + TEST_DOMAIN + '/index.html';
var TEST_URL3 = 'https://' + TEST_HOST + '/content.html';
var TEST_URL4 = 'https://' + TEST_HOST + TEST_PATH + '/content.html';
var TEST_URL5 = 'http://' + TEST_HOST + TEST_PATH + '/content.html';
var TEST_EXPIRATION_DATE = 12345678900;
var TEST_ODD_DOMAIN_HOST_ONLY = 'strange stuff!!.com';
var TEST_ODD_DOMAIN = '.' + TEST_ODD_DOMAIN_HOST_ONLY;
var TEST_ODD_PATH = '/hello = world';
var TEST_ODD_URL = 'http://' + TEST_ODD_DOMAIN_HOST_ONLY + TEST_ODD_PATH + '/index.html';
var TEST_UNPERMITTED_URL = 'http://illegal.' + TEST_DOMAIN + '/';
var TEST_BASIC_COOKIE = {
url: TEST_URL,
name: 'api_test_cookie',
value: 'helloworld'
};
var TEST_DOMAIN_COOKIE = {
url: TEST_URL,
name: 'TEST_domain',
value: '32849395FFDSAA**##@@@',
domain: TEST_DOMAIN,
expirationDate: TEST_EXPIRATION_DATE
};
var TEST_SECURE_COOKIE = {
url: TEST_URL4,
name: 'SECRETCOOKIE',
value: 'foobar_password',
secure: true,
httpOnly: true
};
var TEST_BASIC_EXPIRED_COOKIE = {
url: TEST_BASIC_COOKIE.url,
name: TEST_BASIC_COOKIE.name,
value: TEST_BASIC_COOKIE.value,
expirationDate: 0
};
function readCookie(name) {
var nameEQ = name + '=';
var cookies = document.cookie.split(';');
for(var i=0; i < cookies.length; i++) {
var c = cookies[i];
while (c.charAt(0)==' ') {
c = c.substring(1);
}
if (c.indexOf(nameEQ) == 0) {
return c.substring(nameEQ.length);
}
}
return null;
}
function expectValidCookie(cookie) {
chrome.test.assertTrue(cookie != null, 'Expected cookie not set.');
}
function expectNullCookie(cookie) {
chrome.test.assertEq(null, cookie);
}
function expectUndefinedCookie(cookie) {
chrome.test.assertEq(undefined, cookie);
}
function removeTestCookies() {
chrome.cookies.remove(
{url: TEST_URL, name: TEST_BASIC_COOKIE.name});
chrome.cookies.remove(
{url: TEST_URL, name: TEST_DOMAIN_COOKIE.name});
chrome.cookies.remove(
{url: TEST_URL4, name: TEST_SECURE_COOKIE.name});
chrome.cookies.remove({url: TEST_URL, name: 'abcd'});
chrome.cookies.remove({url: TEST_URL, name: 'AA'});
chrome.cookies.remove({url: TEST_URL_HTTPS, name: 'A'});
chrome.cookies.remove({url: TEST_URL, name: 'AI'});
chrome.cookies.remove({url: TEST_URL, name: 'B'});
chrome.cookies.remove({url: TEST_URL, name: 'C'});
chrome.cookies.remove({url: TEST_URL, name: 'D'});
chrome.cookies.remove({url: TEST_ODD_URL, name: 'abcd'});
}
var pass = chrome.test.callbackPass;
var fail = chrome.test.callbackFail;
chrome.test.runTests([
function readCookies() {
chrome.test.assertEq('1', readCookie('a'));
chrome.test.assertEq('2', readCookie('b'));
chrome.test.assertEq('3', readCookie('c'));
chrome.test.assertEq(null, readCookie('nonexistent'));
// Invalid schemes don't work with the cookie API.
chrome.cookies.get(
{url: document.location.href, name: 'a'},
fail('No host permissions for cookies at url: "' +
document.location.href + '".'));
},
function getBasicCookie() {
removeTestCookies();
chrome.cookies.set(TEST_BASIC_COOKIE, pass(function () {
// Domain doesn't match.
chrome.cookies.get(
{url: TEST_URL2, name: TEST_BASIC_COOKIE.name},
pass(expectNullCookie));
// URL invalid.
chrome.cookies.get(
{url: 'invalid url', name: TEST_BASIC_COOKIE.name},
fail('Invalid url: "invalid url".'));
// URL lacking permissions.
chrome.cookies.get(
{url: TEST_UNPERMITTED_URL, name: TEST_BASIC_COOKIE.name},
fail('No host permissions for cookies at url: "' +
TEST_UNPERMITTED_URL + '".'));
// Store ID invalid.
chrome.cookies.get({
url: TEST_BASIC_COOKIE.url,
name: TEST_BASIC_COOKIE.name,
storeId: 'invalid'
}, fail('Invalid cookie store id: "invalid".'));
chrome.cookies.get(
{url: TEST_BASIC_COOKIE.url, name: TEST_BASIC_COOKIE.name},
pass(function(cookie) {
expectValidCookie(cookie);
chrome.test.assertEq(TEST_BASIC_COOKIE.name, cookie.name);
chrome.test.assertEq(TEST_BASIC_COOKIE.value, cookie.value);
chrome.test.assertEq(TEST_HOST, cookie.domain);
chrome.test.assertEq(true, cookie.hostOnly);
chrome.test.assertEq('/', cookie.path);
chrome.test.assertEq(false, cookie.secure);
chrome.test.assertEq(false, cookie.httpOnly);
chrome.test.assertEq('unspecified', cookie.sameSite);
chrome.test.assertEq(true, cookie.session);
chrome.test.assertTrue(typeof cookie.expirationDate === 'undefined',
'Session cookie should not have expirationDate property.');
chrome.test.assertTrue(typeof cookie.storeId !== 'undefined',
'Cookie store ID not provided.');
}));
}));
},
function getDomainCookie() {
removeTestCookies();
chrome.cookies.set(TEST_DOMAIN_COOKIE, pass(function () {
chrome.cookies.get(
{url: TEST_URL2, name: TEST_DOMAIN_COOKIE.name},
pass(function(cookie) {
expectValidCookie(cookie);
chrome.test.assertEq(TEST_DOMAIN_COOKIE.name, cookie.name);
chrome.test.assertEq(TEST_DOMAIN_COOKIE.value, cookie.value);
chrome.test.assertEq('.' + TEST_DOMAIN, cookie.domain);
chrome.test.assertEq(false, cookie.hostOnly);
chrome.test.assertEq('/', cookie.path);
chrome.test.assertEq(false, cookie.secure);
chrome.test.assertEq(false, cookie.httpOnly);
chrome.test.assertEq('unspecified', cookie.sameSite);
chrome.test.assertEq(false, cookie.session);
chrome.test.assertEq(TEST_EXPIRATION_DATE, cookie.expirationDate);
}));
}));
},
function getSecureCookie() {
removeTestCookies();
chrome.cookies.set(TEST_SECURE_COOKIE, pass(function () {
// URL doesn't work because scheme isn't secure.
chrome.cookies.get(
{url: TEST_URL5, name: TEST_SECURE_COOKIE.name},
pass(expectNullCookie));
// Path doesn't match.
chrome.cookies.get(
{url: TEST_URL3, name: TEST_SECURE_COOKIE.name},
pass(expectNullCookie));
chrome.cookies.get(
{url: TEST_URL4, name: TEST_SECURE_COOKIE.name},
pass(function(cookie) {
expectValidCookie(cookie);
chrome.test.assertEq(TEST_SECURE_COOKIE.name, cookie.name);
chrome.test.assertEq(TEST_SECURE_COOKIE.value, cookie.value);
chrome.test.assertEq(TEST_HOST, cookie.domain);
chrome.test.assertEq(true, cookie.hostOnly);
chrome.test.assertEq(TEST_PATH, cookie.path);
chrome.test.assertEq(true, cookie.secure);
chrome.test.assertEq(true, cookie.httpOnly);
chrome.test.assertEq('unspecified', cookie.sameSite);
chrome.test.assertEq(true, cookie.session);
}));
}));
},
function setOddCookies() {
removeTestCookies();
// URL lacking permissions.
chrome.cookies.set(
{url: TEST_UNPERMITTED_URL, name: 'abcd', domain: TEST_DOMAIN},
fail('No host permissions for cookies at url: "' +
TEST_UNPERMITTED_URL + '".',
function () {
chrome.cookies.get({url: TEST_URL, name: 'abcd'},
pass(expectNullCookie));
}));
// Attribute values containing invalid characters are disallowed.
chrome.cookies.set({url: TEST_URL, name: 'abcd=efg'}, fail(
'Failed to parse or set cookie named "abcd=efg".',
function() {
chrome.cookies.get({url: TEST_URL, name: 'abcd'},
pass(expectNullCookie));
}));
chrome.cookies.set(
{url: TEST_URL, name: 'abcd', value: 'HI;LO'},
fail(
'Failed to parse or set cookie named "abcd".',
function () {
chrome.cookies.get({url: TEST_URL, name: 'abcd'},
pass(expectNullCookie));
}));
chrome.cookies.set(
{url: TEST_URL, name: 'abcd', domain: 'cookies.com\r'},
fail(
'Failed to parse or set cookie named "abcd".',
function () {
chrome.cookies.get({url: TEST_URL, name: 'abcd'},
pass(expectNullCookie));
}));
chrome.cookies.set(
{url: TEST_URL, name: 'abcd', domain: 'somedomain.com'},
fail(
'Failed to parse or set cookie named "abcd".',
function () {
chrome.cookies.get({url: TEST_URL, name: 'abcd'},
pass(expectNullCookie));
}));
chrome.cookies.set({
url: TEST_ODD_URL,
name: 'abcd',
domain: TEST_ODD_DOMAIN,
path: TEST_ODD_PATH
}, pass(function () {
chrome.cookies.get({url: TEST_ODD_URL, name: 'abcd'},
pass(function(cookie) {
expectValidCookie(cookie);
chrome.test.assertEq(TEST_ODD_DOMAIN, unescape(cookie.domain));
chrome.test.assertEq(TEST_ODD_PATH, unescape(cookie.path));
}));
}));
},
function setSameSiteCookies() {
removeTestCookies();
// Property is left out
chrome.cookies.set(
{url: TEST_URL, name: "AA", value: "1"},
pass(function () {
chrome.cookies.get({url: TEST_URL, name: "AA"}, pass(function (c) {
expectValidCookie(c);
chrome.test.assertEq('unspecified', c.sameSite);
}));
}));
// No same-site restriction
chrome.cookies.set(
{url: TEST_URL_HTTPS, name: "A", value: "1", sameSite: "no_restriction",
secure: true},
pass(function () {
chrome.cookies.get({url: TEST_URL_HTTPS, name: "A"}, pass(function (c) {
expectValidCookie(c);
chrome.test.assertEq("no_restriction", c.sameSite);
}));
}));
// Lax same-site restriction
chrome.cookies.set(
{url: TEST_URL, name: "B", value: "1", sameSite: "lax"},
pass(function () {
chrome.cookies.get({url: TEST_URL, name: "B"}, pass(function (c) {
expectValidCookie(c);
chrome.test.assertEq("lax", c.sameSite);
}));
}));
// Strict same-site restriction
chrome.cookies.set(
{url: TEST_URL, name: "C", value: "1", sameSite: "strict"},
pass(function () {
chrome.cookies.get({url: TEST_URL, name: "C"}, pass(function (c) {
expectValidCookie(c);
chrome.test.assertEq("strict", c.sameSite);
}));
}));
// Unspecified
chrome.cookies.set(
{url: TEST_URL, name: "D", value: "1", sameSite: "unspecified"},
pass(function () {
chrome.cookies.get({url: TEST_URL, name: "D"}, pass(function (c) {
expectValidCookie(c);
chrome.test.assertEq('unspecified', c.sameSite);
}));
}));
},
function setSameSiteCookiesInsecureNone() {
chrome.test.getConfig(config => {
// No same-site restriction but also not secure. This should succeed if
// and only if the feature requiring SameSite=none cookies to be secure
// cookies is disabled.
var sameSiteNoneRequiresSecure = config.customArg === 'true';
removeTestCookies();
chrome.cookies.set(
{url: TEST_URL, name: "AI", value: "1", sameSite: "no_restriction"},
setResult => {
if (sameSiteNoneRequiresSecure) {
chrome.test.assertLastError(
'Failed to parse or set cookie named "AI".');
chrome.test.assertEq(null, setResult);
chrome.test.succeed();
} else {
chrome.test.assertNoLastError();
chrome.cookies.get(
{url: TEST_URL_HTTPS, name: "AI"},
pass(function (c) {
expectValidCookie(c);
chrome.test.assertEq("no_restriction", c.sameSite);
}));
}
});
});
},
function setCookiesWithCallbacks() {
removeTestCookies();
// Basics.
chrome.cookies.set(
TEST_BASIC_COOKIE,
pass(function(cookie) {
expectValidCookie(cookie);
chrome.test.assertEq(TEST_BASIC_COOKIE.name, cookie.name);
chrome.test.assertEq(TEST_BASIC_COOKIE.value, cookie.value);
chrome.test.assertEq(TEST_HOST, cookie.domain);
chrome.test.assertEq(true, cookie.hostOnly);
chrome.test.assertEq('/', cookie.path);
chrome.test.assertEq(false, cookie.secure);
chrome.test.assertEq(false, cookie.httpOnly);
chrome.test.assertEq(true, cookie.session);
chrome.test.assertTrue(typeof cookie.expirationDate === 'undefined',
'Session cookie should not have expirationDate property.');
chrome.test.assertTrue(typeof cookie.storeId !== 'undefined',
'Cookie store ID not provided.');
}));
// Invalid values generate callback with no arguments, and error messages
chrome.cookies.set(
{url: TEST_UNPERMITTED_URL, name: 'abcd', domain: TEST_DOMAIN},
fail(
'No host permissions for cookies at url: "'
+ TEST_UNPERMITTED_URL + '".',
expectUndefinedCookie));
chrome.cookies.set(
{url: TEST_URL, name: 'abcd=efg'},
fail('Failed to parse or set cookie named "abcd=efg".',
expectUndefinedCookie));
chrome.cookies.set(
{url: TEST_URL, name: 'abcd', value: 'HI;LO'},
fail('Failed to parse or set cookie named "abcd".',
expectUndefinedCookie));
chrome.cookies.set(
{url: TEST_URL, name: 'abcd', domain: 'cookies.com\r'},
fail('Failed to parse or set cookie named "abcd".',
expectUndefinedCookie));
chrome.cookies.set(
{url: TEST_URL, name: 'abcd', domain: 'somedomain.com'},
fail('Failed to parse or set cookie named "abcd".',
expectUndefinedCookie));
// Expired cookies generate callback with "null" cookie
chrome.cookies.set(TEST_BASIC_EXPIRED_COOKIE, pass(expectUndefinedCookie));
// Odd (but valid!) URLs get callbacks too!
chrome.cookies.set({
url: TEST_ODD_URL,
name: 'abcd',
domain: TEST_ODD_DOMAIN,
path: TEST_ODD_PATH
}, pass(function(cookie) {
expectValidCookie(cookie);
chrome.test.assertEq(TEST_ODD_DOMAIN, unescape(cookie.domain));
chrome.test.assertEq(TEST_ODD_PATH, unescape(cookie.path));
}));
},
function removeCookie() {
removeTestCookies();
chrome.cookies.set(TEST_BASIC_COOKIE, pass(function () {
chrome.cookies.get(
{url: TEST_URL, name: TEST_BASIC_COOKIE.name},
pass(function (c) {
expectValidCookie(c);
// Removal with any domain-matching URL will do.
chrome.cookies.remove(
{url: TEST_URL4, name: TEST_BASIC_COOKIE.name},
pass(function () {
chrome.cookies.get(
{url: TEST_URL, name: TEST_BASIC_COOKIE.name},
pass(expectNullCookie));
}));
}));
}));
// Set with an expired date should also remove the cookie.
chrome.cookies.set(TEST_BASIC_COOKIE, pass(function () {
chrome.cookies.get(
{url: TEST_URL, name: TEST_BASIC_COOKIE.name},
pass(expectValidCookie));
chrome.cookies.set(TEST_BASIC_EXPIRED_COOKIE, pass(function () {
chrome.cookies.get(
{url: TEST_URL, name: TEST_BASIC_COOKIE.name},
pass(expectNullCookie));
}));
}));
// Removal with a disallowed URL shouldn't do anything.
chrome.cookies.set(TEST_DOMAIN_COOKIE, pass(function () {
chrome.cookies.get(
{url: TEST_URL2, name: TEST_DOMAIN_COOKIE.name},
pass(function (c) {
expectValidCookie(c);
chrome.cookies.remove(
{url: TEST_UNPERMITTED_URL, name: TEST_DOMAIN_COOKIE.name},
fail(
'No host permissions for cookies at url: "'
+ TEST_UNPERMITTED_URL + '".',
function () {
chrome.cookies.get(
{url: TEST_URL2, name: TEST_DOMAIN_COOKIE.name},
pass(expectValidCookie));
}));
}));
}));
},
function removeCookiesWithCallbacks() {
removeTestCookies();
chrome.cookies.set(TEST_BASIC_COOKIE, pass(function () {
chrome.cookies.get(
{url: TEST_URL, name: TEST_BASIC_COOKIE.name},
pass(expectValidCookie));
// Removal with any domain-matching URL will trigger callback with the
// removed cookie's "url" and "name" fields.
chrome.cookies.remove(
{url: TEST_URL4, name: TEST_BASIC_COOKIE.name},
pass(function(data) {
chrome.test.assertEq(TEST_URL4, data.url);
chrome.test.assertEq(TEST_BASIC_COOKIE.name, data.name);
chrome.test.assertTrue(typeof data.storeId !== 'undefined',
'Cookie store ID not provided.');
}));
}));
// Removal with a disallowed URL should trigger the callback with no
// arguments, and a set error message.
chrome.cookies.set(TEST_DOMAIN_COOKIE, pass(function () {
chrome.cookies.remove(
{url: TEST_UNPERMITTED_URL, name: TEST_DOMAIN_COOKIE.name},
fail(
'No host permissions for cookies at url: "'
+ TEST_UNPERMITTED_URL + '".',
expectUndefinedCookie));
}));
},
function getAllCookies() {
removeTestCookies();
chrome.cookies.getAll({}, pass(function(cookies) {
chrome.test.assertEq(0, cookies.length);
}));
chrome.cookies.set(TEST_BASIC_COOKIE, pass(function () {
chrome.cookies.set(TEST_SECURE_COOKIE, pass(function () {
chrome.cookies.getAll(
{domain: TEST_DOMAIN}, pass(function(cookies) {
chrome.test.assertEq(2, cookies.length);
chrome.test.assertEq(TEST_SECURE_COOKIE.name, cookies[0].name);
chrome.test.assertEq(TEST_BASIC_COOKIE.name, cookies[1].name);
}));
chrome.cookies.getAll({
name: TEST_BASIC_COOKIE.name
}, pass(function(cookies) {
chrome.test.assertEq(1, cookies.length);
chrome.test.assertEq(TEST_BASIC_COOKIE.name, cookies[0].name);
}));
chrome.cookies.getAll({
secure: true
}, pass(function(cookies) {
chrome.test.assertEq(1, cookies.length);
chrome.test.assertEq(TEST_SECURE_COOKIE.name, cookies[0].name);
}));
chrome.cookies.getAll({
url: 'invalid url'
}, fail('Invalid url: "invalid url".'));
chrome.cookies.getAll({
url: TEST_URL,
}, pass(function(cookies) {
chrome.test.assertEq(1, cookies.length);
chrome.test.assertEq(TEST_BASIC_COOKIE.name, cookies[0].name);
}));
}));
}));
},
function getAllCookieStores() {
removeTestCookies();
chrome.cookies.getAllCookieStores(
pass(function(cookieStores) {
chrome.test.assertEq(1, cookieStores.length);
chrome.cookies.set(TEST_BASIC_COOKIE, pass(function () {
chrome.cookies.get(
{url: TEST_URL, name: TEST_BASIC_COOKIE.name},
pass(function(cookie) {
chrome.test.assertEq(cookieStores[0].id, cookie.storeId);
}));
chrome.cookies.getAll(
{storeId: cookieStores[0].id},
pass(function(cookies) {
chrome.test.assertEq(1, cookies.length);
chrome.test.assertEq(TEST_BASIC_COOKIE.name, cookies[0].name);
}));
}));
}));
}
]);
chrome/test/data/extensions/api_test/cookies/read_from_doc/background.js 0 → 100644
View file @ 8764d28d
// Copyright 2020 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Ensure we started with an empty profile.
chrome.test.assertEq(document.cookie, "");
// Set some cookies with a few different modifiers.
var expire = new Date();
expire.setDate(expire.getDate() + 1); // tomorrow
document.cookie = "a=1";
document.cookie = "b=2; path=/; domain=" + location.host;
document.cookie = "c=3; path=/; expires=" + expire +
"; domain=" + location.host;
// Open a tab. This doesn't really prove we're writing to disk, but it is
// difficult to prove that without shutting down the process.
chrome.tabs.create({url: "tab.html"});
chrome/test/data/extensions/api_test/cookies/read_from_doc/manifest.json 0 → 100644
View file @ 8764d28d
{
"name": "chrome.cookies.invalid_schemes",
"version": "0.1",
"manifest_version": 2,
"description": "Tests Cookies API.",
"background": {
"scripts": ["background.js"]
},
"permissions": ["cookies"]
}
chrome/test/data/extensions/api_test/cookies/read_from_doc/tab.js 0 → 100644
View file @ 8764d28d
// Copyright 2020 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
function readCookie(name) {
var nameEQ = name + '=';
var cookies = document.cookie.split(';');
for(var i=0; i < cookies.length; i++) {
var c = cookies[i];
while (c.charAt(0)==' ') {
c = c.substring(1);
}
if (c.indexOf(nameEQ) == 0) {
return c.substring(nameEQ.length);
}
}
return null;
}
chrome.test.runTests([
function readCookiesFromDoc() {
chrome.test.assertEq('1', readCookie('a'));
chrome.test.assertEq('2', readCookie('b'));
chrome.test.assertEq('3', readCookie('c'));
chrome.test.assertEq(null, readCookie('nonexistent'));
chrome.test.succeed();
},
]);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment